Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

On 2013/04/30 03:10:52, Keith wrote: The commit 'simplify stack-stencils' seems strange, and wrong in one detail. I suppose that stacking the stencils from start of list to end is a bit simpler conceptually. "reduce" is appropriate to use here. The line stacking (with baseline), in contras

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

https://codereview.appspot.com/8869044/diff/22012/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/8869044/diff/22012/scm/stencil.scm#newcode46 scm/stencil.scm:46: (lambda (tail head) On 2013/04/30 03:10:52, Keith wrote: Usually, the head is fixed-length and the tail

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

The commit 'simplify stack-stencils' seems strange, and wrong in one detail. I suppose that stacking the stencils from start of list to end is a bit simpler conceptually. From my point-of-view as a non-programmer, and certainly non-schemer, the new code is not simpler to understand. https://c

Re: Issue 3293: Add point-and-click to SVG output (issue 8974043)

On 2013/04/29 15:57:10, Graham Percival wrote: Cool, that looks much better than my previous patch. Thanks! Unfortunately, although firefox and inkscape handle the resulting svg file quite well, it isn't a valid file. According to the w3c validator http://validator.w3.org/check svg 1.1

Re: Issue 3293: Add point-and-click to SVG output (issue 8974043)

Cool, that looks much better than my previous patch. Thanks! Unfortunately, although firefox and inkscape handle the resulting svg file quite well, it isn't a valid file. According to the w3c validator http://validator.w3.org/check svg 1.1 cannot contain a without an xlink attribute. Now, w

Re: Point and Click does not work on Windows

- Original Message - From: "Eluze" To: Sent: Monday, April 29, 2013 10:54 AM Subject: Re: Point and Click does not work on Windows what's the status of this issue? I've installed 2.1.7.17 but point and click doesn't work (is it supposed to?!) The point and click link between the

Re: Better shape control of arpeggio brackets. (issue 8859051)

LGTM https://codereview.appspot.com/8859051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Better shape control of arpeggio brackets. (issue 8859051)

Reviewers: Trevor Daniels, Message: OK, will use `protrusion'. `edge-length' is already taken, unfortunately, for exactly the same thing, namely to control tuplet brackets. However, this is a pair value, while arpeggio brackets use a different mechanism (namely the ly:bracket interface) which n

Re: Point and Click does not work on Windows

what's the status of this issue? I've installed 2.1.7.17 but point and click doesn't work (is it supposed to?!) - trying point and click in a pdf file I get Clipboard.png and an empty tab is created in the browser. - then I

Better shape control of arpeggio brackets. (issue 8859051)

https://codereview.appspot.com/8859051/diff/1/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): https://codereview.appspot.com/8859051/diff/1/scm/define-grob-properties.scm#newcode737 scm/define-grob-properties.scm:737: (protrude ,number? "In an arpeggio bracket, the le

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

On 2013/04/29 07:35:05, janek wrote: On 2013/04/28 23:16:28, dak wrote: ok, and i agree that adding a comment like this into the source may not be a good idea. However, git commit message has a different purpose (to myself at least); i want to know why something changed. When i'm searchi

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

On 2013/04/29 07:39:04, Keith wrote: On 2013/04/29 07:26:50, janek wrote: > On 2013/04/29 03:31:14, Keith wrote: > > I worry a little about making the extent of markup different from the union of > > its components. Someone may have used c4^\markup{\hspace #-3 "text"} and > > the left side

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

On 2013/04/29 07:26:50, janek wrote: On 2013/04/29 03:31:14, Keith wrote: > I worry a little about making the extent of markup different from the union of > its components. Someone may have used c4^\markup{\hspace #-3 "text"} and > the left side of the "text" is now vulnerable to collision

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

On 2013/04/28 23:16:28, dak wrote: On 2013/04/28 21:59:37, janek wrote: > changes i see generally LGTM (but i may be missing something, in particular > Keith seems to make a good point). > > > Let Stencil::is_empty use Box::is_empty [...] > > I think the desription of this commit could use some

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

On 2013/04/29 03:31:14, Keith wrote: I worry a little about making the extent of markup different from the union of its components. Someone may have used c4^\markup{\hspace #-3 "text"} and the left side of the "text" is now vulnerable to collisions. I'd say that such a result is ok. I t