Re: Avoids calling pure calculations too far downstream and avoids triggering quanting too far upstream (issue 12951044)

2013-08-14 Thread k-ohara5a5a
On 2013/08/15 06:12:15, mike7 wrote: On 15 août 2013, at 09:03, mailto:k-ohara5...@oco.net wrote: > Well, the thing we did not want was to have ottava brackets ignored for > staff-spacing. > The bracket overlaps the next staff the same way, Ok, so, the bracket is ignoring the cross-staff ste

Re: Avoids calling pure calculations too far downstream and avoids triggering quanting too far upstream (issue 12951044)

2013-08-14 Thread Mike Solomon
On 15 août 2013, at 09:03, k-ohara5...@oco.net wrote: > On 2013/08/15 05:51:36, mike7 wrote: >> On 15 août 2013, at 08:35, mailto:k-ohara5...@oco.net wrote: > >> > Could you mark the relevant object as 'cross-staff' when the > cross-staff >> > item is added to it 'support', rather than search th

Re: Avoids calling pure calculations too far downstream and avoids triggering quanting too far upstream (issue 12951044)

2013-08-14 Thread k-ohara5a5a
> If the spanners have never successfully responded to the position of > cross-staff support, we should just skip cross-staff items from the > support. > This is a great idea, but I'm not sure the best way to implement it. It's not possible at the engraver stage when the grobs are originally p

Re: Avoids calling pure calculations too far downstream and avoids triggering quanting too far upstream (issue 12951044)

2013-08-14 Thread k-ohara5a5a
On 2013/08/15 05:51:36, mike7 wrote: On 15 août 2013, at 08:35, mailto:k-ohara5...@oco.net wrote: > Could you mark the relevant object as 'cross-staff' when the cross-staff > item is added to it 'support', rather than search through its support > later? see above: this would mean that o

Re: Avoids calling pure calculations too far downstream and avoids triggering quanting too far upstream (issue 12951044)

2013-08-14 Thread Mike Solomon
On 15 août 2013, at 08:51, k-ohara5...@oco.net wrote: > On 2013/08/15 05:35:49, Keith wrote: > >> In most cases, 'cross-staff' means exactly that the height (Y-extent) > depends on >> staff-spacing. > > Oh. It is the ottava bracket from the example for issue 3385 that is > not cross-staff, > b

Re: Avoids calling pure calculations too far downstream and avoids triggering quanting too far upstream (issue 12951044)

2013-08-14 Thread Mike Solomon
On 15 août 2013, at 08:35, k-ohara5...@oco.net wrote: > Of course this is two commits. > probably three (axis-group-interface.cc and two independent changes in side-position-interface.cc). > I do not know of any reason to distinguish the concept of 'cross-staff' > from your new > height_depend

Re: Avoids calling pure calculations too far downstream and avoids triggering quanting too far upstream (issue 12951044)

2013-08-14 Thread k-ohara5a5a
On 2013/08/15 05:35:49, Keith wrote: In most cases, 'cross-staff' means exactly that the height (Y-extent) depends on staff-spacing. Oh. It is the ottava bracket from the example for issue 3385 that is not cross-staff, but whose positioning references a cross-staff beam. But if we change t

Avoids calling pure calculations too far downstream and avoids triggering quanting too far upstream (issue 12951044)

2013-08-14 Thread k-ohara5a5a
Of course this is two commits. I do not know of any reason to distinguish the concept of 'cross-staff' from your new height_depends_on_grobs_from_another_vertical_ axis_group() In most cases, 'cross-staff' means exactly that the height (Y-extent) depends on staff-spacing. Could you mark th

Re: colorful make output! yum!

2013-08-14 Thread Franciszek Boehlke
Hi, thanks for your replies, and thanks Janek for pushing and advertising my patch :) Janek has pushed a bit newer version just a few minutes ago (it doesn't change anything important, just colorizes 2 more rules, and everything is squashed into one commit). We have enough trouble maintaining ou

Re: maintaining advanced power-user Scheme functions

2013-08-14 Thread Pierre Perol-Schneider
Hi Janek, Hi Harm, 2013/8/14 Thomas Morley > > So I was annoyed by the lack of help/interest of others and I'm still > pissed off. > > Sorry for that, I think I totaly missed this discussion. > Volunteers? > Be sure that I'd grant support. > Sure ! Maybe give me some links where I can find h

Re: maintaining advanced power-user Scheme functions

2013-08-14 Thread Thomas Morley
2013/8/14 Janek Warchoł : > Hi, > > Harm and David N. (and some other people) write lots of very advanced > (and very helpful!) Scheme functions. These funcitons are improved > over time, and there is a problem related to that: it's easy to get > lost in all the email threads about them, and it's

Remove 'thickness from LedgerLineSpanner interface. (issue 12945044)

2013-08-14 Thread tdanielsmusic
LGTM, apart from a query https://codereview.appspot.com/12945044/diff/1/lily/ledger-line-spanner.cc File lily/ledger-line-spanner.cc (right): https://codereview.appspot.com/12945044/diff/1/lily/ledger-line-spanner.cc#newcode331 lily/ledger-line-spanner.cc:331: " property of the @rinternals{Staf

Re: trill-pitch-engraver: acknowledge stems and flags; issue 3465 (issue 12844043)

2013-08-14 Thread Keith OHara
On Wed, 14 Aug 2013 05:03:40 -0700, wrote: I'm in a rush right now so can't test. But would that even help with whole notes and breves? ... or a down-stem note with a pitched trill more than a third above. If there is room to move the small note over the main note, this patch allows the sm

Re: Issue 3491: Add \displayMarkup command. (issue 12732043)

2013-08-14 Thread thomasmorley65
LGTM https://codereview.appspot.com/12732043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: PATCHES: Countdown for August 17th - 06:00 GMT

2013-08-14 Thread Mark Polesky
David Kastrup wrote: > Partly that's just because potential reviewers also rely > on your decisions, so if you put back a patch from > countdown or don't even place it on one, people might just > have postponed taking a look. With that in mind, developers should be sure to review my patch, which i

Re: colorful make output! yum!

2013-08-14 Thread Jan Nieuwenhuizen
Janek Warchoł writes: > my cousin Franek changed the output of make from a heap of unreadable > gobbledygook to some delicious eye-candy! Checkout branch > dev/frax/colorful-make and build lilypond. How do you like it? The result looks nice but if you want any chance of putting this in, it shou

Re: How are stems created?

2013-08-14 Thread Phil Holmes
- Original Message - From: "Janek Warchoł" To: "Phil Holmes" Cc: "Devel" Sent: Wednesday, August 14, 2013 6:20 PM Subject: Re: How are stems created? Hi Phil, 2013/8/14 Phil Holmes : - Original Message - From: "Janek Warchol" Are you still working on this? I was looking

Re: Make several special characters with or without backslash "non-special" (issue 12432043)

2013-08-14 Thread thomasmorley65
On 2013/08/14 13:30:24, dak wrote: I don't think we help anybody by providing two shorthands for one particular articulation. +1 Anybody else with an opinion regarding -! or -' (and of course the corresponding _! ^! _' ^' too) as the shorthand for staccatissimo, replacing the previous -| (w

Re: How are stems created?

2013-08-14 Thread Janek Warchoł
Hi Phil, 2013/8/14 Phil Holmes : > - Original Message - From: "Janek Warchol" >> Are you still working on this? I was looking at this area of the code >> with my alignment work >> (http://code.google.com/p/lilypond/issues/detail?id=3239 and others, >> which are the foundation for actually

Re: How are stems created?

2013-08-14 Thread Phil Holmes
- Original Message - From: "Janek Warchol" To: "Phil Holmes" Cc: "Devel" Sent: Wednesday, August 14, 2013 1:09 PM Subject: Re: How are stems created? Hi Phil, 2013/7/30 Phil Holmes : I've been experimenting with alternative algorithms to create the flags used in mensural notation

Re: colorful make output! yum!

2013-08-14 Thread David Kastrup
Janek Warchoł writes: > Hi, > > my cousin Franek changed the output of make from a heap of unreadable > gobbledygook to some delicious eye-candy! Checkout branch > dev/frax/colorful-make and build lilypond. How do you like it? > > As for me, i can spend whole day just looking at lilypond being

Re: Make several special characters with or without backslash "non-special" (issue 12432043)

2013-08-14 Thread dak
On 2013/08/14 12:18:12, janek wrote: 2013/8/14 : > I crosschecked with the parser and it would not object to either. The > only argument _for_ such a change would be more visual similarity rather > than mnemonic value and that rules out -, pretty definitely. One could > talk about -' a

colorful make output! yum!

2013-08-14 Thread Janek Warchoł
Hi, my cousin Franek changed the output of make from a heap of unreadable gobbledygook to some delicious eye-candy! Checkout branch dev/frax/colorful-make and build lilypond. How do you like it? As for me, i can spend whole day just looking at lilypond being built. I think we should add this t

maintaining advanced power-user Scheme functions

2013-08-14 Thread Janek Warchoł
Hi, Harm and David N. (and some other people) write lots of very advanced (and very helpful!) Scheme functions. These funcitons are improved over time, and there is a problem related to that: it's easy to get lost in all the email threads about them, and it's not always obvious where the most rec

Re: trill-pitch-engraver: acknowledge stems and flags; issue 3465 (issue 12844043)

2013-08-14 Thread Janek Warchoł
2013/8/14 : > I'm in a rush right now so can't test. But would that even help with > whole notes and breves? Good point. But i think that this can be added anyway, as it makes sense in itself. ___ lilypond-devel mailing list lilypond-devel@gnu.org ht

Re: Make several special characters with or without backslash "non-special" (issue 12432043)

2013-08-14 Thread Janek Warchoł
2013/8/14 : > I don't really agree. staccato is -. so it seems natural for me to have > staccatissimo as -! (I mean, it was -| before). In addition, ' and , > are slanted in most fonts and that does not really match the visuals of > staccatissimo. > > I crosschecked with the parser and it would

Re: How are stems created?

2013-08-14 Thread Janek Warchoł
Hi Phil, 2013/7/30 Phil Holmes : > I've been experimenting with alternative algorithms to create the flags used > in mensural notation (see > http://code.google.com/p/lilypond/issues/detail?id=3105), and part of the > problem appears to be that the stems aren't attached symmetrically to the > note

Re: trill-pitch-engraver: acknowledge stems and flags; issue 3465 (issue 12844043)

2013-08-14 Thread dak
I'm in a rush right now so can't test. But would that even help with whole notes and breves? https://codereview.appspot.com/12844043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Make several special characters with or without backslash "non-special" (issue 12432043)

2013-08-14 Thread dak
On 2013/08/14 11:43:08, janek wrote: On 2013/08/14 11:41:43, janek wrote: > A general question: what about using -' or -, for staccatissimo? For me they > seem to be somewhat more intuitive. Additional advantage would be that they don't require Shift to produce on standard keyboard. Jan

trill-pitch-engraver: acknowledge stems and flags; issue 3465 (issue 12844043)

2013-08-14 Thread janek . lilypond
LGTM. https://codereview.appspot.com/12844043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Increase tagline spacing (Issue 3214) (issue 12562050)

2013-08-14 Thread janek . lilypond
LGTM https://codereview.appspot.com/12562050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

make website fails on platforms where python3 is the default. (issue 12769043)

2013-08-14 Thread janek . lilypond
LGTM https://codereview.appspot.com/12769043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds bar line section to LM (Issue 3408) (issue 12724043)

2013-08-14 Thread janek . lilypond
The content LGTM. https://codereview.appspot.com/12724043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Make several special characters with or without backslash "non-special" (issue 12432043)

2013-08-14 Thread janek . lilypond
On 2013/08/14 11:41:43, janek wrote: A general question: what about using -' or -, for staccatissimo? For me they seem to be somewhat more intuitive. Additional advantage would be that they don't require Shift to produce on standard keyboard. Janek https://codereview.appspot.com/12432043/

Re: Make several special characters with or without backslash "non-special" (issue 12432043)

2013-08-14 Thread janek . lilypond
Hi, i'm late with my comments but i'll publish them anyway. A general question: what about using -' or -, for staccatissimo? For me they seem to be somewhat more intuitive. Janek https://codereview.appspot.com/12432043/diff/23001/lily/parser.yy File lily/parser.yy (right): https://coderevie

Re: PATCHES: Countdown for August 17th - 06:00 GMT

2013-08-14 Thread David Kastrup
James writes: > That is if a 'real developer' sees that I have made a mistake or > misinterpreted something in the tracker or Rietveld (especially when > conversation between devs gets a bit convoluted) then by all means > correct my mistake - David et al, do this all the time. Well, it seems li

Re: PATCHES: Countdown for August 17th - 06:00 GMT

2013-08-14 Thread James
Mark, On 14 August 2013 08:43, Mark Polesky wrote: > James wrote: > > >Moved to 'Needs Work' this countdown > >3491 Enhancement Mark Polesky Needs Work Add \displayMarkup command. > > ... > >Thomasmorely651 has some comments > James, > > can you move my patch into the countdown for the 17th? >

Re: PATCHES: Countdown for August 17th - 06:00 GMT

2013-08-14 Thread Mark Polesky
James wrote: >Moved to 'Needs Work' this countdown >3491 Enhancement  Mark Polesky Needs Work Add \displayMarkup command.  ... >Thomasmorely651 has some comments James, can you move my patch into the countdown for the 17th? I incorporated Harm's suggestions a day ago. Thanks, Mark _

PATCHES: Countdown for August 17th - 06:00 GMT

2013-08-14 Thread James
Hello *Countdown – August 17th – 06:00 GMT* * * * * * * * * 3487 Enhancement David Kastrup push Patch: Make several specia

Re: untangling the remaining regressions

2013-08-14 Thread Mike Solomon
On 14 août 2013, at 09:58, Keith OHara wrote: > > > Mike posted three patches to issue 3385 that attempted to go halfway > backwards, partially restoring the pure-relevant? test, but these > ran into regressions. > > Going forward would be to make the pure versions of these functions, > actua