Re: Tie Crusade - what to do now

2013-08-19 Thread Frédéric Bron
diff --git a/lily/engraver.cc b/lily/engraver.cc index b8bf123..dfd2c21 100644 --- a/lily/engraver.cc +++ b/lily/engraver.cc @@ -105,20 +105,21 @@ LY_DEFINE (ly_set_grob_creation_callback, "ly:set-grob-creation-callback", Grob * Engraver::internal_make_grob (SCM symbol,

Re: Tie Crusade - what to do now

2013-08-19 Thread Frédéric Bron
diff --git a/flower/include/std-string.hh b/flower/include/std-string.hh index 5b7d2af..22a5f1b 100644 --- a/flower/include/std-string.hh +++ b/flower/include/std-string.hh @@ -35,7 +35,8 @@ #include +/// ARGH! What does it do in header?!?! It's death, , it's total destruction! It burns my e

Re: Tie Crusade - what to do now

2013-08-19 Thread Frédéric Bron
diff --git a/lily/tie.cc b/lily/tie.cc index 88d3ee4..227ea3f 100644 --- a/lily/tie.cc +++ b/lily/tie.cc @@ -99,20 +99,24 @@ Tie::get_column_rank (Grob *me, Direction d) { Grob *col = 0; Spanner *span = dynamic_cast (me); if (!span) col = dynamic_cast (me)->get_column (); else

Re: Tie Crusade - what to do now

2013-08-19 Thread Frédéric Bron
> For the programmers, i'd like to ask you to look at the branch > dev/tie-crusade/comments > and read the comments we've added to the code together with Franek. Just in case some would need, we can read all the added comments with: git diff 5c99661096f110920b86c61e99b460514fcfa9e2^ remotes/origin

Re: colorful make output! yum!

2013-08-19 Thread Dan Eble
On 2013-08-19, at 15:33 , Janek Warchoł wrote: > PS i don't consider the above bug with color codes a serious problem > (but maybe i'm wrong?): lilypond builds as usual, and make output is > still more readable than before. Pardon me for butting in, but is maintaining this feature better than

Re: changes: mention that decimal numbers can be written without # (issue 13007044)

2013-08-19 Thread tdanielsmusic
Sorry to nitpick, otherwise LGTM No need to post a new patch set. https://codereview.appspot.com/13007044/diff/13001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/13007044/diff/13001/Documentation/changes.tely#newcode68 Documentation/changes.

Re: changes: mention that decimal numbers can be written without # (issue 13007044)

2013-08-19 Thread janek . lilypond
Thanks, Trevor! Corrected. https://codereview.appspot.com/13007044/diff/5001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/13007044/diff/5001/Documentation/changes.tely#newcode65 Documentation/changes.tely:65: Decimal numbers can now be writ

Re: changes: mention that decimal numbers can be written without # (issue 13007044)

2013-08-19 Thread janek . lilypond
Thanks, Trevor! Corrected. https://codereview.appspot.com/13007044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Uses single algorithm for side-position spacing. (issue 6827072)

2013-08-19 Thread k-ohara5a5a
I'm away for a few days. https://codereview.appspot.com/6827072/diff/38003/lily/pointer-group-interface.cc File lily/pointer-group-interface.cc (right): https://codereview.appspot.com/6827072/diff/38003/lily/pointer-group-interface.cc#newcode74 lily/pointer-group-interface.cc:74: // computation

Re: changes: mention that decimal numbers can be written without # (issue 13007044)

2013-08-19 Thread tdanielsmusic
Slightly better English, otherwise LGTM https://codereview.appspot.com/13007044/diff/5001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/13007044/diff/5001/Documentation/changes.tely#newcode65 Documentation/changes.tely:65: Decimal numbers can

Re: changes: mention that decimal numbers can be written without # (issue 13007044)

2013-08-19 Thread Janek Warchoł
2013/8/19 : > > https://codereview.appspot.com/13007044/diff/1/Documentation/changes.tely > File Documentation/changes.tely (right): > > https://codereview.appspot.com/13007044/diff/1/Documentation/changes.tely#newcode76 > Documentation/changes.tely:76: @end lilypond > Did you mean to use an @exam

changes: mention that decimal numbers can be written without # (issue 13007044)

2013-08-19 Thread pkx166h
https://codereview.appspot.com/13007044/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/13007044/diff/1/Documentation/changes.tely#newcode76 Documentation/changes.tely:76: @end lilypond Did you mean to use an @example here instead of an @

Re: colorful make output! yum!

2013-08-19 Thread Janek Warchoł
Hi, 2013/8/15 David Kastrup : > Franciszek Boehlke writes: > >> I think I can promise to support and maintain it. > > If we have a subsystem depend on continued support by a single person, > it must be easy to remove the subsystem as a whole. > > Consider it LilyPond's life insurance. We don't r

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread Janek Warchoł
2013/8/19 Phil Holmes : > - Original Message - From: "Janek Warchol" >> What you said would be true if the snippets were so simple that they >> never change. But they do change. > > Hardly ever. I maintain the current LSR and the changes are so infrequent I > often forget to check whether

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread Paul Morris
I'll throw in a couple of my thoughts: A. The user-friendly web interface for contributing snippets to the LSR is really key for it to work for novice users like myself (at least when I started). I find it quite convenient and easy to use. If I had had to learn git in order to contribute a snipp

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread Phil Holmes
2013/8/19 Phil Holmes m...@philholmes.net: This will be my last post on this. > - Original Message - From: "Janek Warchol" > >> 2013/8/19 Phil Holmes : >> > However, my other opposition to git for this >> > purpose is that it's intended as a Version Control system, which is >> > comp

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread Janek Warchoł
2013/8/19 Phil Holmes : > - Original Message - From: "Janek Warchoł" > >> 2013/8/19 Phil Holmes : >> > However, my other opposition to git for this >> > purpose is that it's intended as a Version Control system, which is >> > completely unnecessary for the LSR - that's just a simple databa

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread Phil Holmes
- Original Message - From: "Janek Warchoł" To: "Phil Holmes" Cc: "Thomas Morley" ; "lilypond-user" ; "Phil Hézaine" ; "David Nalesnik" ; "LilyPond Developmet Team" Sent: Monday, August 19, 2013 3:17 PM Subject: Re: maintaining advanced power-user Scheme functions Hi, some thing

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread Janek Warchoł
Hi, some things were already answered by other people 2013/8/19 Phil Holmes : > - Original Message - From: "Janek Warchoł" >> A valid concern, but i have a counterargument: there is a web >> interface for git that allows you to copy-and-paste code directly in, >> or alternatively to type

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread Janek Warchoł
2013/8/19 Werner LEMBERG : >> Well, one question may be whether git could be an alternate >> interface into the LSR. In a limited manner, it already is >> (snippets migrate back from LilyPond git repository into the LSR). > > Actually, I like the idea of using git for the LSR *as the storage*. > E

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread Werner LEMBERG
> Well, one question may be whether git could be an alternate > interface into the LSR. In a limited manner, it already is > (snippets migrate back from LilyPond git repository into the LSR). Actually, I like the idea of using git for the LSR *as the storage*. Experienced cann access it directly,

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread David Kastrup
"Phil Holmes" writes: > - Original Message - > From: "Janek Warchoł" > To: "Thomas Morley" > Cc: "lilypond-user" ; "Phil Hézaine" > ; "David Nalesnik" > ; "LilyPond Developmet Team" > > Sent: Sunday, August 18, 2013 9:46 PM > Subject: Re: maintaining advanced power-user Scheme functio

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread Janek Warchoł
2013/8/19 Urs Liska : > PS: I'd also second the idea of hosting lilypond on a more accessible server > (if that doesn't imply complicated side-effects). It is so easy to create a > fork and open a pull request, I'm sure such a step would increase the number > of contributions by people who can't or

Re: Allow decimal fractions with non-empty parts before and after '.' in music (issue 11682043)

2013-08-19 Thread Janek Warchoł
2013/8/18 : > WOW!! I've just found this patch and this is awesome!! > In my eyes, this single patch made LilyPond 2 times more user-friendly. > > I think that this is totally worth of an entry in "changes" - i would be > soo sorry if i hadn't found this change by accident today. Would > you

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread Phil Holmes
I think making it version independent might be easier to wish for than to provide! I believe the source code is available if you'd like to try getting it running on alternative infrastructure and updating it: http://lsr.dsi.unimi.it/download/ -- Phil Holmes - Original Message -

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread Phil Holmes
- Original Message - From: "Janek Warchoł" To: "Phil Holmes" Cc: "Thomas Morley" ; "lilypond-user" ; "Phil Hézaine" ; "David Nalesnik" ; "LilyPond Developmet Team" Sent: Monday, August 19, 2013 11:02 AM Subject: Re: maintaining advanced power-user Scheme functions 2013/8/19 Phil

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread Urs Liska
One thing I'd definitely support about this is making LSR somewhat version independent to allow one to have snippets requiring new lily versions. Maybe providing several lily versions (not necessarily _all_ of course) and use an appropriate one to compile the snippets. This would also allow us to

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread Urs Liska
One thing I'd definitely support about this is making LSR somewhat version independent to allow one to have snippets requiring new lily versions. Maybe providing several lily versions (not necessarily _all_ of course) and use an appropriate one to compile the snippets. This would also allow us to

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread Janek Warchoł
2013/8/19 Phil Holmes : > - Original Message - From: "Janek Warchoł" >> After some thinking, i came to the conclusion that LSR should be >> redesigned. >> Fristly, it should be a git repository, to make collaboration easy - >> when something's a git repository, i have a habit of contributin

Re: maintaining advanced power-user Scheme functions

2013-08-19 Thread Phil Holmes
- Original Message - From: "Janek Warchoł" To: "Thomas Morley" Cc: "lilypond-user" ; "Phil Hézaine" ; "David Nalesnik" ; "LilyPond Developmet Team" Sent: Sunday, August 18, 2013 9:46 PM Subject: Re: maintaining advanced power-user Scheme functions After some thinking, i came to th