LGTM, except of using `surrogate' in the name. Given that the stencil
dimensions are actively overridden on request, I would like rather like
having `override'. For me, the word `surrogate' suggests something
passive.
https://codereview.appspot.com/12957047/
___
On 24 août 2013, at 10:18, lemzw...@googlemail.com wrote:
> LGTM, except of using `surrogate' in the name. Given that the stencil
> dimensions are actively overridden on request, I would like rather like
> having `override'. For me, the word `surrogate' suggests something
> passive.
>
> https:
On 2013/08/24 08:05:13, mike7 wrote:
On 24 août 2013, at 10:18, mailto:lemzw...@googlemail.com wrote:
> LGTM, except of using `surrogate' in the name. Given that the
stencil
> dimensions are actively overridden on request, I would like rather
like
> having `override'. For me, the word `s
On 2013/08/24 08:25:14, dak wrote:
On 2013/08/24 08:05:13, mike7 wrote:
> On 24 août 2013, at 10:18, mailto:lemzw...@googlemail.com wrote:
>
> > LGTM, except of using `surrogate' in the name. Given that the
stencil
> > dimensions are actively overridden on request, I would like rather
like
>
Sent from my iPhone
On 24 août 2013, at 12:47, pkx1...@gmail.com wrote:
> On 2013/08/24 08:25:14, dak wrote:
>> On 2013/08/24 08:05:13, mike7 wrote:
>> > On 24 août 2013, at 10:18, mailto:lemzw...@googlemail.com wrote:
>> >
>> > > LGTM, except of using `surrogate' in the name. Given that the
>
Here's a patch that adds a new context, NullVoice, to
provide users with an easier way to have shared lyrics among
polyphonic voices, which also allows using lyrics with
\partcombine. This is a complete rewrite of a similar patch
from a month ago.
Please review.
Thanks!
- Mark
https://coderevie
On 2013/08/24 10:05:17, mike7 wrote:
The stencil command takes the skyline of stencil X and uses it as a
replacement
for skyline Y. We could use replacement-skyline-stencil as the
command.
I'd just use skyline-stencil here. If specified, it is the stencil used
for skylines.
https://coderev
LGTM, apart from one suggested change that I'd like
to see.
https://codereview.appspot.com/11328043/diff/21001/Documentation/notation/vocal.itely
File Documentation/notation/vocal.itely (right):
https://codereview.appspot.com/11328043/diff/21001/Documentation/notation/vocal.itely#newcode1716
Do
On 2013/08/24 10:31:38, dak wrote:
On 2013/08/24 10:05:17, mike7 wrote:
>
> The stencil command takes the skyline of stencil X and uses it as a
replacement
> for skyline Y. We could use replacement-skyline-stencil as the
command.
I'd just use skyline-stencil here. If specified, it is the sten
pushed as 59ee8eafd377bd11a4b0bf104db9aafc96b56d27
https://codereview.appspot.com/13007044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 24 août 2013, at 13:38, d...@gnu.org wrote:
> On 2013/08/24 10:31:38, dak wrote:
>> On 2013/08/24 10:05:17, mike7 wrote:
>> >
>> > The stencil command takes the skyline of stencil X and uses it as a
>> replacement
>> > for skyline Y. We could use replacement-skyline-stencil as the
> command.
>
On 2013/08/24 13:19:30, mike7 wrote:
The question I'm asking is "How can I allow the user to replace the
skyline of a
stencil with another shape?"
I got that. But what is the actual use case for that? Before skylines
became a thing, you could override the X-extent or the Y-extent of
grobs,
The LilyPond meeting scheduled for last week has been postponed since
after a few last-minute cancellations we just were too few to make any
sense, apart from a three-person meeting not involving large drives.
Very interesting, by the way.
So we now have rescheduled the meeting to the second half
https://codereview.appspot.com/12957047/diff/46001/lily/paper-system.cc
File lily/paper-system.cc (right):
https://codereview.appspot.com/12957047/diff/46001/lily/paper-system.cc#newcode55
lily/paper-system.cc:55: if (head == ly_symbol2scm ("skyline-stencil"))
It seems awkward and error-prone to
On 24 août 2013, at 16:36, d...@gnu.org wrote:
> On 2013/08/24 13:19:30, mike7 wrote:
>
>> The question I'm asking is "How can I allow the user to replace the
> skyline of a
>> stencil with another shape?"
>
> I got that. But what is the actual use case for that? Before skylines
> became a th
https://codereview.appspot.com/12957047/diff/46001/lily/paper-system.cc
File lily/paper-system.cc (right):
https://codereview.appspot.com/12957047/diff/46001/lily/paper-system.cc#newcode55
lily/paper-system.cc:55: if (head == ly_symbol2scm ("skyline-stencil"))
On 2013/08/24 16:19:27, dak wrote:
On 2013-08-23, at 09:50 , David Kastrup wrote:
> Frédéric Bron writes:
>>
>> Of course I am not speaking of new strings created in the function!
>> That would be stupid. But if you return a member of an object for
>> example, it is stupid to return a copy of it (I do not know if this
>> happens
> Two choices have been mentioned. One is
> 1) void function(std::string);
> 2) void function(const std::string&);
>
> In my professional experience, we usually pass a structure by reference when
> it can't fit in a register. We always use (2) with strings that the function
> will not modify
On 2013/08/24 16:33:39, MikeSol wrote:
On 2013/08/24 16:19:27, dak wrote:
> Stupid question: _iff_ you store a _whole_ replacement skyline
anyway,
> shouldn't pad-around just shift the original left/right/up/down
skylines
> left/right/up/down by the given amount (don't ask me what to do
19 matches
Mail list logo
