Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread Mike Solomon
On 27 août 2013, at 09:01, "Keith OHara" wrote: > On Mon, 26 Aug 2013 22:37:17 -0700, Mike Solomon wrote: > >> On 27 août 2013, at 07:18, "Keith OHara" wrote: >> >>> (1) At the moment, the stencil expressions are assembled first, when markup >>> is interpreted, and then stencil_traverser()

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread Keith OHara
On Mon, 26 Aug 2013 22:37:17 -0700, Mike Solomon wrote: On 27 août 2013, at 07:18, "Keith OHara" wrote: (1) At the moment, the stencil expressions are assembled first, when markup is interpreted, and then stencil_traverser() reads the stencil expression to figure the skylines. So long as

PATCHES; countdown for August 27 - 06:00 GMT

2013-08-26 Thread James
Hello *Countdown – August 27th – 06:00 GMT* * * * * * * * * 3508 Enhancement Thomas Morely Push Patch: Some clean up about

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread Mike Solomon
On 27 août 2013, at 07:18, "Keith OHara" wrote: > On Mon, 26 Aug 2013 02:11:28 -0700, Mike Solomon wrote: > >> >> I think that if we can devise a better system, the creation of a new stencil >> primitive is unnecessary. If we agree that we should implement a system >> where stencils are ca

Re: git-cl and pop-up window with text editor - what is it for?

2013-08-26 Thread Frédéric Bron
> I think there is some nominal difference between configuring the > variables VISUAL or EDITOR for your default editor. I found what's the issue looking at git-cl code: def UserEditedLog(starting_text): editor = os.getenv('EDITOR', 'vi') (file_handle, filename) = tempfile.mkstemp() file =

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread Keith OHara
On Mon, 26 Aug 2013 02:11:28 -0700, Mike Solomon wrote: I think that if we can devise a better system, the creation of a new stencil primitive is unnecessary. If we agree that we should implement a system where stencils are carriers of their own skylines, then we should fix this bug using

accidental-placement: default horizon-padding; issue 2141 (issue 13223043)

2013-08-26 Thread janek . lilypond
LGTM :) https://codereview.appspot.com/13223043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Tie Crusade - what to do now

2013-08-26 Thread Janek Warchoł
Hi, sorry for delay... 2013/8/23 Urs Liska : > > "Janek Warchoł" schrieb: >>I've realized that while git log is enough for viewing code, >>commenting on it should be made more convenient - sorry! I've >>uploaded the diff to Rietveld: https://codereview.appspot.com/13051044 >>(i hope that it wil

Re: git-cl and pop-up window with text editor - what is it for?

2013-08-26 Thread David Kastrup
Janek Warchoł writes: > Hi, > > 2013/8/26 Frédéric Bron : >> Hi, >> When I use git-cl, a pop-up window opens with vim. I typed a message >> but couldn't find it anywhere in the issue tracker nor in codereview. >> Also, I noticed that git-cl was continuing in the initial terminal >> while I was ty

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread dak
On 2013/08/26 16:32:24, mike7 wrote: On 26 août 2013, at 13:31, mailto:d...@gnu.org wrote: > _Anything_ is "publicly useable". If that's supposed to be a criterion, > we may not change LilyPond ever again. We try to support programming > interfaces as long as it is feasible. But the way

Re: git-cl and pop-up window with text editor - what is it for?

2013-08-26 Thread Janek Warchoł
Hi, 2013/8/26 Frédéric Bron : > Hi, > When I use git-cl, a pop-up window opens with vim. I typed a message > but couldn't find it anywhere in the issue tracker nor in codereview. > Also, I noticed that git-cl was continuing in the initial terminal > while I was typing the message in the popup wind

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread Mike Solomon
On 26 août 2013, at 13:31, d...@gnu.org wrote: > On 2013/08/26 10:18:04, mike7 wrote: > >> I think Harm is right that, irrespective of documentation, users use > what's >> available. > > If people meddle with internals instead of using provided API functions, > they deserve whatever they get. >

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread Werner LEMBERG
>> Even if it is public: Simply say in the stencil's documentation >> that users must not use it! Additionally, we already have >> `Internal Properties' sections in the `lilypond-internals' >> documentation which the user should ignore. > > Well, I do use 'Internal Properties' in several definit

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread dak
On 2013/08/26 10:18:04, mike7 wrote: I think Harm is right that, irrespective of documentation, users use what's available. If people meddle with internals instead of using provided API functions, they deserve whatever they get. If we're going to add something, we want to be sure that it h

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread Mike Solomon
On 26 août 2013, at 13:13, d...@gnu.org wrote: > On 2013/08/26 10:05:25, mike7 wrote: >> On 26 août 2013, at 13:00, mailto:d...@gnu.org wrote: > >> > That's bullshit since nobody assembles stencil expressions manually. > >> I assemble stencil expressions manually. > > If you meddle with interna

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread dak
On 2013/08/26 10:05:25, mike7 wrote: On 26 août 2013, at 13:00, mailto:d...@gnu.org wrote: > That's bullshit since nobody assembles stencil expressions manually. I assemble stencil expressions manually. If you meddle with internals, that's your own business. > This is done using opaque

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread Thomas Morley
2013/8/26 Werner LEMBERG : > >> What we don't want is for people to start using the stencil >> primitive if we know it's temporary. But if we can somehow prevent >> that (a sort of internal-only primitive) plus add a big TODO >> somewhere, that'd be OK and would save time. > > Even if it is public

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread Mike Solomon
On 26 août 2013, at 13:00, d...@gnu.org wrote: > That's bullshit since nobody assembles stencil expressions manually. I assemble stencil expressions manually. > This is done using opaque functions like ly:stencil-translate. ly:make-stencil is all over the place in the code and is a public func

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread dak
On 2013/08/26 09:42:46, mike7 wrote: In French there's a saying "Temporary solutions have a way of becoming permanent", which is why I'd like to avoid it if possible. Allow me to raise an eyebrow. What we don't want is for people to start using the stencil primitive if we know it's temporary

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread dak
On 2013/08/26 09:11:39, mike7 wrote: On 26 août 2013, at 11:41, mailto:d...@gnu.org wrote: > On 2013/08/26 06:42:38, mike7 wrote: >> On 26 août 2013, at 08:35, mailto:d...@gnu.org wrote: > >> > So why do you talk about that in the first place? > >> Because I'd rather spend more time implementi

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread Werner LEMBERG
> What we don't want is for people to start using the stencil > primitive if we know it's temporary. But if we can somehow prevent > that (a sort of internal-only primitive) plus add a big TODO > somewhere, that'd be OK and would save time. Even if it is public: Simply say in the stencil's docum

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread Mike Solomon
On 26 août 2013, at 12:39, Werner LEMBERG wrote: > >> To summarize: stencil expressions (expr_) currently do not contain >> information for how to place stencils with respect to others. They >> contain information passed to the backends on how to lay out >> stencils. If we adopt either Keith'

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread Werner LEMBERG
> To summarize: stencil expressions (expr_) currently do not contain > information for how to place stencils with respect to others. They > contain information passed to the backends on how to lay out > stencils. If we adopt either Keith's patch or my first one (which I > created before I though

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread Mike Solomon
On 26 août 2013, at 11:41, d...@gnu.org wrote: > On 2013/08/26 06:42:38, mike7 wrote: >> On 26 août 2013, at 08:35, mailto:d...@gnu.org wrote: > >> > So why do you talk about that in the first place? > >> Because I'd rather spend more time implementing a solid system than > less time >> impleme

Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-26 Thread dak
On 2013/08/26 06:42:38, mike7 wrote: On 26 août 2013, at 08:35, mailto:d...@gnu.org wrote: > So why do you talk about that in the first place? Because I'd rather spend more time implementing a solid system than less time implementing a kludge. In the context of this issue, we are curren

Re: git-cl and pop-up window with text editor - what is it for?

2013-08-26 Thread Phil Holmes
- Original Message - From: "Frédéric Bron" To: Sent: Monday, August 26, 2013 7:18 AM Subject: git-cl and pop-up window with text editor - what is it for? Hi, When I use git-cl, a pop-up window opens with vim. I typed a message but couldn't find it anywhere in the issue tracker nor in