Re: Looks for prebroken pieces of dead items in the pure relevant function. (issue 18090043)

2013-11-01 Thread k-ohara5a5a
On 2013/10/30 08:09:53, mike7 wrote: On Oct 30, 2013, at 8:32 AM, mailto:k-ohara5...@oco.net wrote: I do not understand the Todo: comment; nothing should have been suicided at this stage. The original clef is suicided in the handle_prebroken_dependencies function, which is the same

Re: Looks for prebroken pieces of dead items in the pure relevant function. (issue 18090043)

2013-11-01 Thread Mike Solomon
On Nov 1, 2013, at 7:49 AM, k-ohara5...@oco.net wrote: On 2013/10/30 08:09:53, mike7 wrote: On Oct 30, 2013, at 8:32 AM, mailto:k-ohara5...@oco.net wrote: I do not understand the Todo: comment; nothing should have been suicided at this stage. The original clef is suicided in the

Re: Looks for prebroken pieces of dead items in the pure relevant function. (issue 18090043)

2013-11-01 Thread lemzwerg
https://codereview.appspot.com/18090043/diff/60001/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): https://codereview.appspot.com/18090043/diff/60001/lily/axis-group-interface.cc#newcode507 lily/axis-group-interface.cc:507: should probably not check for suidided items or

Re: Issue 3641: Keep only one Axis_group_engraver active (issue 20500043)

2013-11-01 Thread k-ohara5a5a
Looks good. https://codereview.appspot.com/20500043/diff/20001/lily/axis-group-engraver.cc File lily/axis-group-engraver.cc (right): https://codereview.appspot.com/20500043/diff/20001/lily/axis-group-engraver.cc#newcode135 lily/axis-group-engraver.cc:135: the context. */ Probably this comment

Re: Looks for prebroken pieces of dead items in the pure relevant function. (issue 18090043)

2013-11-01 Thread Mike Solomon
On Nov 1, 2013, at 8:31 AM, lemzw...@googlemail.com wrote: https://codereview.appspot.com/18090043/diff/60001/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): https://codereview.appspot.com/18090043/diff/60001/lily/axis-group-interface.cc#newcode507

Define absolute-dynamics as a customizable event-function (issue 20660044)

2013-11-01 Thread dak
https://codereview.appspot.com/20660044/diff/1/ly/dynamic-scripts-init.ly File ly/dynamic-scripts-init.ly (right): https://codereview.appspot.com/20660044/diff/1/ly/dynamic-scripts-init.ly#newcode7 ly/dynamic-scripts-init.ly:7: #(define safe-dynamics ; see midi.scm What's safe about them?

Re: The catastrophe has arrived.

2013-11-01 Thread Joseph Rushton Wakeling
On 25/10/13 13:45, Joseph Rushton Wakeling wrote: Just FYI -- I've had a response from someone at Canonical who has asked me to check a couple of things for them. Will update as/when I have more info. There's now an updated texlive-binaries package in the saucy-proposed repository, which can

Re: Build: Fix compilation with GNU make 4.0 (issue 18700043)

2013-11-01 Thread dak
LGTM https://codereview.appspot.com/18700043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Define absolute-dynamics as a customizable event-function (issue 20660044)

2013-11-01 Thread v . villenave
Slight update; thanks for your patience (I’ve never been good at this but now I’m also quite a bit rusty). https://codereview.appspot.com/20660044/diff/1/ly/dynamic-scripts-init.ly File ly/dynamic-scripts-init.ly (right):

Re: Issue 3560: Completion_heads_engraver with \scaleDurations (issue 14268043)

2013-11-01 Thread dak
On 2013/10/26 06:37:13, Keith wrote: The simplicity is just lovely. Always hard to tell sarcasm from enthusiasm. https://codereview.appspot.com/14268043/diff/9001/lily/completion-note-heads-engraver.cc File lily/completion-note-heads-engraver.cc (right):

Re: Issue 3560: Completion_heads_engraver with \scaleDurations (issue 14268043)

2013-11-01 Thread k-ohara5a5a
On 2013/11/01 20:20:35, dak wrote: On 2013/10/26 06:37:13, Keith wrote: The simplicity is just lovely. Always hard to tell sarcasm from enthusiasm. This patch does simplify things -- especially in comparison to the version that changed behavior based on scale-factors being integral