tracking down a crash

2013-11-20 Thread Keith E OHara
I was getting crashes while testing the page-layout changes on a big set of files, which went away when I set just one input file. It will take a while before I narrow it down to a small example. I can reproduce by taking + running

Re: optimal-page-breaking: signed/unsigned bug; issue 1553 (issue 22750045)

2013-11-20 Thread Keith OHara
On Wed, 20 Nov 2013 00:53:24 -0800, wrote: If min_sys_count would happen to be negative, this loop will never get run at all Exactly that was happening with the example from issue 1553, before the patch. The code above seemed to be trying to ensured that min_sys_count >= 0 but thinking in

Re: Grace notes shouldn't shorten the previous note unless they overlap with it. (issue 29550043)

2013-11-20 Thread James
On 20/11/13 10:58, David Kastrup wrote: James writes: On 20/11/13 08:17, dsch...@gmail.com wrote: Reviewers: , Message: Here's a fix for a minor MIDI bug: grace notes after rests shorten the last note before the rest. Is there a Google tracker item associated with this? Yes, issue 3671.

Re: Grace notes shouldn't shorten the previous note unless they overlap with it. (issue 29550043)

2013-11-20 Thread David Kastrup
James writes: > On 20/11/13 08:17, dsch...@gmail.com wrote: >> Reviewers: , >> >> Message: >> Here's a fix for a minor MIDI bug: grace notes after rests shorten the >> last note before the rest. >> > > Is there a Google tracker item associated with this? Yes, issue 3671. Devon just announced th

Re: Grace notes shouldn't shorten the previous note unless they overlap with it. (issue 29550043)

2013-11-20 Thread James
On 20/11/13 08:17, dsch...@gmail.com wrote: Reviewers: , Message: Here's a fix for a minor MIDI bug: grace notes after rests shorten the last note before the rest. Is there a Google tracker item associated with this? Else the patch won't get tested. James _

Re: optimal-page-breaking: signed/unsigned bug; issue 1553 (issue 22750045)

2013-11-20 Thread dak
https://codereview.appspot.com/22750045/diff/1/lily/optimal-page-breaking.cc File lily/optimal-page-breaking.cc (right): https://codereview.appspot.com/22750045/diff/1/lily/optimal-page-breaking.cc#newcode120 lily/optimal-page-breaking.cc:120: for (vsize sys_count = ideal_sys_count + 1; --sys_co

Grace notes shouldn't shorten the previous note unless they overlap with it. (issue 29550043)

2013-11-20 Thread dschudy
Reviewers: , Message: Here's a fix for a minor MIDI bug: grace notes after rests shorten the last note before the rest. Description: Grace notes shouldn't shorten the previous note unless they overlap with it. Previously a grace note after a rest shortened the last note before the rest. This p