Re: Reduce offsets of \super and \sub (issue 35320043)

LGTM I have one request: this patch makes the situation better, and even if the baseline-skip approach is wrong, it was already used that way so it's not making things worse. I suggest to push this patch, and then work on making this smarter (in the spirit of "best is the enemy of the good"). b

Re: make lilypond compile with FreeType 2.5.1

> I created an issue for you manually, [...] Thanks! Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: make lilypond compile with FreeType 2.5.1

2013/12/1 Werner LEMBERG : > > We need this backwards-compatible patch. > > https://codereview.appspot.com/35580043 > > Please apply to the stable branch also. > > > Werner > > > PS: Somehow I failed to automatically create a lilypond issue, due to > entering an incorrect password. Do we

make lilypond compile with FreeType 2.5.1

We need this backwards-compatible patch. https://codereview.appspot.com/35580043 Please apply to the stable branch also. Werner PS: Somehow I failed to automatically create a lilypond issue, due to entering an incorrect password. Do we need an issue? _

tag for 2.17.96 is missing in git

Please add a tag for the 2.17.96 release! Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Reduce offsets of \super and \sub (issue 35320043)

Do you know if the fonts, in the form LilyPond uses, will report their x-height, and if so how to get the information out of pango? I've just looked up the source code, and the concept of the x-height doesn't seem to be part of Pango. The nearest I can find is the strikethrough position, cf. `p

Re: Reduce offsets of \super and \sub (issue 35320043)

On Sat, 30 Nov 2013 21:21:49 -0800, wrote: Would it be possible to directly compute the height of the current font's `x' glyph as a basis value for raising and lowering? https://codereview.appspot.com/35320043/ I tried to do that for centering dynamics on their hairpins, but could not see a

Re: Reduce offsets of \super and \sub (issue 35320043)

Would it be possible to directly compute the height of the current font's `x' glyph as a basis value for raising and lowering? https://codereview.appspot.com/35320043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman

Re: Reduce offsets of \super and \sub (issue 35320043)

On 2013/12/01 02:09:01, c_sorensen_byu.edu wrote: What about font-size? That should work. I wonder, though, why font-size was not used initially. I'll try it next weekend. I would really be trying to estimate the x-height in a 'normal' font, and since that comes up often, I would make a funct

Re: Reduce offsets of \super and \sub (issue 35320043)

On 11/30/13 5:52 PM, "k-ohara5...@oco.net" wrote: > > Do you know a better quantity on which to scale the raising of >superscripts? What about font-size? Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/l

Re: Reduce offsets of \super and \sub (issue 35320043)

On 2013/11/30 08:54:27, dak wrote: The question is rather what the point of the patch is. I read "This brings chordNames and text superscripts into better agreement with the shifts in user-provided scans." but it would seem to do so only for a particular font size. Well, for a particula

Re: Completion_*_engraver: add means to preserve scale factor; issue 3650 (issue 35370043)

Reviewers: benko.pal, dak, Message: On 2013/11/30 11:08:26, dak wrote: If there is more than one argument (the duration), then the only other argument that seems to make sense to pass is the context: then context properties like measureLength are available anyway. That makes sense. Desc

Re: Communication style on the devel list

2013/11/30 Mike Solomon : > On Nov 30, 2013, at 10:58 PM, Janek Warchoł > wrote: >> 2013/11/30 Mike Solomon : >>> I would argue that the point that Janek brings up above is not a healthy >>> sign for LilyPond development. >>> Several developers, including myself, have lowered their participation >

Communication style on the devel list

On Nov 30, 2013, at 10:58 PM, Janek Warchoł wrote: > 2013/11/30 Mike Solomon : >> I would argue that the point that Janek brings up above is not a healthy >> sign for LilyPond development. >> Several developers, including myself, have lowered their participation >> considerably over the past tw

Re: Be serious about setstrokeadjust in PostScript primitives (issue 8663044)

LGTM as per tracker comment (the results, haven't read the code yet...) Janek https://codereview.appspot.com/8663044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

New Catalan PO file for 'lilypond' (version 2.17.96)

Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'lilypond' has been submitted by the Catalan team of translators. The file is available at: http://translationproject.org/latest/lilypond/ca.po (We can arrange things so tha

XY-extent: more accurate docstring (issue 35440044)

LGTM https://codereview.appspot.com/35440044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: order of layout operations, and \shapeII

Hi, 2013/11/27 Keith E OHara : > There have been a couple bug-reports (3669 3677) coming from users wanting > to access LilyPond's layout decisions, in order to adjust those decisions. > [...] > > The reference point 'ref' is the System, with origin usually the uppermost > point in the System, so

Re: Completion_*_engraver: add means to preserve scale factor; issue 3650 (issue 35370043)

https://codereview.appspot.com/35370043/diff/1/scm/define-context-properties.scm File scm/define-context-properties.scm (right): https://codereview.appspot.com/35370043/diff/1/scm/define-context-properties.scm#newcode231 scm/define-context-properties.scm:231: original duration to be split, and t

Completion_*_engraver: add means to preserve scale factor; issue 3650 (issue 35370043)

LGTM https://codereview.appspot.com/35370043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Reduce offsets of \super and \sub (issue 35320043)

On 2013/11/30 08:45:14, Keith wrote: On Fri, 29 Nov 2013 23:59:52 -0800, wrote: > I'm not sure a multiple of baseline-skip is the best metric (possibly > for limiting height in cramped situations, but not even sure about > that). > > It seems that it would not follow mo

Re: Reduce offsets of \super and \sub (issue 35320043)

On Fri, 29 Nov 2013 23:59:52 -0800, wrote: I'm not sure a multiple of baseline-skip is the best metric (possibly for limiting height in cramped situations, but not even sure about that). It seems that it would not follow most font size changes. In particular not the one caused by \super itsel

Reduce offsets of \super and \sub (issue 35320043)

https://codereview.appspot.com/35320043/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/35320043/diff/1/scm/define-markup-commands.scm#newcode4000 scm/define-markup-commands.scm:4000: (* 0.33 baseline-skip) I'm not sure a multiple