Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-14 Thread David Kastrup
Keith OHara k-ohara5...@oco.net writes: On Fri, 13 Dec 2013 23:05:49 -0800, David Kastrup d...@gnu.org wrote: That does not make sense. If you want call-once behavior, you can just use a callback. At the moment, the decision on whether to preserve the callback pointer in the grob

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-14 Thread Mike Solomon
On Dec 14, 2013, at 9:21 AM, Keith OHara k-ohara5...@oco.net wrote: On Fri, 13 Dec 2013 23:05:49 -0800, David Kastrup d...@gnu.org wrote: That does not make sense. If you want call-once behavior, you can just use a callback. At the moment, the decision on whether to preserve the callback

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-14 Thread Mike Solomon
On Dec 14, 2013, at 9:35 AM, David Kastrup d...@gnu.org wrote: Keith OHara k-ohara5...@oco.net writes: On Fri, 13 Dec 2013 23:05:49 -0800, David Kastrup d...@gnu.org wrote: That does not make sense. If you want call-once behavior, you can just use a callback. At the moment, the

Re: Web: Download: Add introductory text (issue 40510046)

2013-12-14 Thread lilyliska
https://codereview.appspot.com/40510046/diff/40001/Documentation/web/download.itexi File Documentation/web/download.itexi (left): https://codereview.appspot.com/40510046/diff/40001/Documentation/web/download.itexi#oldcode35 Documentation/web/download.itexi:35: @warningTextBased On 2013/12/14

grob-property: if callback is independent of layout, call just once (issue 42190043)

2013-12-14 Thread mtsolo
https://codereview.appspot.com/42190043/diff/1/lily/unpure-pure-container.cc File lily/unpure-pure-container.cc (right): https://codereview.appspot.com/42190043/diff/1/lily/unpure-pure-container.cc#newcode45 lily/unpure-pure-container.cc:45: Looking good. The only thing is - how do we verify

Re: Website questions: Manual-Web

2013-12-14 Thread Urs Liska
Am 14.12.2013 05:01, schrieb Graham Percival: On Fri, Dec 13, 2013 at 03:40:03PM -, Phil Holmes wrote: I _think_ the odd place of web in the manuals hierarchy is down to it being the only part of the documentation that built using make website - it has something of a split personality

Re: Website questions: Manual-Web

2013-12-14 Thread Urs Liska
Am 14.12.2013 04:57, schrieb Graham Percival: On Thu, Dec 12, 2013 at 09:34:28PM +0100, Urs Liska wrote: When I go there I can download the whole website as a PDF. OK, this makes sense. Getting it as one big HTML page also makes sense. [but where can I get it in info format?) We don't provide

Re: grob-property: if callback is independent of layout, call just once (issue 42190043)

2013-12-14 Thread dak
https://codereview.appspot.com/42190043/diff/1/lily/unpure-pure-container.cc File lily/unpure-pure-container.cc (right): https://codereview.appspot.com/42190043/diff/1/lily/unpure-pure-container.cc#newcode45 lily/unpure-pure-container.cc:45: On 2013/12/14 09:47:33, MikeSol wrote: Looking good.

Re: Website questions: Manual-Web

2013-12-14 Thread David Kastrup
Urs Liska u...@openlilylib.org writes: Am 14.12.2013 05:01, schrieb Graham Percival: On Fri, Dec 13, 2013 at 03:40:03PM -, Phil Holmes wrote: I _think_ the odd place of web in the manuals hierarchy is down to it being the only part of the documentation that built using make website - it

Re: grob-property: if callback is independent of layout, call just once (issue 42190043)

2013-12-14 Thread Mike Solomon
On Dec 14, 2013, at 12:00 PM, d...@gnu.org wrote: https://codereview.appspot.com/42190043/diff/1/lily/unpure-pure-container.cc File lily/unpure-pure-container.cc (right): https://codereview.appspot.com/42190043/diff/1/lily/unpure-pure-container.cc#newcode45

Re: Website questions: Manual-Web

2013-12-14 Thread Urs Liska
Am 14.12.2013 11:04, schrieb David Kastrup: t's not totally clear whether it has other functions at the moment that could disrupt the regular operations when removed. Would be removing it (locally), making a full make website (and make doc?) and walking through the whole site manually be

Re: Website questions: Manual-Web

2013-12-14 Thread Phil Holmes
- Original Message - From: David Kastrup d...@gnu.org To: Urs Liska u...@openlilylib.org Cc: Graham Percival gra...@percival-music.ca; Phil Holmes m...@philholmes.net; LilyPond Development Team lilypond-devel@gnu.org Sent: Saturday, December 14, 2013 10:04 AM Subject: Re: Website

Simplifies pure documentation in CG (issue 42070044)

2013-12-14 Thread pkx166h
one nit, patch is in test at the moment before I noticed this. https://codereview.appspot.com/42070044/diff/1/Documentation/contributor/programming-work.itexi File Documentation/contributor/programming-work.itexi (right):

Re: Enable manual-specific styling of documentation; issue 3714 (issue 36480048)

2013-12-14 Thread Carl Peterson
On Sat, Dec 14, 2013 at 1:50 AM, James pkx1...@gmail.com wrote: On 14/12/13 05:57, Carl Peterson wrote: I have updated the patch in Rietvald But not the tracker. So the patch will not get tested. Please remember to either use git-cl or change the tracker to patch-new whenever you make a

Re: Enable manual-specific styling of documentation; issue 3714 (issue 36480048)

2013-12-14 Thread David Kastrup
Carl Peterson carlopeter...@gmail.com writes: On Sat, Dec 14, 2013 at 1:50 AM, James pkx1...@gmail.com wrote: On 14/12/13 05:57, Carl Peterson wrote: I have updated the patch in Rietvald But not the tracker. So the patch will not get tested. Please remember to either use git-cl or change

Re: Enable manual-specific styling of documentation; issue 3714 (issue 36480048)

2013-12-14 Thread Phil Holmes
- Original Message - From: David Kastrup d...@gnu.org To: Carl Peterson carlopeter...@gmail.com Cc: James pkx1...@gmail.com; Lilypond Dev lilypond-devel@gnu.org; Phil Holmes m...@philholmes.net Sent: Saturday, December 14, 2013 2:27 PM Subject: Re: Enable manual-specific styling of

Issue 3720: Built-in templates for SATB vocal scores (issue 41990043)

2013-12-14 Thread lilyfan
LGTM, except one typo. https://codereview.appspot.com/41990043/diff/1/Documentation/learning/templates.itely File Documentation/learning/templates.itely (right): https://codereview.appspot.com/41990043/diff/1/Documentation/learning/templates.itely#newcode53

splitting file movement and whitespace-only changes into separate commits (issue 42330044)

2013-12-14 Thread benko . pal
Reviewers: , Message: continuation of http://codereview.appspot.com/38530043 belonging to http://code.google.com/p/lilypond/issues/detail?id=3705 if requested, I can either update dev/janek/metafont-cleanup or push as a new branch. Description: splitting file movement and whitespace-only

Re: Metafont code cleanup (issue 38530043)

2013-12-14 Thread benko . pal
However, if you don't mind, i'd prefer to leave it as is - i have _already_ spent about 4 hours cleaning up and rebasing commits to make them somewhat ordered for review, and i'm quite tired. I do mind. this is not the sort of thing that can be done in a follow up patch. If you don't

What's the idea with the $papers stack?

2013-12-14 Thread David Kastrup
The only place where it is pushed is when creating a _new_ book, and then it is cleared out immediately before it. What kind of pushing is that supposed to be? What does that even mean? A paper block in a book definition manipulated the top book entry, except when looking at a book identifier.

Re: Issue 3720: Built-in templates for SATB vocal scores (issue 41990043)

2013-12-14 Thread tdanielsmusic
Reviewers: Jean-Charles, Message: On 2013/12/14 16:15:14, Jean-Charles wrote: LGTM, except one typo. https://codereview.appspot.com/41990043/diff/1/Documentation/learning/templates.itely File Documentation/learning/templates.itely (right):

Re: What's the idea with the $papers stack?

2013-12-14 Thread Han-Wen Nienhuys
On Sat, Dec 14, 2013 at 6:32 PM, David Kastrup d...@gnu.org wrote: The only place where it is pushed is when creating a _new_ book, and then it is cleared out immediately before it. What kind of pushing is that supposed to be? What does that even mean? A paper block in a book definition

Re: What's the idea with the $papers stack?

2013-12-14 Thread David Kastrup
Han-Wen Nienhuys hanw...@gmail.com writes: On Sat, Dec 14, 2013 at 6:32 PM, David Kastrup d...@gnu.org wrote: The only place where it is pushed is when creating a _new_ book, and then it is cleared out immediately before it. What kind of pushing is that supposed to be? What does that even

Re: Issue 3720: Built-in templates for SATB vocal scores (issue 41990043)

2013-12-14 Thread dschudy
This interface is unlike any other in Lilypond, in ways that make it less flexible and may surprise users: * It has two separate files that need to be included in the right places. * It requires the user to use certain specific variable names. * The second include file doesn't just add

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-14 Thread Keith OHara
On Sat, 14 Dec 2013 00:49:43 -0800, Mike Solomon m...@mikesolomon.org wrote: On Dec 14, 2013, at 9:35 AM, David Kastrup d...@gnu.org wrote: Most of the contortions seem focused about when or when not and how to pass begin/end columns. It would seem to make sense to turn them into dynamic

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-14 Thread Keith OHara
On Sat, 14 Dec 2013 14:58:52 -0800, Keith OHara k-ohara5...@oco.net wrote: Several considered line-breaks might have the same 'start' and 'end' around the hairpin, but the upper-level axis-group structure caches results for each start/end pair so just one skyline is generated for each

Re: Issue 3720: Built-in templates for SATB vocal scores (issue 41990043)

2013-12-14 Thread k-ohara5a5a
On 2013/12/14 22:32:06, Devon Schudy wrote: This interface is unlike any other in Lilypond, This was intended not as an interface to a built-in bulletproof engine, but rather a template that users can adopt and change. Maybe calling it a 'built-in' template, and its attempt to be as general

Re: splitting file movement and whitespace-only changes into separate commits (issue 42330044)

2013-12-14 Thread lemzwerg
if requested, I can either update dev/janek/metafont-cleanup or push as a new branch. Please do so! https://codereview.appspot.com/42330044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: splitting file movement and whitespace-only changes into separate commits (issue 42330044)

2013-12-14 Thread lemzwerg
https://codereview.appspot.com/42330044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Allow score and book identifiers at top level, and score identifiers in book(part)s (issue 39320044)

2013-12-14 Thread lemzwerg
LGTM. https://codereview.appspot.com/39320044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Web: Download: Add introductory text (issue 40510046)

2013-12-14 Thread Graham Percival
On Sat, Dec 14, 2013 at 09:46:54AM +, lilyli...@googlemail.com wrote: On 2013/12/14 03:51:33, Graham Percival wrote: Umm, isn't the whole point of this to be a warning? Why are you removing the warning CSS tag? It's the whole point of this patch to raise this information to the

Re: anyone notice speed of 2.17.95 on Windows ?

2013-12-14 Thread Mike Solomon
On Dec 15, 2013, at 12:58 AM, Keith OHara k-ohara5...@oco.net wrote: On Sat, 14 Dec 2013 00:49:43 -0800, Mike Solomon m...@mikesolomon.org wrote: On Dec 14, 2013, at 9:35 AM, David Kastrup d...@gnu.org wrote: Most of the contortions seem focused about when or when not and how to pass