PATCHES: Countdown for February 17th - 06:00 GMT

2014-02-14 Thread James
Hello, 3831 http://code.google.com/p/lilypond/issues/detail?id=3831q=label%3APatch-countdown%20OR%20label%3APatch-waiting%20OR%20label%3APatch-review%20OR%20label%3APatch-new%20OR%20label%3APatch-pushsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified

Doc: NR Clarify repeats w\ partials and barchecks (issue 61530043)

2014-02-14 Thread graham
https://codereview.appspot.com/61530043/diff/1/Documentation/notation/repeats.itely File Documentation/notation/repeats.itely (right): https://codereview.appspot.com/61530043/diff/1/Documentation/notation/repeats.itely#newcode167 Documentation/notation/repeats.itely:167: If a repeat, that has

Re: Doc: Point-and-Click has wrong default value and ref to SVG output needs adding (issue 61630045)

2014-02-14 Thread graham
LGTM https://codereview.appspot.com/61630045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Added Aurelien's 100-min Ring Cycle for children (issue 61640044)

2014-02-14 Thread graham
LGTM https://codereview.appspot.com/61640044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Authors.itexi - Updated Current Developers list (issue 61360043)

2014-02-14 Thread graham
LGTM https://codereview.appspot.com/61360043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: NR: 1.4.1 Replaced deprecated snippet w\ @lilypond (issue 60840048)

2014-02-14 Thread graham
LGTM https://codereview.appspot.com/60840048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Changes.tely updated - 2.19.x before Feb 4th 2014 (issue 60490050)

2014-02-14 Thread graham
LGTM https://codereview.appspot.com/60490050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Point-and-Click has wrong default value and ref to SVG output needs adding (issue 61630045)

2014-02-14 Thread dschudy
https://codereview.appspot.com/61630045/diff/20001/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/61630045/diff/20001/Documentation/usage/running.itely#newcode409 Documentation/usage/running.itely:409: SVG output should be

Re: Doc: Point-and-Click has wrong default value and ref to SVG output needs adding (issue 61630045)

2014-02-14 Thread dak
https://codereview.appspot.com/61630045/diff/20001/Documentation/usage/running.itely File Documentation/usage/running.itely (left): https://codereview.appspot.com/61630045/diff/20001/Documentation/usage/running.itely#oldcode670 Documentation/usage/running.itely:670: relevant when @code{PDF} is

Report an error instead of crashing when iteration encounters non-music. (issue 63890043)

2014-02-14 Thread dak
Shouldn't most of those get caught earlier by making use of the types defined in scm/define-music-properties.scm ? If we are missing proper typechecks in make-music et al, maybe we should fix that there? https://codereview.appspot.com/63890043/ ___