Re: PATCHES: Countdown for June 26th 2014

2014-06-23 Thread Janek Warchoł
2014-06-23 8:50 GMT+02:00 James : > Feel free to change it. I make a minimum cut off point of 20 - 24 hours > since a patch was 'tested' before I move them on - I have to cut-off > somewhere - this was I think 19 hours. So for me it's no big deal. ok, changed. Thanks! Janek _

Re: Extending: 2.3.2 - Music Function usage (issue 108110043 by pkx1...@gmail.com)

2014-06-23 Thread dak
https://codereview.appspot.com/108110043/diff/20001/Documentation/extending/programming-interface.itely File Documentation/extending/programming-interface.itely (right): https://codereview.appspot.com/108110043/diff/20001/Documentation/extending/programming-interface.itely#newcode337 Documentati

Issue 3958: Give examples of \applyContext usage. (issue 110060045 by markpole...@gmail.com)

2014-06-23 Thread janek . lilypond
LGTM - this is helpful, thanks! https://codereview.appspot.com/110060045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Question about defined music functions

2014-06-23 Thread James
Hello, Can I assume (dangerous ground I know) that if I look in ly/music-functions-init.ly and see an entry that has the form someString = #(define-music-function ... That this is always a command in the form \someString That a user can directly in a .ly file (if you see what I mean/). I

Re: Question about defined music functions

2014-06-23 Thread David Kastrup
James writes: > Can I assume (dangerous ground I know) that if I look in > ly/music-functions-init.ly and see an entry that has the form > > someString = > #(define-music-function ... > > That this is always a command in the form > > \someString > > That a user can directly in a .ly file (if you

astyle 2.02

2014-06-23 Thread Janek Warchoł
Hi, our fixcc scripts says that it requires astyle in version exactly 2.02. However, the latest version is 2.04 and i didn't manage to find packaged 2.02 version - does anyone know where i could get it? Or maye we could use 2.04 after all? I believe that having a tool like fixcc is absolutely a

Re: astyle 2.02

2014-06-23 Thread Federico Bruni
I can see 2.01 in debian wheezy: https://packages.debian.org/search?keywords=astyle Il 23/giu/2014 22:52 "Janek Warchoł" ha scritto: > Hi, > > our fixcc scripts says that it requires astyle in version exactly > 2.02. However, the latest version is 2.04 and i didn't manage to find > packaged 2.0

Re: astyle 2.02

2014-06-23 Thread Devon Schudy
Janek Warchoł wrote: > our fixcc scripts says that it requires astyle in version exactly > 2.02. However, the latest version is 2.04 and i didn't manage to find > packaged 2.02 version - does anyone know where i could get it? Or > maye we could use 2.04 after all? Sourceforge has all the old ver

Re: BreathingSigns and automatic beams

2014-06-23 Thread Jay Anderson
On Wed, Mar 6, 2013 at 6:00 PM, Thomas Morley wrote: > Well, nowadays we have the 'collision-interfaces-property but adding > breathing-sign-interface to it seems to have no effect. > > \version "2.17.12" > > respectBS = { > \override Beam #'collision-interfaces = > #'(beam-interface >

Re: BreathingSigns and automatic beams

2014-06-23 Thread David Kastrup
Jay Anderson writes: > On Wed, Mar 6, 2013 at 6:00 PM, Thomas Morley > wrote: >> Well, nowadays we have the 'collision-interfaces-property but adding >> breathing-sign-interface to it seems to have no effect. >> >> \version "2.17.12" >> >> respectBS = { >> \override Beam #'collision-interfaces

Re: astyle 2.02

2014-06-23 Thread Graham Percival
On Mon, Jun 23, 2014 at 09:28:24PM -0400, Devon Schudy wrote: > The cases where 2.04 does worse than 2.02 are minor; I don't think > they're enough that fixcc.py should refuse to use it. Thanks for the analysis of astyle 2.02 vs. 2.04. I support switching to 2.04. However, fixcc.py should reject

Re: Issue 3254: align unassociated lyrics using NoteColumn extent. (issue 108110044 by janek.lilyp...@gmail.com)

2014-06-23 Thread k-ohara5a5a
Looks very good. I looked for unwanted side-effects, and found no problems. The old code did a very bad thing, ignoring the "self-alignment-X/Y" request if the parent was a paper-column. https://codereview.appspot.com/108110044/diff/80001/lily/paper-column.cc File lily/paper-column.cc (right):

use X-parents to align MMRNumbers, MMRTexts and PercentRepeatCounters (issue 108110045 by janek.lilyp...@gmail.com)

2014-06-23 Thread k-ohara5a5a
looks good, and logical. https://codereview.appspot.com/108110045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 3958: Give examples of \applyContext usage. (issue 110060045 by markpole...@gmail.com)

2014-06-23 Thread k-ohara5a5a
Looks fine as-is. You might look at it again, and see if you like the idea of shortening it so more people read it. https://codereview.appspot.com/110060045/diff/1/Documentation/extending/programming-interface.itely File Documentation/extending/programming-interface.itely (right): https://coder

Re: BreathingSigns and automatic beams

2014-06-23 Thread Jay Anderson
On Mon, Jun 23, 2014 at 10:24 PM, David Kastrup wrote: > You don't say which frustration. You apparently want to have automatic > beams across breath marks. To me, that does not make a lot of sense. Sorry, I took out too much context from the original message. It's pretty common in horn music (

Re: use X-parents to align MMRNumbers, MMRTexts and PercentRepeatCounters (issue 108110045 by janek.lilyp...@gmail.com)

2014-06-23 Thread janek . lilypond
Reviewers: Keith, Message: On 2014/06/24 05:42:36, Keith wrote: looks good, and logical. Yay! Thanks :) Description: use X-parents to align MMRNumbers, MMRTexts and PercentRepeatCounters It makes more sense to use X-parents than Y-parents for horizontal alignment. To be able to do this, we h

Re: Issue 3254: align unassociated lyrics using NoteColumn extent. (issue 108110044 by janek.lilyp...@gmail.com)

2014-06-23 Thread janek . lilypond
Thanks for review! https://codereview.appspot.com/108110044/diff/80001/lily/paper-column.cc File lily/paper-column.cc (right): https://codereview.appspot.com/108110044/diff/80001/lily/paper-column.cc#newcode226 lily/paper-column.cc:226: Paper_column::get_generic_interface_extent (Grob *column,