Re: Simplify the NullVoice context (issue 117050043 by k-ohara5...@oco.net)

2014-07-27 Thread dak
On 2014/07/27 21:31:52, Keith wrote: On 2014/07/27 11:50:17, dak wrote: > https://codereview.appspot.com/117050043/diff/40001/ly/engraver-init.ly#newcode787 > ly/engraver-init.ly:787: \override NoteHead.meta.interfaces = #(delete > 'rhythmic-head-interface > Ugh. This looks incredibly ug

Re: DOC: minor revisions to Easier Editing (issue 118350043 by colinpkcampb...@gmail.com)

2014-07-27 Thread ColinPKCampbell
On 2014/07/27 08:22:47, uliska wrote: Apart from my comment LGTM Good feedback, Urs, and thanks. Changed patchset uploaded. https://codereview.appspot.com/118350043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailm

Re: Set X-parent of TextScript to NoteColumn instead of PaperColumn (issue 106640043 by janek.lilyp...@gmail.com)

2014-07-27 Thread Keith OHara
On Sun, 27 Jul 2014 09:44:22 -0700, wrote: On 2014/07/26 21:36:12, Keith wrote: On 2014/07/26 06:49:41, janek wrote: > > Setting TextScript.cross-staff property to #f is required to ensure > that there are no collisions between TextScripts and cross-staff notes: The concept of a

Issue 4024: Clarify break-align symbols and space-alist args in IR. (issue 114160044 by markpole...@gmail.com)

2014-07-27 Thread markpolesky
Reviewers: , Message: Since no one reviewed this patch, I'm setting its status back to review. I'll push it next countdown if I all remains quiet. Thanks, Mark Description: Things take so long to understand when they're not documented! Issue 4024 on the tracker: http://code.google.com/p/lilyp

Re: Simplify the NullVoice context (issue 117050043 by k-ohara5...@oco.net)

2014-07-27 Thread k-ohara5a5a
On 2014/07/27 11:50:17, dak wrote: https://codereview.appspot.com/117050043/diff/40001/ly/engraver-init.ly#newcode787 ly/engraver-init.ly:787: \override NoteHead.meta.interfaces = #(delete 'rhythmic-head-interface Ugh. This looks incredibly ugly. I guess I lack a sense of aesthetics for Sc

Re: Simplify the NullVoice context (issue 117050043 by k-ohara5...@oco.net)

2014-07-27 Thread k-ohara5a5a
Reviewers: janek, dak, Message: On 2014/07/27 11:25:41, janek wrote: https://codereview.appspot.com/117050043/diff/40001/input/regression/lyric-combine-nullvoice.ly#newcode15 input/regression/lyric-combine-nullvoice.ly:15: >> } This regtest is nice, but as far as i can see it doesn't check whet

Re: Set X-parent of TextScript to NoteColumn instead of PaperColumn (issue 106640043 by janek.lilyp...@gmail.com)

2014-07-27 Thread janek . lilypond
On 2014/07/26 21:36:12, Keith wrote: On 2014/07/26 06:49:41, janek wrote: > > Setting TextScript.cross-staff property to #f is required to ensure > that there are no collisions between TextScripts and cross-staff notes: > (see also beam-cross-staff-auto-knee.ly) > > As far as

Re: GUB build

2014-07-27 Thread David Kastrup
Janek Warchoł writes: > 2014-07-27 13:49 GMT+02:00 Phil Holmes : >> Folks, >> >> Most people realise that me general schedule is to make and upload a GUB >> build every two weeks - normally on a Sunday afternoon. I'm postponing >> this week's until next Sunday - I'm away all afternoon and evenin

Re: GUB build

2014-07-27 Thread Janek Warchoł
ok. Anyway, thanks a lot for your continuous work! It's good to have you care about releases :) Janek 2014-07-27 13:49 GMT+02:00 Phil Holmes : > Folks, > > Most people realise that me general schedule is to make and upload a GUB > build every two weeks - normally on a Sunday afternoon. I'm pos

Re: Simplify the NullVoice context (issue 117050043 by k-ohara5...@oco.net)

2014-07-27 Thread dak
https://codereview.appspot.com/117050043/diff/40001/ly/engraver-init.ly File ly/engraver-init.ly (right): https://codereview.appspot.com/117050043/diff/40001/ly/engraver-init.ly#newcode787 ly/engraver-init.ly:787: \override NoteHead.meta.interfaces = #(delete 'rhythmic-head-interface On 2014/07/

GUB build

2014-07-27 Thread Phil Holmes
Folks, Most people realise that me general schedule is to make and upload a GUB build every two weeks - normally on a Sunday afternoon. I'm postponing this week's until next Sunday - I'm away all afternoon and evening so starting them is a problem, and I'm nearly up to my broadband limit for

thank you! (was: PATCHES: Countdown for July 30th 2014)

2014-07-27 Thread Janek Warchoł
Hi all, let me use this opportunity to thank James for his work on shepherding and testing LilyPond patches. This is very helpful, and appreciated! cheers, Janek 2014-07-27 6:14 GMT+02:00 James : > Hello, > > Here is the current patch countdown list. The next countdown will be on > July 30th. >

Re: AccidentalCautionary in NullVoice

2014-07-27 Thread Janek Warchoł
@Dan: FYI, Keith has put up a patch that simplifies and improves NullVoice context - it should fix all the problems that we know of. It is currently being discussed at https://codereview.appspot.com/117050043 best, Janek ___ lilypond-devel mailing list

Re: Simplify the NullVoice context (issue 117050043 by k-ohara5...@oco.net)

2014-07-27 Thread janek . lilypond
Hi Keith, your changes look good overall, but i think that NullVoice could be simplified even further - see below. thanks for your work! https://codereview.appspot.com/117050043/diff/40001/input/regression/lyric-combine-nullvoice.ly File input/regression/lyric-combine-nullvoice.ly (right): ht

Remove warning when there are no noteheads to attach lyrics to. (issue 120200043 by janek.lilyp...@gmail.com)

2014-07-27 Thread janek . lilypond
Reviewers: , Message: Pushed as commit 476687b992c1c0d551b0d425e5ece78c39cfc3ef Author: Janek Warchoł Date: Sat Jul 26 09:00:39 2014 +0200 Remove warning when there are no noteheads to attach lyrics to. The warning was added to address issue 248, but it is now moot after issue 3

Re: Have git SHA1 ID's changed in the last 5 years?

2014-07-27 Thread David Kastrup
Mark Polesky writes: > Ha! My old repo stops a day before that change. No wonder I abandoned > it... Okay, when I have some time I'll start updating the small handful of > mislabeled committishes. It's not that many. Here are the tags that apparently have a history ending in the fred startin

Re: Have git SHA1 ID's changed in the last 5 years?

2014-07-27 Thread David Kastrup
Mark Polesky writes: > David Kastrup wrote: >> but in my repository no commits authored by fred, > > Really? Can you try > a281aedda8d5ea550f8b851822315cf154acee52 ? commit a281aedda8d5ea550f8b851822315cf154acee52 Author: fred Date: Wed Mar 27 02:56:08 2002 + lilypond-1.5.47 But if

Re: Have git SHA1 ID's changed in the last 5 years?

2014-07-27 Thread Mark Polesky
Ha! My old repo stops a day before that change. No wonder I abandoned it... Okay, when I have some time I'll start updating the small handful of mislabeled committishes. It's not that many. Thanks, Mark ___ lilypond-devel mailing list lilypond-devel@

Re: Have git SHA1 ID's changed in the last 5 years?

2014-07-27 Thread Mark Polesky
David Kastrup wrote: > but in my repository no commits authored by fred, Really? Can you try a281aedda8d5ea550f8b851822315cf154acee52 ? fred even appears as an author on the savannah repo: http://git.sv.gnu.org/gitweb/?p=lilypond.git;a=shortlog;h=a281aed although strangely it looks like there are

Re: DOC: minor revisions to Easier Editing (issue 118350043 by colinpkcampb...@gmail.com)

2014-07-27 Thread lilyliska
Apart from my comment LGTM https://codereview.appspot.com/118350043/diff/1/Documentation/web/introduction.itexi File Documentation/web/introduction.itexi (right): https://codereview.appspot.com/118350043/diff/1/Documentation/web/introduction.itexi#newcode1221 Documentation/web/introduction.itex

Re: Have git SHA1 ID's changed in the last 5 years?

2014-07-27 Thread David Kastrup
Benkő Pál writes: > 2014-07-27 9:54 GMT+02:00 David Kastrup : >> Benkő Pál writes: >> Okay, so I'm not crazy. I happened to keep an old repo from four years ago, and as you can see from the attached image, the two histories are not the same, and neither are the commit SHA1 I

Re: Have git SHA1 ID's changed in the last 5 years?

2014-07-27 Thread Benkő Pál
2014-07-27 9:54 GMT+02:00 David Kastrup : > Benkő Pál writes: > >>> Okay, so I'm not crazy. I happened to keep an old repo from >>> four years ago, and as you can see from the attached image, >>> the two histories are not the same, and neither are the >>> commit SHA1 IDs... How did this happen,

Re: Have git SHA1 ID's changed in the last 5 years?

2014-07-27 Thread David Kastrup
Benkő Pál writes: >> Okay, so I'm not crazy. I happened to keep an old repo from >> four years ago, and as you can see from the attached image, >> the two histories are not the same, and neither are the >> commit SHA1 IDs... How did this happen, and could it happen >> again? > > could you track

Re: Have git SHA1 ID's changed in the last 5 years?

2014-07-27 Thread Benkő Pál
> Okay, so I'm not crazy. I happened to keep an old repo from > four years ago, and as you can see from the attached image, > the two histories are not the same, and neither are the > commit SHA1 IDs... How did this happen, and could it happen > again? could you track down the first divergence a