Re: Simplify the NullVoice context (issue 117050043 by k-ohara5...@oco.net)

2014-09-08 Thread dak
"Keith OHara" writes: On Sun, 07 Sep 2014 01:21:58 -0700, wrote: But messing up the basic grob definition by fetching internals and meddling through them locally: no. Well, you say "messing up the basic grob definition" I say "reading the basic definition, and making a local modified cop

Re: Simplify the NullVoice context (issue 117050043 by k-ohara5...@oco.net)

2014-09-08 Thread Dan Eble
On Sep 8, 2014, at 03:54 , d...@gnu.org wrote: > "Keith OHara" writes: > > I'm trying to let people move NullVoice to Staff without > reintroducing the known issue of the cancellation accidentals in >> \new Staff << >>\new NullVoice {cis dis es fis} >>\new Voice {r4 c d e } >> > > Agai

Re: Limit looping in Grob::common_refpoint (issue 4079) (issue 134600043 by e...@ticalc.org)

2014-09-08 Thread eble
Set saner limits, fixed indentation and copyright notice. I have disregarded Mike Solomon's suggestion to issue a programming error message because David is right about the right places for graceful error handling. The value of the Strict_counter comes from being simple enough that one can under

Re: Check for Note_column interface before using grob. (issue 141190043 by e...@ticalc.org)

2014-09-08 Thread eble
Indentation is fixed. https://codereview.appspot.com/141190043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Simplify the NullVoice context (issue 117050043 by k-ohara5...@oco.net)

2014-09-08 Thread dak
On 2014/09/08 23:28:31, dan_faithful.be wrote: On Sep 8, 2014, at 03:54 , mailto:d...@gnu.org wrote: > Again: I would strongly suggest that you backpedal and consider the > question "what was my first approach which did not work, for > reasons?". > > And then we see what it would take to addre

Re: Simplify the NullVoice context (issue 117050043 by k-ohara5...@oco.net)

2014-09-08 Thread Keith OHara
On Mon, 08 Sep 2014 16:28:24 -0700, Dan Eble wrote: How about placing the voices inside a VoiceGroup context, moving the Accidental_engraver there, and leaving the NullVoice outside, like in my recent partcombine experiments? Usually, accidentals are reported up the context hierarchy. We c