On Dec 10, 2014, at 23:52 , Dan Eble wrote:
>
> Here’s a trick: routing music to different voices without using the
> Part_combine_iterator. Instead, it uses the same infrastructure as for staff
> switching.
updated to generate per-part \change commands from the split list generated by
\part
On 2015/01/02 14:36:34, dak wrote:
The case I was worried about was (line_pos.begin () < it - 1)
This expression is undefined if it == line_pos.begin () since
line_pos.begin ()
- 1 is undefined, being before the start of the array.
Two lines up there is assert (line_pos.begin () < it), so it
On 2015/01/02 14:16:54, Dan Eble wrote:
On 2015/01/02 08:56:03, dak wrote:
> In particular, the compiler is allowed to make
> line_pos.begin () < whatever the same as line_pos.begin () !=
whatever.
* std::vector elements must be contiguous after C++03
(http://en.cppreference.com/w/cpp/containe
just one nitpick, otherwise LGTM.
https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely#newcode2559
Documentation/notation/input.itely
On 2015/01/02 08:56:03, dak wrote:
In particular, the compiler is allowed to make
line_pos.begin () < whatever the same as line_pos.begin () !=
whatever.
* std::vector elements must be contiguous after C++03
(http://en.cppreference.com/w/cpp/container/vector)
* it[n] is convertible to a referen
One nitpick, otherwise LGTM
https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely#newcode2541
Documentation/notation/input.itely:2541:
On 2015/01/02 08:56:03, dak wrote:
On 2015/01/02 07:21:19, benko.pal wrote:
> On 2015/01/01 23:08:56, Dan Eble wrote:
> > On 2015/01/01 22:57:31, benko.pal wrote:
> > >
https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc
> > > File lily/breathing-sign.cc (right):
> > >
> > >
There isn't an @@file: the description is copied below. I'm assuming that the
LSR export routine knows that it has to escape @ and { and so replaces them
with @@ and @{. I know it also replaces with @code{, but am not sure
whether would work, since it's not valid HTML: it would also not look
2015-01-02 10:25 GMT+01:00 Phil Holmes :
> Doc: correct texinfo formatting in snippet
>>
>> @@file@{…@} -> @file{…}
>>
>> This fix will be undone by the next LSR import.
>> You should ask someone with write privilege to fix it on the LSR server:
>> http://lsr.di.unimi.it/LSR/Item?id=523
>>
>
- Original Message -
From: "Federico Bruni"
To: "Devel" ; "Jean-Charles Malahieude"
Sent: Friday, January 02, 2015 8:14 AM
Subject: LSR item 523, fix typo
Jean-Charles, regarding this commit:
commit c86ce585e9451663b80beb5d03ee28a00b07e8e8
Author: Jean-Charles Malahieude
Date: S
On 2015/01/02 00:22:11, J_lowe wrote:
On 2015/01/02 00:09:19, Trevor Daniels wrote:
>
https://codereview.appspot.com/193870043/diff/1/Documentation/included/compile.itexi
> File Documentation/included/compile.itexi (right):
>
>
https://codereview.appspot.com/193870043/diff/1/Documentation/in
On 2015/01/02 07:21:19, benko.pal wrote:
On 2015/01/01 23:08:56, Dan Eble wrote:
> On 2015/01/01 22:57:31, benko.pal wrote:
> >
https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc
> > File lily/breathing-sign.cc (right):
> >
> >
>
https://codereview.appspot.com/189420043/di
Jean-Charles, regarding this commit:
commit c86ce585e9451663b80beb5d03ee28a00b07e8e8
Author: Jean-Charles Malahieude
Date: Sun Dec 28 16:50:40 2014 +0100
Doc: correct texinfo formatting in snippet
@@file@{…@} -> @file{…}
This fix will be undone by the next LSR import.
You should ask
13 matches
Mail list logo
