Re: Issue 3799: New satb.ly built-in template and template framework (issue 225860043 by tdanielsmu...@googlemail.com)

2015-04-07 Thread nine . fierce . ballads
To support TTBB, would you generalize this template further, or would you create something new? How about factoring out the parts that are used within a \score into their own file so that they can be included many times in a multi-score book? How about using the part combiner? (That reminds me

Re: Replace C++ (in)equality checks with proper SCM syntax (issue 226840043 by v.villen...@gmail.com)

2015-04-07 Thread nine . fierce . ballads
x == SCM_EOL --->ly_is_eol (x) But... Guile has scm_is_null which is a macro expanding to the direct comparison with SCM_EOL if the type debugging is switched off, and to something that works and compiles if it is on. [David K. in http://lists.gnu.org/archive/html/li

Re: make pretty-print available in ly files (issue 222810043 by david.nales...@gmail.com)

2015-04-07 Thread thomasmorley65
https://codereview.appspot.com/222810043/diff/1/ly/init.ly File ly/init.ly (right): https://codereview.appspot.com/222810043/diff/1/ly/init.ly#newcode38 ly/init.ly:38: #(use-modules (ice-9 pretty-print)) On 2015/04/07 17:43:07, david.nalesnik wrote: On 2015/04/07 16:13:44, dak wrote: > Uh, wher

Re: Staff ends before \clef, \time and \key

2015-04-07 Thread Reinhold Kainhofer
Dear David, Thank you for the hint with break-align-symbols, which works much better than the suggestion on the user list to simply use "s8" to prolong the staff (but introduces other issues, like a \mark "seque Terzetto" stretching the staff lines after the final time change)... So, basicall

Re: Add sans-serif and monospace fonts (issue 224800043 by truer...@gmail.com)

2015-04-07 Thread lemzwerg
Wouldn't it make more sense to have one setting for all of the included fonts? Are there really circumstances where we can expect all of these to be different? Probably not. I think that the patch is a proof of concept, and we should comment on it. https://codereview.appspot.com/224800043/ __

Re: make pretty-print available in ly files (issue 222810043 by david.nales...@gmail.com)

2015-04-07 Thread david . nalesnik
https://codereview.appspot.com/222810043/diff/1/ly/init.ly File ly/init.ly (right): https://codereview.appspot.com/222810043/diff/1/ly/init.ly#newcode38 ly/init.ly:38: #(use-modules (ice-9 pretty-print)) On 2015/04/07 16:13:44, dak wrote: Uh, where is the point? Why wouldn't a user include a m

Re: PATCHES: Countdown for April 6th 2015

2015-04-07 Thread David Kastrup
David Kastrup writes: > James Lowe writes: > >>> If we freeze patches only on countdown state and nothing else I hope not >>> to curb the holiday rush of activity too much. >> >> What I can do, so as to not put of people submitting patches in the >> meantime, is to continue test/review/countdown

Re: Staff ends before \clef, \time and \key

2015-04-07 Thread David Kastrup
Reinhold Kainhofer writes: > Hi all, > It's been quite a while since I last used LilyPond, and I finally > decided to wrap up the last, huge edition I was working on for quite a > while. > > Here is the first issue I'm running into: > If I end a piece with a \bar "||" and after that only want to

Re: make pretty-print available in ly files (issue 222810043 by david.nales...@gmail.com)

2015-04-07 Thread dak
https://codereview.appspot.com/222810043/diff/1/ly/init.ly File ly/init.ly (right): https://codereview.appspot.com/222810043/diff/1/ly/init.ly#newcode38 ly/init.ly:38: #(use-modules (ice-9 pretty-print)) Uh, where is the point? Why wouldn't a user include a module he wants himself? Other modul

Re: Add sans-serif and monospace fonts (issue 224800043 by truer...@gmail.com)

2015-04-07 Thread dak
https://codereview.appspot.com/224800043/diff/1/scripts/auxiliar/pfx2ttf-mono.fontforge File scripts/auxiliar/pfx2ttf-mono.fontforge (right): https://codereview.appspot.com/224800043/diff/1/scripts/auxiliar/pfx2ttf-mono.fontforge#newcode17 scripts/auxiliar/pfx2ttf-mono.fontforge:17: # Monospace

Re: Add sans-serif and monospace fonts (issue 224800043 by truer...@gmail.com)

2015-04-07 Thread dak
https://codereview.appspot.com/224800043/diff/1/config.make.in File config.make.in (right): https://codereview.appspot.com/224800043/diff/1/config.make.in#newcode97 config.make.in:97: COUR_DIR = @COUR_DIR@ It seems a bit excessive to point separately to the font files for all of New Century Scho

Re: PATCHES: Countdown for April 6th 2015

2015-04-07 Thread David Kastrup
James Lowe writes: >> If we freeze patches only on countdown state and nothing else I hope not >> to curb the holiday rush of activity too much. > > What I can do, so as to not put of people submitting patches in the > meantime, is to continue test/review/countdown and just not go through > to th

Replace C++ (in)equality checks with proper SCM syntax (issue 226840043 by v.villen...@gmail.com)

2015-04-07 Thread v . villenave
Reviewers: , Message: Greetings everybody, I realize that this is a rather large patch; at home I had divided it into smaller, more manageable commits such as 0001-C-Scheme-consistency-use-ly_is_eol.patch 0002-C-Scheme-consistency-use-scm_is_false.patch 0003-C-Scheme-consistency-use-to_boolean.pa

Issue 3799: New satb.ly built-in template and template framework (issue 225860043 by tdanielsmu...@googlemail.com)

2015-04-07 Thread tdanielsmusic
Reviewers: , Message: This patch is posted for comment and improvement rather than a candidate for immediate inclusion in the code base. Some caveats/issues/questions: \includes are used for testing; later, perhaps after settling on the file names, these may not be necessary. Indenting is prob