Re: Issue 4205: Improve part combiner's rest analysis (issue 174610043 by nine.fierce.ball...@gmail.com)

2015-05-16 Thread nine . fierce . ballads
On 2015/05/13 04:55:23, Keith wrote: I noticed the same bug with rests and skips. I'm using the patch below with success on my own music, but I haven't tried it on the regtest suite yet. Thanks. You've given me a push, but I think this calls for some more significant changes to handle same-

Re: Issue 4365: non-member is_smob<>(), is_derived_smob<>(), etc. (issue 231680043 by nine.fierce.ball...@gmail.com)

2015-05-16 Thread nine . fierce . ballads
On 2015/05/16 15:09:05, dak wrote: I don't really like this one. "unsmob (self)" should really be "this". Using the even less specific unsmob seems like a step in the wrong direction. This might call for unchecked_unsmob (should this be protected rather than private?). That seems prett

Re: Issue 2787: Sanitize usage of -DDEBUG, -DNDEBUG and assert (issue 236190043 by d...@gnu.org)

2015-05-16 Thread dak
On 2015/05/16 18:18:49, Keith wrote: Probably a good idea, if assert() is really used like this. > assert is essentially stating that the program cannot > usefully continue if the assertion is not met There are uses of assert() where I suspect the output on conditions that would violate t

Re: Issue 2787: Sanitize usage of -DDEBUG, -DNDEBUG and assert (issue 236190043 by d...@gnu.org)

2015-05-16 Thread k-ohara5a5a
Probably a good idea, if assert() is really used like this. assert is essentially stating that the program cannot usefully continue if the assertion is not met There are uses of assert() where I suspect the output on conditions that would violate the assertion, would be better than no output a

Re: Issue 4365: non-member is_smob<>(), is_derived_smob<>(), etc. (issue 231680043 by nine.fierce.ball...@gmail.com)

2015-05-16 Thread dak
https://codereview.appspot.com/231680043/diff/40001/lily/include/listener.hh File lily/include/listener.hh (right): https://codereview.appspot.com/231680043/diff/40001/lily/include/listener.hh#newcode185 lily/include/listener.hh:185: unsmob (self)->trampoline_ (target, ev); I don't really like t

Re: Google Code shutting down

2015-05-16 Thread Trevor Daniels
Trevor Daniels wrote Saturday, May 16, 2015 12:27 PM > > David Kastrup wrote Saturday, May 16, 2015 11:11 AM > >>> Trevor Daniels wrote Tuesday, May 12, 2015 9:15 PM >>> I'm sure we'll find some undesirable features of Allura when we get >>> down to the details, but that's what the next few

Re: Use mkstemp for intermediate ps files (issue 233230044 by truer...@gmail.com)

2015-05-16 Thread trueroad
I've pushed. Issue 4374 / 1: Fix platform identification authorMasamichi Hosoda Sat, 9 May 2015 08:20:19 + (17:20 +0900) committer Masamichi Hosoda Sat, 16 May 2015 11:56:31 + (20:56 +0900) commite2eb72d3d2070a3888df1f7e7907798833965baa Issue 4374 / 2: Add make-tmpfile procedu

Re: Google Code shutting down

2015-05-16 Thread Trevor Daniels
David Kastrup wrote Saturday, May 16, 2015 11:11 AM >> Trevor Daniels wrote Tuesday, May 12, 2015 9:15 PM >> >>> I'm sure we'll find some undesirable features of Allura when we get >> down to the details, but that's what the next few weeks will tell us. >> >> I've pretty well completed my assessm

Re: Google Code shutting down

2015-05-16 Thread Trevor Daniels
Phil Holmes wrote Saturday, May 16, 2015 11:17 AM > >> Trevor Daniels wrote Tuesday, May 12, 2015 9:15 PM >> >>> I'm sure we'll find some undesirable features of Allura when we get down >>> to the details, but that's what the next few weeks will tell us. >> >> I've pretty well completed my assess

Re: Google Code shutting down

2015-05-16 Thread David Kastrup
"Trevor Daniels" writes: > Trevor Daniels wrote Tuesday, May 12, 2015 9:15 PM > >> I'm sure we'll find some undesirable features of Allura when we get > down to the details, but that's what the next few weeks will tell us. > > I've pretty well completed my assessment of Allura at SourceForge, and

Re: Google Code shutting down

2015-05-16 Thread Phil Holmes
- Original Message - From: "Trevor Daniels" To: "Trevor Daniels" ; "James" ; "Phil Holmes" Cc: Sent: Saturday, May 16, 2015 10:44 AM Subject: Re: Google Code shutting down Trevor Daniels wrote Tuesday, May 12, 2015 9:15 PM I'm sure we'll find some undesirable features of Allura w

Re: Google Code shutting down

2015-05-16 Thread Trevor Daniels
Trevor Daniels wrote Tuesday, May 12, 2015 9:15 PM > I'm sure we'll find some undesirable features of Allura when we get down to > the details, but that's what the next few weeks will tell us. I've pretty well completed my assessment of Allura at SourceForge, and find the facilities available