PATCHES: Countdown for June 23rd 2015

2015-06-20 Thread James Lowe
Hello, Here is the current patch countdown list. The next countdown will be on June 23rd. You can always view the most current countdown list here: http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaitingcolspec=Patch%20Owner%20ID%20Summarysort=patch

Parentheses in ChordNames

2015-06-20 Thread Marc Hohl
Hi list, in my latest project, I found out that \score { \new ChordNames { \chordmode { \parenthesize c } } } yields in way too tiny parentheses. The following patch resolves that problem. I recall vaguely that 'git cl upload' does not work anymore. How can I upload that patch to Rietveld?

Re: Parentheses in ChordNames

2015-06-20 Thread David Kastrup
Marc Hohl m...@hohlart.de writes: Am 20.06.2015 um 19:47 schrieb David Kastrup: Marc Hohl m...@hohlart.de writes: Hi list, in my latest project, I found out that \score { \new ChordNames { \chordmode { \parenthesize c } } } yields in way too tiny parentheses. The following patch

Re: Parentheses in ChordNames

2015-06-20 Thread Marc Hohl
Am 20.06.2015 um 19:47 schrieb David Kastrup: Marc Hohl m...@hohlart.de writes: Hi list, in my latest project, I found out that \score { \new ChordNames { \chordmode { \parenthesize c } } } yields in way too tiny parentheses. The following patch resolves that problem. I recall vaguely

Re: Parentheses in ChordNames

2015-06-20 Thread David Kastrup
Marc Hohl m...@hohlart.de writes: Hi list, in my latest project, I found out that \score { \new ChordNames { \chordmode { \parenthesize c } } } yields in way too tiny parentheses. The following patch resolves that problem. I recall vaguely that 'git cl upload' does not work anymore.

Re: Make music functions callable from Scheme (issue 244840043 by d...@gnu.org)

2015-06-20 Thread Keith OHara
On Mon, 08 Jun 2015 18:04:44 -0700, d...@gnu.org wrote: No dice. The main problem is dealing with all combinations of running out of signature and running out of available arguments. If you treat the optional argument skipping in an inner loop, you may still run out of signature, and in that

Re: balloon-text: robust with empty stencils; issue 4447 (issue 243610043 by k-ohara5...@oco.net)

2015-06-20 Thread Keith OHara
On Fri, 19 Jun 2015 23:50:50 -0700, d...@gnu.org wrote: https://codereview.appspot.com/243610043/diff/1/lily/balloon.cc#newcode94 lily/balloon.cc:94: b.widen (padding, padding); Basically we have two options here: not draw a box at all (it would be my guess that this is probably what happened

Re: simple-spacer: inappropriate assert; issue 4448 (issue 249820043 by k-ohara5...@oco.net)

2015-06-20 Thread Keith OHara
On Fri, 19 Jun 2015 23:59:11 -0700, d...@gnu.org wrote: https://codereview.appspot.com/249820043/diff/1/lily/simple-spacer.cc File lily/simple-spacer.cc (right): https://codereview.appspot.com/249820043/diff/1/lily/simple-spacer.cc#newcode199 lily/simple-spacer.cc:199: programming_error

Re: simple-spacer: inappropriate assert; issue 4448 (issue 249820043 by k-ohara5...@oco.net)

2015-06-20 Thread David Kastrup
Keith OHara k-ohara5...@oco.net writes: On Fri, 19 Jun 2015 23:59:11 -0700, d...@gnu.org wrote: https://codereview.appspot.com/249820043/diff/1/lily/simple-spacer.cc File lily/simple-spacer.cc (right): https://codereview.appspot.com/249820043/diff/1/lily/simple-spacer.cc#newcode199

Re: Make music functions callable from Scheme (issue 244840043 by d...@gnu.org)

2015-06-20 Thread David Kastrup
Keith OHara k-ohara5...@oco.net writes: On Mon, 08 Jun 2015 18:04:44 -0700, d...@gnu.org wrote: No dice. The main problem is dealing with all combinations of running out of signature and running out of available arguments. If you treat the optional argument skipping in an inner loop, you

Re: balloon-text: robust with empty stencils; issue 4447 (issue 243610043 by k-ohara5...@oco.net)

2015-06-20 Thread David Kastrup
Keith OHara k-ohara5...@oco.net writes: On Fri, 19 Jun 2015 23:50:50 -0700, d...@gnu.org wrote: https://codereview.appspot.com/243610043/diff/1/lily/balloon.cc#newcode94 lily/balloon.cc:94: b.widen (padding, padding); Basically we have two options here: not draw a box at all (it would be