Re: Auto_change_iterator: move some state from C++ to Scheme (issue 248470043 by nine.fierce.ball...@gmail.com)

2015-07-03 Thread thomasmorley65
On 2015/07/03 00:54:27, Dan Eble wrote: On 2015/07/02 12:36:04, Dan Eble wrote: > I haven't yet reached an understanding of what should be done about > make-non-relative-music. After some testing, I understand that make-non-relative-music should have been used within \autochange. I've poste

Re: Avoid treating x as relative in \relative { \autochange {x} } (issue 250170043 by nine.fierce.ball...@gmail.com)

2015-07-03 Thread thomasmorley65
Looks like it's now consistent with the NR saying: "A \relative section that is outside of \autochange has no effect on the pitches of the music, so if necessary, put \relative inside \autochange. " LGTM https://codereview.appspot.com/250170043/ ___ l

Issue 4478: Disentangle some Tie and Semi_tie code. (issue 251840044 by nine.fierce.ball...@gmail.com)

2015-07-03 Thread nine . fierce . ballads
Reviewers: , Description: Both are Grobs, but ties are Spanners and semi-ties are Items. The code for both cases was jumbled together in many Tie methods. I hope that I have clarified a few things. No functional changes are intended. Please review this at https://codereview.appspot.com/251840

Doc: Issue 4059: Document MIDI mapping and MIDI effects (issue 249980043 by tdanielsmu...@googlemail.com)

2015-07-03 Thread k-ohara5a5a
Sorry I'm late. You might still slip in a correction, or just remove mention of midiChannelMapping='voice since we haven't found a use for it. https://codereview.appspot.com/249980043/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.a

Re: Avoid treating x as relative in \relative { \autochange {x} } (issue 250170043 by nine.fierce.ball...@gmail.com)

2015-07-03 Thread k-ohara5a5a
\relative does its job just fine on the output of \autochange and \partcombine. The only problem is that \absolute and \partcombine assume they have been given the final pitches, so applying relative afterwards messes up the work of \autochange and \partcombine. So \autochange and \partcombine d