Re: Issue 4516: Make \offset handle unpure/pure containers (issue 250590043 by d...@gnu.org)

2015-07-23 Thread david . nalesnik
LGTM. Thanks again! https://codereview.appspot.com/250590043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Remove redundant occurences of this-> (issue 258870043 by d...@gnu.org)

2015-07-23 Thread dak
https://codereview.appspot.com/258870043/diff/1/lily/grob.cc File lily/grob.cc (right): https://codereview.appspot.com/258870043/diff/1/lily/grob.cc#newcode232 lily/grob.cc:232: /* This version of get_system is more reliable than get_system () On 2015/07/23 05:50:38, Keith wrote: What do you me

Re: Issue 4516: Make \offset handle unpure/pure containers (issue 250590043 by d...@gnu.org)

2015-07-23 Thread dak
On 2015/07/22 16:59:14, dak wrote: Oh, this doesn't work yet: looks nice but I did not think it through correctly. To wit: this needs to produce a value for the override at override time but will only be able to decide about the kind of value to offset at runtime. That means it _always_ needs