Re: PATCHES: Countdown for August 26th 2015 - IMPORTANT UPDATE TO PATCH REVIEW PROCESS - PLEASE READ

2015-08-23 Thread Simon Albrecht
Hello James, so many thanks for all the managing work you are doing here! It’s priceless in keeping our project going, I think. Am 23.08.2015 um 18:58 schrieb James Lowe: I'm not sure what the bug squad want to do with regard to new bugs that need 'tracking', How about managing this through t

Re: Issue 4560: group #include directives at top of file (issue 254670043 by nine.fierce.ball...@gmail.com)

2015-08-23 Thread dak
On 2015/08/23 18:48:00, Dan Eble wrote: On 2015/08/23 16:31:46, dak wrote: > > As it stands, this patch would appear quite broken to me as it fails to > > work when the config variable HAVE_STL_DATA_METHOD is 0: in that case, > > std-vector.hh defines its own vector template class that is _no

Re: Further GUB failure

2015-08-23 Thread David Kastrup
Dan Eble writes: > David wrote: >> isinf is supposed to be defined in cmath (without scoping) which is >> included by flower/include/offset.hh. And of course this works on most >> platforms or we'd have gotten complaints already. > > What’s your source? I tried interpreting the last draft C++11

Reverting issue 4550 for now (was: Issue 4560: group #include directives at top of file (issue 254670043 by nine.fierce.ball...@gmail.com))

2015-08-23 Thread David Kastrup
Dan Eble writes: > On Aug 23, 2015, at 14:48 , nine.fierce.ball...@gmail.com wrote: >> >>> > Until this is sorted out, I strongly suggest that we revert this >> patch. >> >> I agree. > > And note that this is issue *4550*, not what appears in the subject line. > > Who is going to do the reverti

Re: Issue 4560: group #include directives at top of file (issue 254670043 by nine.fierce.ball...@gmail.com)

2015-08-23 Thread Dan Eble
On Aug 23, 2015, at 14:48 , nine.fierce.ball...@gmail.com wrote: > >> > Until this is sorted out, I strongly suggest that we revert this > patch. > > I agree. And note that this is issue *4550*, not what appears in the subject line. Who is going to do the reverting? > https://codereview.appspo

Re: Issue 4560: group #include directives at top of file (issue 254670043 by nine.fierce.ball...@gmail.com)

2015-08-23 Thread nine . fierce . ballads
On 2015/08/23 16:31:46, dak wrote: > As it stands, this patch would appear quite broken to me as it fails to > work when the config variable HAVE_STL_DATA_METHOD is 0: in that case, > std-vector.hh defines its own vector template class that is _not_ > accessible via std::vector. Drat. Do w

Re: Further GUB failure

2015-08-23 Thread Dan Eble
David wrote: > isinf is supposed to be defined in cmath (without scoping) which is > included by flower/include/offset.hh. And of course this works on most > platforms or we'd have gotten complaints already. What’s your source? http://en.cppreference.com/w/cpp/numeric/math/isinf shows that the

Re: PATCHES: Countdown for August 26th 2015 - IMPORTANT UPDATE TO PATCHREVIEW PROCESS - PLEASE READ

2015-08-23 Thread Trevor Daniels
James Lowe wrote Sunday, August 23, 2015 5:58 PM > Google Tracker will be 'read-only' on the 25th August. At the moment, > as I understand it we are still 'transitioning' to a new tracker > system for issues but Rietveld is still working as normal. Preparations for using Allura are looking up.

Re: PATCHES: Countdown for August 26th 2015 - IMPORTANT UPDATE TO PATCH REVIEW PROCESS - PLEASE READ

2015-08-23 Thread Paul Morris
Thanks James! > On Aug 23, 2015, at 12:58 PM, James Lowe wrote: > > REVIEW: Here’s another patch with review status: Issue 4504: Revert interface changes for whiteout (issue 4418) https://code.google.com/p/lilypond/issues/detail?id=4504 https://codereview.appspot.com/264810043/ -Paul ___

Re: PATCHES: Countdown for August 26th 2015 - IMPORTANT UPDATE TO PATCH REVIEW PROCESS - PLEASE READ

2015-08-23 Thread David Kastrup
James Lowe writes: > Hello, > > ***Important do please read*** > > Google Tracker will be 'read-only' on the 25th August. At the moment, > as I understand it we are still 'transitioning' to a new tracker > system for issues but Rietveld is still working as normal. > > This will make keeping track

Re: PATCHES: Countdown for August 26th 2015 - IMPORTANT UPDATE TO PATCH REVIEW PROCESS - PLEASE READ

2015-08-23 Thread Thomas Morley
2015-08-23 18:58 GMT+02:00 James Lowe : > Hello, > > ***Important do please read*** > > Google Tracker will be 'read-only' on the 25th August. At the moment, > as I understand it we are still 'transitioning' to a new tracker > system for issues but Rietveld is still working as normal. > > This will

PATCHES: Countdown for August 26th 2015 - IMPORTANT UPDATE TO PATCH REVIEW PROCESS - PLEASE READ

2015-08-23 Thread James Lowe
Hello, ***Important do please read*** Google Tracker will be 'read-only' on the 25th August. At the moment, as I understand it we are still 'transitioning' to a new tracker system for issues but Rietveld is still working as normal. This will make keeping track of patches a bit more involved for

Re: Issue 4560: group #include directives at top of file (issue 254670043 by nine.fierce.ball...@gmail.com)

2015-08-23 Thread David Kastrup
d...@gnu.org writes: > https://codereview.appspot.com/254670043/diff/60001/flower/include/std-vector.hh > File flower/include/std-vector.hh (right): > > https://codereview.appspot.com/254670043/diff/60001/flower/include/std-vector.hh#newcode70 > flower/include/std-vector.hh:70: #if HAVE_STL_DATA_M

Re: Issue 4560: group #include directives at top of file (issue 254670043 by nine.fierce.ball...@gmail.com)

2015-08-23 Thread dak
https://codereview.appspot.com/254670043/diff/60001/flower/include/std-vector.hh File flower/include/std-vector.hh (right): https://codereview.appspot.com/254670043/diff/60001/flower/include/std-vector.hh#newcode70 flower/include/std-vector.hh:70: #if HAVE_STL_DATA_METHOD As it stands, this patc

Re: Further GUB failure

2015-08-23 Thread David Kastrup
"Phil Holmes" writes: > - Original Message - > From: "David Kastrup" > To: "Phil Holmes" > Cc: > Sent: Sunday, August 23, 2015 4:00 PM > Subject: Re: Further GUB failure > > >> Phil Holmes writes: >> >>> I'm now getting this error: >>> >>> /home/gub/NewGub/gub/target/darwin-ppc/src/l

Re: Further GUB failure

2015-08-23 Thread Phil Holmes
- Original Message - From: "David Kastrup" To: "Phil Holmes" Cc: Sent: Sunday, August 23, 2015 4:00 PM Subject: Re: Further GUB failure Phil Holmes writes: I'm now getting this error: /home/gub/NewGub/gub/target/darwin-ppc/src/lilypond-git.sv.gnu.org-- lilypond.git-release-unsta

Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by thomasmorle...@gmail.com)

2015-08-23 Thread dak
https://codereview.appspot.com/257580043/diff/1/scm/fret-diagrams.scm File scm/fret-diagrams.scm (right): https://codereview.appspot.com/257580043/diff/1/scm/fret-diagrams.scm#newcode45 scm/fret-diagrams.scm:45: (define (not-number-error input output) "input" insinuates a port input, like "outpu

Re: Further GUB failure

2015-08-23 Thread David Kastrup
Phil Holmes writes: > I'm now getting this error: > > /home/gub/NewGub/gub/target/darwin-ppc/src/lilypond-git.sv.gnu.org-- > lilypond.git-release-unstable/flower/offset.cc:43:25: error: 'isinf' was not > declared in this scope >if (!isinf (z2[Y_AXIS])) > ^ > > It look

Re: Further GUB failure

2015-08-23 Thread Masamichi HOSODA
> I'm now getting this error: > > /home/gub/NewGub/gub/target/darwin-ppc/src/lilypond-git.sv.gnu.org-- > lilypond.git-release-unstable/flower/offset.cc:43:25: error: 'isinf' was not > declared in this scope >if (!isinf (z2[Y_AXIS])) > ^ > > It looks like the compiler

Further GUB failure

2015-08-23 Thread Phil Holmes
I'm now getting this error: /home/gub/NewGub/gub/target/darwin-ppc/src/lilypond-git.sv.gnu.org-- lilypond.git-release-unstable/flower/offset.cc:43:25: error: 'isinf' was not declared in this scope if (!isinf (z2[Y_AXIS])) ^ It looks like the compiler cannot find isinf,

Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by thomasmorle...@gmail.com)

2015-08-23 Thread thomasmorley65
Reviewers: , Message: please review Description: Clear fret-diagram- and harp-pedal-input-strings from whitespace Whitespace-characters are deleted before further processing. Allows for \markup \fret-diagram #"s:2;h:5; 6-3;5-5;4-5;3-4;2-3;1-x;" Also adding errors for typos in fret-diagram wit

Re: GUB failure

2015-08-23 Thread Phil Holmes
- Original Message - From: "Masamichi HOSODA" To: Cc: Sent: Sunday, August 23, 2015 12:52 PM Subject: Re: GUB failure Following the changes to the fonts, I'm now having GUB fail. The log shows: configure: WARNING: unrecognized options: --enable-shared, --disable-static, --disab

Re: GUB failure

2015-08-23 Thread Masamichi HOSODA
> Following the changes to the fonts, I'm now having GUB fail. The log shows: > > configure: WARNING: unrecognized options: --enable-shared, --disable-static, > --disable-silent-rules, --with-fonts-dir > > WARNING: Please consider installing optional programs or files: dblatex > > ERROR: Pleas

GUB failure

2015-08-23 Thread Phil Holmes
Following the changes to the fonts, I'm now having GUB fail. The log shows: configure: WARNING: unrecognized options: --enable-shared, --disable-static, --disable-silent-rules, --with-fonts-dir WARNING: Please consider installing optional programs or files: dblatex ERROR: Please install requir