PATCHES: Countdown for November 16th 2015

2015-11-13 Thread James
Hello, Here is the current patch countdown list. The next countdown will be on November 16th PUSH: 4650 Usage 1.2: svg-woff option badly described - James Lowe https://sourceforge.net/p/testlilyissues/issues/4650/ http://codereview.appspot.com/274260043 4656 Let concat-ma

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

2015-11-13 Thread thomasmorley65
On 2015/11/12 15:20:51, dak wrote: On 2015/11/11 09:56:16, thomasmorley651 wrote: > Well, outer/inner-control rely on the user-settable variables bow-height and > thickness. Ok, didn't notice that. I'm not sure it's the best interface to have those in semi-absolute dimensions but at le

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

2015-11-13 Thread dak
Sorry for yet finding more stuff that, after all, could likely be improved. At least I did so pretty quickly this time. https://codereview.appspot.com/270640043/diff/60001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/270640043/diff/

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

2015-11-13 Thread thomasmorley65
On 2015/11/13 21:51:19, dak wrote: Sorry for yet finding more stuff that, after all, could likely be improved. At least I did so pretty quickly this time. No problem! The code became so much better during revision! I have to work too much in my regular job to upload more than one patch-set p

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

2015-11-13 Thread dak
Aaand another one. https://codereview.appspot.com/270640043/diff/60001/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/270640043/diff/60001/scm/stencil.scm#newcode66 scm/stencil.scm:66: (if (equal? start stop) I think that's too optimistic. If you have start = (0 .

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

2015-11-13 Thread thomasmorley65
On 2015/11/13 22:38:02, thomasmorley651 wrote: On 2015/11/13 21:51:19, dak wrote: > Sorry for yet finding more stuff that, after all, could likely be improved. At > least I did so pretty quickly this time. No problem! The code became so much better during revision! I have to work too much in

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

2015-11-13 Thread thomasmorley65
On 2015/11/13 23:01:39, dak wrote: Aaand another one. https://codereview.appspot.com/270640043/diff/60001/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/270640043/diff/60001/scm/stencil.scm#newcode66 scm/stencil.scm:66: (if (equal? start stop) I think that's t

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

2015-11-13 Thread tdanielsmusic
https://codereview.appspot.com/270640043/diff/60001/scm/define-markup-commands.scm#newcode623 > > scm/define-markup-commands.scm:623: (direction DOWN) > > Should this markup command be called "undertie" or should it rather be "tie", > > with "undertie" explicitly overriding `direction'? > > >