Re: Moving a number of C++ constructs to SCM

2016-05-04 Thread James Lowe
On 02/05/16 23:58, David Kastrup wrote: This is a sequence of patches. The first one is just the same as the already submitted issue 4840 (so that this can be tested on master): it did not make sense to disentangle the bulk of this work from that change. If you point "git am" at the (sorted) se

Re: Moving a number of C++ constructs to SCM

2016-05-04 Thread David Kastrup
James Lowe writes: > On 02/05/16 23:58, David Kastrup wrote: >> This is a sequence of patches. The first one is just the same as the >> already submitted issue 4840 (so that this can be tested on master): >> it did not make sense to disentangle the bulk of this work from that >> change. >> >> If

Re: Moving a number of C++ constructs to SCM

2016-05-04 Thread James
Daivd On 04/05/16 09:06, David Kastrup wrote: James Lowe writes: On 02/05/16 23:58, David Kastrup wrote: This is a sequence of patches. The first one is just the same as the already submitted issue 4840 (so that this can be tested on master): it did not make sense to disentangle the bulk of

lilypond-ftplugin.vim: set makeprg locally rather than globally (issue 292660043 by gre...@fastmail.co.uk)

2016-05-04 Thread gregrs
Reviewers: , Message: This avoids changing the make program for other Vim buffers when using mapped keys to compile a LilyPond file Description: lilypond-ftplugin.vim: set makeprg locally rather than globally This avoids changing the make program for other Vim buffers when using mapped keys to c

Doc: Contrib 2.3 Updating git-cl - change source directory (issue 299880043 by gre...@fastmail.co.uk)

2016-05-04 Thread gregrs
Reviewers: , Description: Doc: Contrib 2.3 Updating git-cl - change source directory Change the directory in which the user must run `git pull` to update git-cl Please review this at https://codereview.appspot.com/299880043/ Affected files (+1, -1 lines): M Documentation/contributor/quick-sta

Re: Avoid some C++ comparisons of SCM values (issue 296010043 by pkx1...@gmail.com)

2016-05-04 Thread dak
https://codereview.appspot.com/296010043/diff/1/lily/output-def-scheme.cc File lily/output-def-scheme.cc (right): https://codereview.appspot.com/296010043/diff/1/lily/output-def-scheme.cc#newcode104 lily/output-def-scheme.cc:104: if (td && scm_is_eq (key, td->get_context_name ())); Man, is this

PATCHES: Countdown for May 4th

2016-05-04 Thread James Lowe
Hello, Here is the current patch countdown list. The next countdown will be on May 7th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ __ Push: 4829 add all languages for content negotiation and explain how t