LGTM. If this didn't change any regression test results and you don't
want it to break again, add a regression test.
https://codereview.appspot.com/296570043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinf
Am 26. Juni 2016 17:06:51 MESZ, schrieb David Kastrup :
>Jan-Peter Voigt writes:
> ...
>> Whenever you are up to using static members, change it to properties
>> of the Score context - or look for session global objects.
>
>"Session global" does not work with score markups in music:
ah, I wasn't
Reviewers: ,
Message:
Midi_walker::do_start_note: skip ignored notes in stop_note_queue
For each semitone pitch value, stop_note_queue is likely supposed to
contain
at most one Midi_note event with its "ignore_" flag set to false, and
the
comparisons between notes of equal semitone pitch to be a
Jan-Peter Voigt writes:
> Hi all,
>
> @David: thank you for your "emergency call"!
> @Nathan: sorry, for giving you bad advise in this case!
>
> To summarize, what to do with spanners, tagged with an ID: Use context
> properties to store them "globally". You can consider the Score
> context "glob
Hi all,
@David: thank you for your "emergency call"!
@Nathan: sorry, for giving you bad advise in this case!
To summarize, what to do with spanners, tagged with an ID: Use context
properties to store them "globally". You can consider the Score context
"global". If there is a context defined wit
> This code always gets the first name in the CFF's name index. Is
this
> sufficient?
I think it is sufficient.
OpenType Specification ver. 1.7 says that
"The Name INDEX in the CFF must contain only one entry;"
https://www.microsoft.com/typography/otspec/cff.htm
Ah, yes, I've forgotten
Thank you for your comments.
https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc
File lily/open-type-font.cc (right):
https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#newcode185
lily/open-type-font.cc:185: // FreeType 2.6.2+ has been fixed this
