Re: NR: Mention standalone accidentals in figuremode (issue 299510043 by g...@ursliska.de)

2016-07-03 Thread tdanielsmusic
LGTM Trevor https://codereview.appspot.com/299510043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: NR: Mention standalone accidentals in figuremode (issue 299510043 by g...@ursliska.de)

2016-07-03 Thread Urs Liska
Am 03.07.2016 um 23:05 schrieb d...@gnu.org: > I think this chapter would deserve a lot more love I agree, but I can't provide that currently. Maybe things look differently when I'm more into (or through) the current project, which is my first encounter (engraving-wise) with figured bass.

Re: NR: Mention standalone accidentals in figuremode (issue 299510043 by g...@ursliska.de)

2016-07-03 Thread dak
I think this chapter would deserve a lot more love but the proposed change is still quite a step forward, so LGTM with the mentioned reservation. https://codereview.appspot.com/299510043/diff/20001/Documentation/notation/chords.itely File Documentation/notation/chords.itely (right): https://cod

Re: NR: Mention standalone accidentals in figuremode (issue 299510043 by g...@ursliska.de)

2016-07-03 Thread dak
On 2016/07/03 12:51:51, git wrote: Am 03.07.2016 um 14:49 schrieb mailto:benko@gmail.com: > LGTM > > https://codereview.appspot.com/299510043/ Discussion on lilypond-user (http://lists.gnu.org/archive/html/lilypond-user/2016-07/msg00058.html) show that it isn't that good. I think there

Re: NR: Mention standalone accidentals in figuremode (issue 299510043 by g...@ursliska.de)

2016-07-03 Thread lemzwerg
Well, I suggest to apply this patch anyway. Rewriting can be done later on. https://codereview.appspot.com/299510043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: NR: Mention standalone accidentals in figuremode (issue 299510043 by g...@ursliska.de)

2016-07-03 Thread Urs Liska
Am 03.07.2016 um 14:49 schrieb benko@gmail.com: > LGTM > > https://codereview.appspot.com/299510043/ Discussion on lilypond-user (http://lists.gnu.org/archive/html/lilypond-user/2016-07/msg00058.html) show that it isn't that good. I think there *is* something to be done about the current sta

Re: NR: Mention standalone accidentals in figuremode (issue 299510043 by g...@ursliska.de)

2016-07-03 Thread benko . pal
LGTM https://codereview.appspot.com/299510043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

NR: Mention standalone accidentals in figuremode (issue 299510043 by g...@ursliska.de)

2016-07-03 Thread lemzwerg
LGTM. https://codereview.appspot.com/299510043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel