Using eq? on numbers is undefined behavior (issue 314300043 by d...@gnu.org)

2017-01-23 Thread lemzwerg
LGTM https://codereview.appspot.com/314300043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-23 Thread thomasmorley65
Two thoughts, otherwise LGTM https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2522 Do

Re: Let \alterBroken tweak ties again (issue 319160043 by david.nales...@gmail.com)

2017-01-23 Thread david . nalesnik
On 2017/01/23 19:00:43, david.nalesnik wrote: No problem. https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly#newcode107 ly/music-functions-init.ly:10

Re: GSoC project ideas

2017-01-23 Thread Simon Albrecht
On 23.01.2017 22:47, Urs Liska wrote: So while it's perfectly possible to put OLL projects on the list and to apply for them (or others not listed there) in case of doubt projects working on LilyPond itself might be the preference of the developer community. […] What I would see as a better pro

Re: GSoC project ideas

2017-01-23 Thread Urs Liska
Am 23.01.2017 um 21:53 schrieb Jeffery Shivers: > This might be selfish, but how about at least one of those ideas be an OLL > (or even scholarLY) thing? I'd like to have others comment on this, but technically this could be very well possible. I must admit that I felt somewhat uneasy last year

Re: NR: Replace \set Staff.instrumentName (issue 313400043 by pkx1...@gmail.com)

2017-01-23 Thread pkx166h
Hopefully this has simplified some of the examples. I have made sure that the output after the change is identical (apart from twp x-11 color markup definitions which I think was a better choice - see comment below) https://codereview.appspot.com/313400043/diff/1/Documentation/notation/editoria

Re: GSoC project ideas

2017-01-23 Thread Jeffery Shivers
This might be selfish, but how about at least one of those ideas be an OLL (or even scholarLY) thing? I can't guarantee what the exact status of scholarLY annotations and the LaTeX package will be by April - therefore I definitely don't suggest a direct extension of *that/those* projects. (Althoug

Re: GSoC project ideas

2017-01-23 Thread Urs Liska
> >PS: >I've also provided a patch containing a section with recommendations to >potential students. They draw from my own experience as a mentor last >year and suggestions discussed both on the mentors' mailing list and >the >mentors' summit last year. Please consider these paragraphs too, as >

GSoC project ideas

2017-01-23 Thread Urs Liska
Hi all, GSoC has started and the timeline is proceeding quickly (https://summerofcode.withgoogle.com/). GNU is going to apply until February 9, and by February 27 I expect them to be accepted to the program, which will make LilyPond applicable as well. Students will apply between March 20 and Ap

Re: Let \alterBroken tweak ties again (issue 319160043 by david.nales...@gmail.com)

2017-01-23 Thread david . nalesnik
No problem. https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly#newcode107 ly/music-functions-init.ly:107: (if (or (eq? (ly:music-property item 'span-direct

Let \alterBroken tweak ties again (issue 319160043 by david.nales...@gmail.com)

2017-01-23 Thread david . nalesnik
Reviewers: , Message: Please review. Thanks! Description: Let \alterBroken tweak ties again When tweaking Tie grobs, the music function \alterBroken has incorrectly rejected them since 2.17.6 as not being spanners. The method of spanner recognition is at fault: 'span-direction is not used by T

Re: Let \alterBroken tweak ties again (issue 319160043 by david.nales...@gmail.com)

2017-01-23 Thread dak
https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/319160043/diff/1/ly/music-functions-init.ly#newcode107 ly/music-functions-init.ly:107: (if (or (eq? (ly:music-property item 'span-direction) START) T

LilyDev 5.1 released

2017-01-23 Thread Federico Bruni
https://github.com/fedelibre/LilyDev/releases/tag/v5.1 Notable changes in this minor release: - the setup script at first login is now working again (it was broken in v5.0) - all applications now have an icon in the LxQT menu (so the "drag icon here" hint in the application bar makes more sen

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

2017-01-23 Thread simon . albrecht
LGTM. https://codereview.appspot.com/319150043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel