Re: Additions in event-listener.ly (issue 152600043 by pkx1...@gmail.com)

On 2017/03/22 10:24:21, dak wrote: ly/event-listener.ly:69: (eq? 0 (ly:moment-grace-numerator moment)) Why this change for the worse? Numbers need to be compared with eqv? rather than eq? and I don't see that anything was wrong with zero? here since ly:moment-grace-numerator certainly cannot

Update copyright for 2016/17 files, and script (issue 320390043 by g...@ursliska.de)

Could you separate the "Run script xyz" changes from the changes to script(s)? That would help to see exactly what's happening here. https://codereview.appspot.com/320390043/diff/1/scripts/auxiliar/update-copyright.sh File scripts/auxiliar/update-copyright.sh (right):

Re: PATCHES - Countdown for Wednesday March 22nd

- Original Message - From: "David Nalesnik" To: "James" Cc: "Dev" Sent: Wednesday, March 22, 2017 1:11 PM Subject: Re: PATCHES - Countdown for Wednesday March 22nd Hi James, On Wed, Mar 22, 2017 at 2:27 AM, James

Re: PATCHES - Countdown for Wednesday March 22nd

Hi James, On Wed, Mar 22, 2017 at 2:27 AM, James wrote: > Hello, > > Here is the current patch countdown list. The next countdown will be on > March 25th > > > A quick synopsis of all patches currently in the review process can be > found here: > >

Re: Additions in event-listener.ly (issue 152600043 by pkx1...@gmail.com)

https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly File ly/event-listener.ly (right): https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly#newcode69 ly/event-listener.ly:69: (eq? 0 (ly:moment-grace-numerator moment)) Why this change for the worse? Numbers need

PATCHES - Countdown for Wednesday March 22nd

Hello, Here is the current patch countdown list. The next countdown will be on March 25th A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5098 Fix some programming errors "no interface for property" -

Re: Additions in event-listener.ly (issue 152600043 by pkx1...@gmail.com)

On 2014/10/17 06:40:24, Valentin Villenave wrote: Greetings Philippe and James, this looks good overall, I just have one minor comment. https://codereview.appspot.com/152600043/diff/1/ly/event-listener.ly File ly/event-listener.ly (right):