Re: Create engravers for merging rests (issue 321930043 by horndud...@gmail.com)

2017-05-20 Thread horndude77
https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm File scm/scheme-engravers.scm (right): https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm#newcode151 scm/scheme-engravers.scm:151: (define (rest-eqv rest-len-prop) On 2017/05/20 12:18:33,

Re: Create engravers for merging rests (issue 321930043 by horndud...@gmail.com)

2017-05-20 Thread david . nalesnik
Looks much better -- see comments below. https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm File scm/scheme-engravers.scm (right): https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm#newcode167 scm/scheme-engravers.scm:167: (lambda (rest)

Re: Create engravers for merging rests (issue 321930043 by horndud...@gmail.com)

2017-05-20 Thread thomasmorley65
Much better now, though: https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm File scm/scheme-engravers.scm (right): https://codereview.appspot.com/321930043/diff/11/scm/scheme-engravers.scm#newcode151 scm/scheme-engravers.scm:151: (define (rest-eqv rest-len-prop)

PATCHES - Countdown for May 20th

2017-05-20 Thread James
Hello, Here is the current patch countdown list. The next countdown will be on May 23rd. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: No patches to Push at this time. Countdown: 1388 Support OpenType