Re: Let Merge_rests_engraver deal with dotted rests (issue 324310043 by thomasmorle...@gmail.com)

2017-08-28 Thread dak
On 2017/08/28 16:01:36, thomasmorley651 wrote: On 2017/08/28 15:18:06, dak wrote: > https://codereview.appspot.com/324310043/diff/1/scm/scheme-engravers.scm > File scm/scheme-engravers.scm (right): > > https://codereview.appspot.com/324310043/diff/1/scm/scheme-engravers.scm#newcode121 >

Re: Let Merge_rests_engraver deal with dotted rests (issue 324310043 by thomasmorle...@gmail.com)

2017-08-28 Thread thomasmorley65
On 2017/08/28 15:18:06, dak wrote: https://codereview.appspot.com/324310043/diff/1/scm/scheme-engravers.scm File scm/scheme-engravers.scm (right): https://codereview.appspot.com/324310043/diff/1/scm/scheme-engravers.scm#newcode121 scm/scheme-engravers.scm:121: (define-public

Re: Let Merge_rests_engraver deal with dotted rests (issue 324310043 by thomasmorle...@gmail.com)

2017-08-28 Thread dak
https://codereview.appspot.com/324310043/diff/1/scm/scheme-engravers.scm File scm/scheme-engravers.scm (right): https://codereview.appspot.com/324310043/diff/1/scm/scheme-engravers.scm#newcode121 scm/scheme-engravers.scm:121: (define-public (Merge_rests_engraver context) Stupid question: is

Let Merge_rests_engraver deal with dotted rests (issue 324310043 by thomasmorle...@gmail.com)

2017-08-28 Thread thomasmorley65
Reviewers: , Message: Please review. Does this engraver needs an entry via ly:register-translator like the Measure_counter_engraver in the same file (scheme-engravers.scm)? Description: Let Merge_rests_engraver deal with dotted rests Compare simple rests by their duration-length, duration-log

PATCHES - Countdown for August 28th

2017-08-28 Thread James
Hello, Here is the current patch countdown list. The next countdown will be on August 31st. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5177 LilyPad for Windows' Simplified Chinese menu is broken -