Hi Carl,
Concise, comprehensible, - LGTM!
Perhaps it should be explicitly pointed out that the duration shorthand
does not work for rests.
There have been some misconceptions lately on the user list, and so I
think this detail probably deserves special attendance.
Thanks,
Torsten
https://code
Hello,
Here is the current patch countdown list. The next countdown will be on May 3rd.
A quick synopsis of all patches currently in the review process can be found
here:
http://philholmes.net/lilypond/allura/
Push:
5312 Key cancellation glyph position inconsistent - Torsten Hammerle
ht
Hi Carl
LGTM, with a couple of minor comments.
Trevor
https://codereview.appspot.com/343060043/diff/1/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):
https://codereview.appspot.com/343060043/diff/1/Documentation/learning/fundamental.itely#newco
Reviewers: Be-3, Trevor Daniels,
Message:
On 2018/04/30 11:37:09, Be-3 wrote:
Hi Carl,
Concise, comprehensible, - LGTM!
Perhaps it should be explicitly pointed out that the duration
shorthand does not
work for rests.
There have been some misconceptions lately on the user list, and so I
On 2018/04/30 12:08:20, Trevor Daniels wrote:
https://codereview.appspot.com/343060043/diff/1/Documentation/learning/fundamental.itely#newcode488
Documentation/learning/fundamental.itely:488: @end lilypond
I'd prefer \relative or nothing in this example. \absolute
has not been introduced earli
Hi Carl
Another minor nit! Otherwise looks fine.
Trevor
https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):
https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.
Thanks for the feedback, Trevor.
https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):
https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.itely#newcode495
Documentat
https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):
https://codereview.appspot.com/343060043/diff/20001/Documentation/learning/fundamental.itely#newcode495
Documentation/learning/fundamental.itely:495
Carl, you wrote 30/04/2018 18:16:05
On 4/30/18, 11:04 AM, "lilypond-devel on behalf of
tdanielsmu...@googlemail.com"
tdanielsmu...@googlemail.com> wrote:
@ref definitely should work. It may be that the heading for one
of them is "Articulation and dynamics", not "Articulations and
On 4/30/18, 11:04 AM, "lilypond-devel on behalf of
tdanielsmu...@googlemail.com"
wrote:
@ref definitely should work. It may be that the heading for one
of them is "Articulation and dynamics", not "Articulations and
dynamics" - no "s". Using @ruser bypasses the check, I thin
Hi Carl,
many thanks for your work.
Some remarks:
https://codereview.appspot.com/343060043/diff/40001/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):
https://codereview.appspot.com/343060043/diff/40001/Documentation/learning/fundamental.itely#new
Harm,
Thanks for the input. I'm not sure I agree with you on all this, but
I'm certainly open to being convinced. I've got specific replies to
your inline comments.
https://codereview.appspot.com/343060043/diff/40001/Documentation/learning/fundamental.itely
File Documentation/learning/fundame
On 2018/04/30 22:19:12, Carl wrote:
https://codereview.appspot.com/343060043/diff/40001/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):
https://codereview.appspot.com/343060043/diff/40001/Documentation/learning/fundamental.itely#newcode465
Doc
On 2018/04/30 22:55:35, thomasmorley651 wrote:
On 2018/04/30 22:19:12, Carl wrote:
> I don't think I agree that things are attached with "-" signs. For
example,
> \staccato, \mordent, \turn, \fermata, \prall, (, [. None of these
are attached
> with "-" signs, although they can have a dire
According to parser.yy:
In line 3259, a post_event is either:
1) post_event_nofinger, or
2) '-' plus a fingering
In line 3200, a post_event_nofinger is either
1) direction_less_event
2) script_dir plus a music_function
3,4 ) Lyric hyphen or lyric extender (Not relevant to this discussion).
5)
https://codereview.appspot.com/343060043/diff/40001/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):
https://codereview.appspot.com/343060043/diff/40001/Documentation/learning/fundamental.itely#newcode465
Documentation/learning/fundamental.itely:465
16 matches
Mail list logo
