Re: Issue 5490: fix for wrong clefs.varC_change (issue 361800043 by lilyp...@maltemeyn.de)

2019-03-10 Thread innnzzz6
Issue 361800043: Issue 5490: fix for wrong clefs.varC_change https://codereview.appspot.com/361800043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 5490: fix for wrong clefs.varC_change (issue 361800043 by lilyp...@maltemeyn.de)

2019-03-10 Thread innnzzz6
Issue 361800043: Issue 5490: fix for wrong clefs.varC_change https://codereview.appspot.com/361800043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add a procedure to add slashes to Beams and straight Flags (issue 562550043 by thomasmorle...@gmail.com)

2019-03-10 Thread Carl . D . Sorensen
LGTM https://codereview.appspot.com/562550043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix #687: Include MIDI swing script in default distribution (issue 572520044 by v.villen...@gmail.com)

2019-03-10 Thread v . villenave
Reviewers: thomasmorley651, Message: Thanks! I actually hadn’t reviewed Johannes’ code in detail, but you make good points. https://codereview.appspot.com/572520044/diff/574520044/ly/swing.ly File ly/swing.ly (right):

Fix #687: Include MIDI swing script in default distribution (issue 572520044 by v.villen...@gmail.com)

2019-03-10 Thread thomasmorley65
Hi Valentin, up to now I didn't test, but read the code only. Several small suggestions: https://codereview.appspot.com/572520044/diff/574520044/ly/swing.ly File ly/swing.ly (right): https://codereview.appspot.com/572520044/diff/574520044/ly/swing.ly#newcode99 ly/swing.ly:99: (fold (lambda (x

Re: Add a procedure to add slashes to Beams and straight Flags (issue 562550043 by thomasmorle...@gmail.com)

2019-03-10 Thread thomasmorley65
On 2019/03/10 17:08:33, Valentin Villenave wrote: On 2019/03/10 13:37:42, thomasmorley651 wrote: > Oversights Greetings Harm, looks good; much better than the hack I had previously suggested about #1333. However, you’re using a somewhat similar approach (although much more fine-tuned) by

Re: Add a procedure to add slashes to Beams and straight Flags (issue 562550043 by thomasmorle...@gmail.com)

2019-03-10 Thread v . villenave
On 2019/03/10 13:37:42, thomasmorley651 wrote: Oversights Greetings Harm, looks good; much better than the hack I had previously suggested about #1333. However, you’re using a somewhat similar approach (although much more fine-tuned) by overriding the stencil rather than creating an

Add a procedure to add slashes to Beams and straight Flags (issue 562550043 by thomasmorle...@gmail.com)

2019-03-10 Thread thomasmorley65
Reviewers: , Message: Please review Description: Add a procedure to add slashes to Beams and straight Flags Adds procedure slash-stencil to stencil.scm Replaces add-stroke-straight from flag-styles.scm with slash-stencil. Amends defs in grace-init.ly with slashedBeam. Amends Beam.details.

Re: 64-bit version of Lilypond?

2019-03-10 Thread Jacques Menu
Hello Elaine, I use Frescobaldi 2.20.0 quite often on my Mac, and it escaped me that 3.x.y is available on other platforms… I can contribute building it and LilyPond on Mac OS X if needed. JM > Le 9 mars 2019 à 22:08, Flaming Hakama by Elaine a > écrit : > > On Fri, Mar 8, 2019 at 4:34 PM