Am So., 7. Apr. 2019 um 19:20 Uhr schrieb Werner LEMBERG :
>
>
> > acciaccatura contains
> > \temporary \override Flag.stroke-style = #"grace"
> > reverting it at the end.
> >
> > Per default override/revert is not quoted. You may extend
> > quotedCueEventTypes by `Override´ and `Revert´ to ge
Thanks for looking at this, Keith! I've tried to make a version that
does the right thing with regard to the assertion failure. That does
not address the root cause of the problem, nor does it fix the centering
thing you pointed out. Quite lacklustre.
https://codereview.appspot.com/572550043/
On 4/6/19, James wrote:
> Here is the current patch countdown list.
Greetings James,
I suspect this (fairly minor) one has gone unnoticed:
https://sourceforge.net/p/testlilyissues/issues/5504/
It has already received a LGTM from two (in)valuable contributors, but
could you put it in the countdow
On 2019/04/06 22:06:22, Carl wrote:
However, this will require more refactoring. I don't believe we
should hold off
on this patch until we can get that part of it done better. This
patch has
lanquished long enough. IMO we should just push it as-is and get it
in the code
base.
Agreed. L
Valentin,
Always make sure that the tracker status is 'started'.
Else I won't look for it/spot it.
(git-cl updated/added trackers will change this automatically)
Regards
James
On 08/04/2019 19:15, Valentin Villenave wrote:
On 4/6/19, James wrote:
Here is the current patch countdown list.
Are we sure all the reg tests are OK (see tracker for download link)?
For example
regression/chord-name-major7.ly
This looks completely broken with this patch
https://codereview.appspot.com/568650043/
___
lilypond-devel mailing list
lilypond-devel@g
On 2019/04/08 18:47:13, lilypond-pkx wrote:
Are we sure all the reg tests are OK (see tracker for download link)?
For example
regression/chord-name-major7.ly
This looks completely broken with this patch
I had a look at the regtest-results, too. Though, I didn't check for
changed code i
On 2019/04/08 18:47:13, lilypond-pkx wrote:
Are we sure all the reg tests are OK (see tracker for download link)?
For example
regression/chord-name-major7.ly
This looks completely broken with this patch
I had a look at the regtest-results, too. Though, I didn't check for
changed code i
On 4/8/19, 1:59 PM, "thomasmorle...@gmail.com"
wrote:
On 2019/04/08 18:47:13, lilypond-pkx wrote:
> Are we sure all the reg tests are OK (see tracker for download link)?
> For example
> regression/chord-name-major7.ly
> This looks completely broken with this
> -- Forwarded message --
> From: Carl Sorensen
> To: "carl.d.soren...@gmail.com" , "
> v.villen...@gmail.com" , Carl Sorensen <
> c_soren...@byu.edu>, "pkxgnugi...@runbox.com" , "
> thomasmorle...@gmail.com" , "
> lilypond-devel@gnu.org" , "
> re...@codereview-hr.appspotmail.com"
10 matches
Mail list logo
