Re: Avoid some crashes for bad "control-points" property (issue 576610043 by d...@gnu.org)

2019-04-26 Thread David Kastrup
hanw...@gmail.com writes: > add a regression test? > > https://codereview.appspot.com/576610043/ I am not sure what the point of it would be. This kind of bug may be present elsewhere (and the regression test would not cover that) and it is not likely to get reintroduced here since this code doe

Re: Avoid some crashes for bad "control-points" property (issue 576610043 by d...@gnu.org)

2019-04-26 Thread hanwenn
add a regression test? https://codereview.appspot.com/576610043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Avoid some crashes for bad "control-points" property (issue 576610043 by d...@gnu.org)

2019-04-26 Thread benko . pal
LGTM https://codereview.appspot.com/576610043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: stack smashing detected

2019-04-26 Thread Benkő Pál
Thomas Morley ezt írta (időpont: 2019. ápr. 25., Cs, 18:57): > > > So usually your goals would be better served by > > > allowing _multiple_ cubic beziers in a row with suitable continuity of > > > derivatives (and thus some aspects of the control points) provided > > > automagically. > > > > whic

Documentation: elaborate NR `custom percussion’ section (issue 550650043 by v.villen...@gmail.com)

2019-04-26 Thread lemzwerg
LGTM, thanks! https://codereview.appspot.com/550650043/diff/548760043/Documentation/notation/percussion.itely File Documentation/notation/percussion.itely (right): https://codereview.appspot.com/550650043/diff/548760043/Documentation/notation/percussion.itely#newcode423 Documentation/notation/p

Re: Appearance of S-curves

2019-04-26 Thread David Kastrup
Simon Albrecht writes: > Hi, > > I find the second one with crossing beziers mich more pleasant, but > I'm sure the question is easily settled by looking at any good > hand-engraved example (I'm travelling right now and don't have any at > hand, sorry). I think the usual hand-engraved version wo

Re: Appearance of S-curves

2019-04-26 Thread Simon Albrecht
Hi, I find the second one with crossing beziers mich more pleasant, but I'm sure the question is easily settled by looking at any good hand-engraved example (I'm travelling right now and don't have any at hand, sorry). Best, Simon > On 26.04.2019 - 13:10, Thomas Morley wrote: > > > Hi, > > cu

Appearance of S-curves

2019-04-26 Thread Thomas Morley
Hi, currently we print beziers for slurs, ties, etc as a bezier-sandwich, where second and third control-point of the second bezier is the same amount apart from the ones from first bezier's control-points. This is fine for the all usual cases. Though, is it ok for S-curves as well? Attached an im