Hello,
Here is the current patch countdown list. The next countdown will be on
October 27th.
A quick synopsis of all patches currently in the review process can be
found here:
http://philholmes.net/lilypond/allura/
Push:
5580 Replace deprecated functions from string module - Jonas Hahnfe
Reviewers: ,
Description:
https://sourceforge.net/p/testlilyissues/issues/5587/
The new configuration option --enable-ubsan instruments compiled code
with the Undefined Behavior Sanitizer (UBSan).
GCC UBSan options are documented here:
https://gcc.gnu.org/onlinedocs/gcc-9.2.0/gcc/Instrumentatio
On 2019/10/24 19:05:49, lemzwerg wrote:
LGTM
https://codereview.appspot.com/566930043/diff/581200043/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):
https://codereview.appspot.com/566930043/diff/581200043/Documentation/contributor/sourc
LGTM
https://codereview.appspot.com/573150043/
Thanks for the corrections.
https://codereview.appspot.com/566930043/diff/551130043/Documentation/contributor/source-code.itexi
File Documentation/contributor/source-code.itexi (right):
https://codereview.appspot.com/566930043/diff/551130043/Documentation/contributor/source-code.itexi#newcode22
LGTM. Your changes are two commits, right?
https://codereview.appspot.com/575180043/diff/559180043/aclocal.m4
File aclocal.m4 (right):
https://codereview.appspot.com/575180043/diff/559180043/aclocal.m4#newcode274
aclocal.m4:274: # "print a verbose error report and exit the program"
Why quotati
LGTM
https://codereview.appspot.com/566930043/
On Thu Oct 24 22:56:44 2019, andrew.bern...@gmail.com wrote:
> See my post re this on the User list.
>
> Andrew
Sorry, I'm short on time today, I would like to reply directly to
lilypond-user, if you could let them know that, perhaps the footer or
header setting for lilypond-user was just some wh
On 2019/10/25 17:08:38, lemzwerg wrote:
LGTM. Your changes are two commits, right?
Right.
aclocal.m4:274: # "print a verbose error report and exit the program"
Why quotation marks in the comment?
Heh. I'm quoting the GCC manual without citing it.
https://codereview.appspot.com/575180043/
Thanks for this. Seeing a warning message for an optional program
bothered me, but addressing it was out of my depth.
What do you think about using "false" rather than "no" if the program is
not found? That would be more defensive because if "$(TIDY) ..." is
executed as "false ...", we can be p
"Ian Kelling via RT" writes:
> On Thu Oct 24 22:56:44 2019, andrew.bern...@gmail.com wrote:
>> See my post re this on the User list.
>>
>> Andrew
>
> Sorry, I'm short on time today, I would like to reply directly to
> lilypond-user, if you could let them know that, perhaps the footer or
> header
Reviewers: ,
Description:
https://sourceforge.net/p/testlilyissues/issues/5588/
The warning is "RGB color space not permitted on grayscale PNG" and the
solution is to strip the profile from the image.
Please review this at https://codereview.appspot.com/545100043/
Affected files (+4, -2 lines)
LGTM
https://codereview.appspot.com/545100043/diff/545110043/scripts/build/output-distance.py
File scripts/build/output-distance.py (right):
https://codereview.appspot.com/545100043/diff/545110043/scripts/build/output-distance.py#newcode100
scripts/build/output-distance.py:100: system ('convert
13 matches
Mail list logo
