Re: make check is broken (again) - patch testing seeming to taking more of my time than I like

2019-10-28 Thread Dan Eble
On Oct 28, 2019, at 05:32, Werner LEMBERG wrote: > A good test for those things IMHO is to clone the gub repository, then > saying > > make lilypond I installed Ubuntu 19.10 on a spare computer, installed some necessary packages, cloned https://github.com/gperciva/gub.git, and ran "time make -

PATCHES - Countdown for October 28th

2019-10-28 Thread James
Hello, Here is the current patch countdown list. The next countdown will be on October 30th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5584 Rehabilitate regtest workflow - Dan Eble https://sourc

Re: Issue 5588: fix color-profile warning in output-distance (issue 545100043 by nine.fierce.ball...@gmail.com)

2019-10-28 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/545100043/

Re: expected outcome of make check

2019-10-28 Thread Carl Sorensen
On 10/28/19, 1:35 PM, "lilypond-devel on behalf of Jonas Hahnfeld" wrote: Am Samstag, den 26.10.2019, 08:43 +0100 schrieb James: > 1. ./autogen --noconfigure > > 2. mkdir build > > 3. cd build > > 4 ../configure --disable-optimising > > 5. make -j7

Re: expected outcome of make check

2019-10-28 Thread James
Hello, On 28/10/2019 18:19, Jonas Hahnfeld wrote: Am Samstag, den 26.10.2019, 08:43 +0100 schrieb James: 1. ./autogen --noconfigure 2. mkdir build 3. cd build 4 ../configure --disable-optimising 5. make -j7 CPU_COUNT=7 6. make -j7 CPU_COUNT=7 test-baseline 7. make -j7 CPU_COUNT=7 check 8

expected outcome of make check

2019-10-28 Thread Jonas Hahnfeld
Am Samstag, den 26.10.2019, 08:43 +0100 schrieb James: > 1. ./autogen --noconfigure > > 2. mkdir build > > 3. cd build > > 4 ../configure --disable-optimising > > 5. make -j7 CPU_COUNT=7 > > 6. make -j7 CPU_COUNT=7 test-baseline > > 7. make -j7 CPU_COUNT=7 check > > 8. > > [...] > > It see

Re: make check is broken (again) - patch testing seeming to taking more of my time than I like

2019-10-28 Thread David Kastrup
Dan Eble writes: > On Oct 28, 2019, at 08:12, David Kastrup wrote: >> >>> I request some help to understand how I can improve my pre-commit >>> testing procedures, and where my responsibilities begin and end. >> >> Responsibilities don't end. > > Fine. When a patch is submitted for review, th

Re: Issue 5576: make output-distance less verbose by default (issue 563120043 by nine.fierce.ball...@gmail.com)

2019-10-28 Thread nine . fierce . ballads
On 2019/10/28 16:06:27, Dan Eble wrote: remove expression with new-ish syntax Never mind. I'm going to create a new review to avoid having to read through other changes committed to master since this review was current. https://codereview.appspot.com/563120043/

Issue 5576: make output-distance less verbose by default (issue 581220043 by nine.fierce.ball...@gmail.com)

2019-10-28 Thread nine . fierce . ballads
Reviewers: , https://codereview.appspot.com/581220043/diff/551140043/scripts/build/output-distance.py File scripts/build/output-distance.py (right): https://codereview.appspot.com/581220043/diff/551140043/scripts/build/output-distance.py#newcode912 scripts/build/output-distance.py:912: log_ters

Re: make check is broken (again) - patch testing seeming to taking more of my time than I like

2019-10-28 Thread Werner LEMBERG
> I will attempt to build gub to reproduce and diagnose this issue. Thanks! > If you think my time would be better spent preparing a patch that > cleanly undoes the 'share' change, I'm open to hearing it. I second Carl's opinion, namely to fix the issue rather than to circumvent the problem.

Re: make check is broken (again) - patch testing seeming to taking more of my time than I like

2019-10-28 Thread Dan Eble
On Oct 28, 2019, at 08:12, David Kastrup wrote: > >> I request some help to understand how I can improve my pre-commit >> testing procedures, and where my responsibilities begin and end. > > Responsibilities don't end. Fine. When a patch is submitted for review, there ends the opportunity to

Re: make check is broken (again) - patch testing seeming to taking more of my time than I like

2019-10-28 Thread Carl Sorensen
On 10/28/19, 7:53 AM, "lilypond-devel on behalf of Dan Eble" wrote: On Oct 28, 2019, at 05:32, Werner LEMBERG wrote: > Last OS error: No such file or directory > > because the `share' tree present in > > gub/uploads/webtest/v2.21.0-1-unpack/v2.19.83-1/ >

Re: make check is broken (again) - patch testing seeming to taking more of my time than I like

2019-10-28 Thread Dan Eble
On Oct 28, 2019, at 05:32, Werner LEMBERG wrote: > Last OS error: No such file or directory > > because the `share' tree present in > > gub/uploads/webtest/v2.21.0-1-unpack/v2.19.83-1/ > > is not created by the script in > > gub/uploads/webtest/v2.21.0-1-unpack/v2.21.0-1/ > > I seem to rem

Re: make check is broken (again) - patch testing seeming to taking more of my time than I like

2019-10-28 Thread David Kastrup
Dan Eble writes: > On Oct 27, 2019, at 14:06, Werner LEMBERG wrote: >>> I have no idea why the problem is only being discussed instead of >>> fixed, but I'll revert > > I can't speak for anyone else, but in my case, inaction was mainly due > to expecting affirmation from a more senior contributo

Re: make check is broken (again) - patch testing seeming to taking more of my time than I like

2019-10-28 Thread David Kastrup
Dan Eble writes: > In the past month, I've devoted many hours to testing my submissions, > but clearly the effort is not achieving the goal. If the goal is perfection, it is hard to achieve. > I request some help to understand how I can improve my pre-commit > testing procedures, and where my r

Re: make check is broken (again) - patch testing seeming to taking more of my time than I like

2019-10-28 Thread Werner LEMBERG
> In the past month, I've devoted many hours to testing my > submissions, but clearly the effort is not achieving the goal. Don't worry. Some of the problems are very hard to catch and only show up under certain circumstances. > I request some help to understand how I can improve my pre-commit