Re: Prepare for encoding changes in Python 3 (issue 573280043 by jonas.hahnf...@gmail.com)

2019-11-23 Thread nine . fierce . ballads
3. Open midi and musicxml files in binary mode Only decode once we are sure that the content is not compressed. If an XML file is opened as a binary file, will the treatment of platform-specific line endings become inconvenient for some people? https://codereview.appspot.com/573280043/

Prepare for encoding changes in Python 3 (issue 573280043 by jonas.hahnf...@gmail.com)

2019-11-23 Thread lemzwerg--- via Discussions on LilyPond development
LGTM, thanks! https://codereview.appspot.com/573280043/

Re: Cannot build changes.pdf anymore

2019-11-23 Thread Dan Eble
On Nov 23, 2019, at 08:06, Malte Meyn wrote: > > Yes, I wanted to save time and build only that single document. For that I > followed the CG: > http://lilypond.org/doc/v2.19/Documentation/contributor/generating-documentation#building-a-single-document > I ran these commands in my build

Re: Cannot build changes.pdf anymore

2019-11-23 Thread Malte Meyn
Am 23.11.19 um 13:59 schrieb Jonas Hahnfeld: Am Samstag, den 23.11.2019, 12:23 +0100 schrieb Malte Meyn: $ cd ~/lilypond/build/Documentation/ && touch ../../Documentation/changes.tely && time make -j5 CPU_COUNT=5 out=www out-www/changes.pdf is there a reason you're running directly in

Re: Cannot build changes.pdf anymore

2019-11-23 Thread Jonas Hahnfeld via Discussions on LilyPond development
Hi, Am Samstag, den 23.11.2019, 12:23 +0100 schrieb Malte Meyn: > Hi list, > > I used to build the changes document like this: > > $ cd ~/lilypond/build/Documentation/ && touch > ../../Documentation/changes.tely && time make -j5 CPU_COUNT=5 out=www > out-www/changes.pdf is there a reason

Re: Cannot build changes.pdf anymore

2019-11-23 Thread James
Hello Malte, On 23/11/2019 11:23, Malte Meyn wrote: Hi list, I used to build the changes document like this: $ cd ~/lilypond/build/Documentation/ && touch ../../Documentation/changes.tely && time make -j5 CPU_COUNT=5 out=www out-www/changes.pdf This doesn’t work anymore for me, even after

Re: Cannot build changes.pdf anymore

2019-11-23 Thread Malte Meyn
Am 23.11.19 um 12:23 schrieb Malte Meyn: Hi list, I used to build the changes document like this: $ cd ~/lilypond/build/Documentation/ && touch ../../Documentation/changes.tely && time make -j5 CPU_COUNT=5 out=www out-www/changes.pdf This doesn’t work anymore for me, even after a fresh

Cannot build changes.pdf anymore

2019-11-23 Thread Malte Meyn
Hi list, I used to build the changes document like this: $ cd ~/lilypond/build/Documentation/ && touch ../../Documentation/changes.tely && time make -j5 CPU_COUNT=5 out=www out-www/changes.pdf This doesn’t work anymore for me, even after a fresh $ cd ~/lilypond $ rm -rf build $

Re: add property label-alignments to OttavaBracket (issue 575330043 by lilyp...@maltemeyn.de)

2019-11-23 Thread lilypond
On 2019/11/22 12:56:00, Malte Meyn wrote: I just managed to do the same thing for VoltaBrackets but that did need some code duplication so maybe there should be a new function in some interface for that alignment … I’ll have a look at this in the next few days. For Spanners with only one

Re: git-cl patch: remove some redundant text from tracker fields

2019-11-23 Thread Phil Holmes
Done a few seconds ago. -- Phil Holmes - Original Message - From: "James" To: Sent: Saturday, November 23, 2019 9:48 AM Subject: Re: git-cl patch: remove some redundant text from tracker fields Looks like this hasn't been merged yet. On 15/11/2019 15:15, Dan Eble wrote: Please

Re: git-cl patch: remove some redundant text from tracker fields

2019-11-23 Thread James
Looks like this hasn't been merged yet. On 15/11/2019 15:15, Dan Eble wrote: Please review. This handles a couple of details I'd rather not have to remember to do when submitting the patch or fix after the fact. I've exercised these changes for the last few LilyPond patches I've uploaded.