Re: Issue 5636: fix various warnings (issue 583200043 by nine.fierce.ball...@gmail.com)

2019-12-12 Thread lemzwerg--- via Discussions on LilyPond development
LGTM, thanks! Fixing those warnings is a great job. https://codereview.appspot.com/583200043/

Re: Issue 5310: find_top_context () instead of get_global_context () (issue 565320043 by nine.fierce.ball...@gmail.com)

2019-12-12 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/565320043/

Re: Issue 5310: find_top_context () maintenance (issue 341150043 by nine.fierce.ball...@gmail.com)

2019-12-12 Thread nine . fierce . ballads
Coming back to this after a long time... I intend to abandon the pointer/reference changes and submit a new review covering just the second point: "Call find_top_context () rather than get_global_context () where the caller uses the result as a mere Context." Those interested in the

Issue 5635: show new regression-test cases (issue 577190043 by nine.fierce.ball...@gmail.com)

2019-12-12 Thread nine . fierce . ballads
Reviewers: , Description: https://sourceforge.net/p/testlilyissues/issues/5635/ DEMO: http://faithful.be/tmp/test-results/ output-distance.py generates table rows for new test cases, i.e. cases not present in the baseline. Score images and profiling results appear in full. For logs and midi,

Re: Introduce breakingRehearsalMarks for line-breaking RehearsalMarks (issue 577180043 by thomasmorle...@gmail.com)

2019-12-12 Thread thomasmorley65
Hi Dan, up to now we provide only RehearsalMark taking arbitrary text with the possibility to align it to the value taken from 'break-align-symbols. The other grobs supporting break-alignable-interface are BarNumber and MetronomeMark, even less convenient to take arbitrary text. So users have no