LGTM, thanks!
https://codereview.appspot.com/577520043/diff/555310043/python/musicexp.py
File python/musicexp.py (left):
https://codereview.appspot.com/577520043/diff/555310043/python/musicexp.py#oldcode365
python/musicexp.py:365: "nederlands": pitch_nederlands,
You are sorting the entries alpha
Lukas-Fabian Moser writes:
>> The build log talks about
>>
>> autogen.sh --noconfigure
>>
>> can you confirm that with " ./autogen.sh && make -j4" it also fails?
>
> Fwiw, I had the same compile error as David yesterday. (It had been
> quite a while since I last pulled & compiled, so I was not
Am Dienstag, den 18.02.2020, 14:19 +0100 schrieb David Kastrup:
> James <
> pkx1...@posteo.net
> > writes:
> > Actually if you look on the tracker you'll see that I wrote
> >
> > 'Passes make, make test-baseline, and a full make doc.'
> >
> > This is probably my fault misunderstanding what can an
On Wed, Feb 19, 2020 at 12:51 AM David Kastrup wrote:
>
> >> Can you provide me with some recipe to reproduce the problem? Can you
> tell
> >> me what distribution you use? I could use Docker to recreate your setup.
> >
> > Just current Ubuntu eoan.
>
> The following patch makes the commit you pu
Le mer. 19 févr. 2020 à 09:08, David Kastrup a écrit :
Color me curious: why would you try building staging? The whole point
> of the staging system was to avoid breakage for developers. Only patchy
> processes are supposed to care about staging.
>
Master didn't compile, and I tried staging ne
Jonas Hahnfeld writes:
> Am Dienstag, den 18.02.2020, 14:19 +0100 schrieb David Kastrup:
>>
>> The procedure for a patch would be
>>
>> git apply --index .diff
>> ./autogen.sh --noconf
>> cd build
>> ../configure --enable-checking # and/or other desired options
>> make clean test-clean doc
Lukas-Fabian Moser writes:
> Le mer. 19 févr. 2020 à 09:08, David Kastrup a écrit :
>
> Color me curious: why would you try building staging? The whole point
>> of the staging system was to avoid breakage for developers. Only patchy
>> processes are supposed to care about staging.
>>
>
> Maste
Am Mittwoch, den 19.02.2020, 09:34 +0100 schrieb David Kastrup:
> Jonas Hahnfeld <
> hah...@hahnjo.de
> > writes:
>
> > Am Dienstag, den 18.02.2020, 14:19 +0100 schrieb David Kastrup:
> > > The procedure for a patch would be
> > >
> > > git apply --index .diff
> > > ./autogen.sh --noconf
> >
Jonas Hahnfeld writes:
> Am Mittwoch, den 19.02.2020, 09:34 +0100 schrieb David Kastrup:
>> Jonas Hahnfeld <
>> hah...@hahnjo.de
>> > writes:
>>
>> > Am Dienstag, den 18.02.2020, 14:19 +0100 schrieb David Kastrup:
>> > > The procedure for a patch would be
>> > >
>> > > git apply --index .di
On Wed, Feb 19, 2020 at 10:03 AM David Kastrup wrote:
>
> > So the dependency isn't correctly satisfied and we would always run it
> > from then on, effectively slowing down our build system. And that is
> > why I don't want to deal with this kind of issues - this should come
> > with the build
On Wed, Feb 19, 2020 at 9:19 AM Han-Wen Nienhuys wrote:
>
>> +// Necessary for supporting pango_context_new() and
>> +// pango_context_set_font_map() in Pango < 1.22
>> +#define PANGO_ENABLE_BACKEND
>> +
>>
>
> ..
> I'm preparing a docker image for my lilypond-ci scripts that lets me check
> for
Reviewers: dak,
Message:
commit a7db98fdf7003206147f0b0e7ba77c53db0e2bbd
Author: Han-Wen Nienhuys
Date: Tue Feb 11 09:00:07 2020 +0100
Move include guard for fluid.hh
Description:
Move include guard for fluid.hh
Please review this at https://codereview.appspot.com/565640043/
Affected
commit 1edb8b3c857fa9c993164123e6f707cad5afb07b
Author: Han-Wen Nienhuys
Date: Thu Feb 13 15:07:25 2020 +0100
Update web content
https://codereview.appspot.com/559470043/
commit c3cb10296708a2efcdac03d02507c9b55e3aa42c
Author: Han-Wen Nienhuys
Date: Mon Feb 10 22:12:41 2020 +0100
engraver: continue when trying to create non-existent Grob
https://sourceforge.net/p/testlilyissues/issues/5748
http://codereview.appspot.com/547620043
https://codere
commit 7cf2dd486822a301ae36928790cfcd81154be449
Author: Han-Wen Nienhuys
Date: Thu Feb 13 11:28:14 2020 +0100
Remove unused ly_scm_hash
https://sourceforge.net/p/testlilyissues/issues/5755
http://codereview.appspot.com/569340043
https://codereview.appspot.com/569340043/
commit 73a39333690293208b969d1d8d656f5837467e1c
Author: Han-Wen Nienhuys
Date: Thu Feb 13 09:13:02 2020 +0100
Store Source_file data in std::string
https://codereview.appspot.com/579310043/
commit 05436545bbfc905bd72eff258fb6583591ebd3c3
Author: Han-Wen Nienhuys
Date: Sat Feb 15 13:22:59 2020 +0100
Fix portuguese in input/regression/utf-8.ly
https://sourceforge.net/p/testlilyissues/issues/5765
http://codereview.appspot.com/571640044
https://codereview.appspot.c
Reviewers: ,
Message:
commit 47f3fe73176d876bd87fa787b76e5d97f315c613
Author: Han-Wen Nienhuys
Date: Fri Feb 14 23:52:44 2020 +0100
Remove log-clean target
Description:
Remove log-clean target
In particular, remove it as a subtarget of "make distclean". This
helps the Docker CI sc
commit e3be140a8141f0236cd489cd97e7fcf735653a0b
Author: Han-Wen Nienhuys
Date: Mon Feb 10 22:10:35 2020 +0100
input/regression/multi-measure-rest-reminder: a demo of user-defined
grobs
https://codereview.appspot.com/557380044/
LGTM
https://codereview.appspot.com/547670044/
abandoning; implemented as user defined reminder instead
https://codereview.appspot.com/553400043/
LGTM
https://codereview.appspot.com/557410043/
please close issue.
commit c066a53f9e3a4809283ba2934a2e8f1e6c44211b
Author: David Kastrup
Date: Tue Feb 4 22:02:20 2020 +0100
Issue 5735: Rewrite define-session and define-session-public macros
https://codereview.appspot.com/549510043/
this now passes tests, and is ready for submission. Anyone for a review?
https://codereview.appspot.com/557330043/
Han-Wen Nienhuys writes:
> On Wed, Feb 19, 2020 at 10:03 AM David Kastrup wrote:
>
>>
>> > So the dependency isn't correctly satisfied and we would always run it
>> > from then on, effectively slowing down our build system. And that is
>> > why I don't want to deal with this kind of issues - th
Han-Wen Nienhuys writes:
> On Wed, Feb 19, 2020 at 9:19 AM Han-Wen Nienhuys wrote:
>
>>
>>> +// Necessary for supporting pango_context_new() and
>>> +// pango_context_set_font_map() in Pango < 1.22
>>> +#define PANGO_ENABLE_BACKEND
>>> +
>>>
>>
>> ..
>
>> I'm preparing a docker image for my lily
On Wed, Feb 19, 2020 at 11:06 AM David Kastrup wrote:
> Han-Wen Nienhuys writes:
>
> > On Wed, Feb 19, 2020 at 10:03 AM David Kastrup wrote:
> >
> >>
> >> > So the dependency isn't correctly satisfied and we would always run it
> >> > from then on, effectively slowing down our build system. An
Han-Wen Nienhuys writes:
>> > I think it's easier if we give up on intelligence here, and just
>> > recommend ccache.
>>
>> That does not seem like much of a help for the problem case at hand.
>
>
> Autoconf tries to leave the config.h alone, using content based checks.
>
> I assume it does this
Can anybody fix this typo in the website?
http://lilypond.org/productions.html
/opera series/opera seria/
See https://en.wikipedia.org/wiki/Opera_seria
It was reported by Luca Rossetto.
He suggests the following wording:
Luca Rossetto Casel, for his Ph.D. thesis, created a critical edition
of
David Kastrup writes:
> Han-Wen Nienhuys writes:
>
>> On Wed, Feb 19, 2020 at 9:19 AM Han-Wen Nienhuys wrote:
>>
>>>
+// Necessary for supporting pango_context_new() and
+// pango_context_set_font_map() in Pango < 1.22
+#define PANGO_ENABLE_BACKEND
+
>>>
>>> ..
>>
>>> I
Reviewers: ,
Message:
Removing this suggestion from the GSoC page
is uncontroversial, I will push after successful tests.
Description:
Remove LO extension from GSoC ideas list
Please review this at https://codereview.appspot.com/569380043/
Affected files (+0, -27 lines):
M Documentation/inclu
Reviewers: ,
Message:
This is not as uncontroversial as removing an entire
section. However, assuming the tests pass I may consider
not waiting for the whole countdown process, if GNU
should be selected for the GSoC program.
(In that case I'd assume people will mainly look at
the GSoC page at the
LGTM
https://codereview.appspot.com/571690043/
Hello and sorry I am late to the table on this - been a busy week for me.
On 19/02/2020 08:10, Jonas Hahnfeld wrote:
Am Dienstag, den 18.02.2020, 14:19 +0100 schrieb David Kastrup:
James <
pkx1...@posteo.net
writes:
Actually if you look on the tracker you'll see that I wrote
'Passes make, mak
pkx1...@posteo.net writes:
> Hello and sorry I am late to the table on this - been a busy week for me.
>
> On 19/02/2020 08:10, Jonas Hahnfeld wrote:
>> Am Dienstag, den 18.02.2020, 14:19 +0100 schrieb David Kastrup:
>>> James <
>>> pkx1...@posteo.net
writes:
Actually if you look on the
Hello,
Here is the current patch countdown list. The next countdown will be on
February 22nd.
A quick synopsis of all patches currently in the review process can be
found here:
http://philholmes.net/lilypond/allura/
***
Push:
5770 Generate dependency files with Clang - Jonas Hahnfe
Thanks for the ping, it's been a long time! Sadly, I haven't used
lilypond for years. I tried to update my patch, but I cannot spend too
much time on it.
I see that my change to engraver.cc is no longer needed, as there is a
check there that was missing back at the time. The change to
engraver-sche
37 matches
Mail list logo