Some more nits :-)
https://codereview.appspot.com/565750043/diff/557610044/Documentation/music-glossary.tely
File Documentation/music-glossary.tely (right):
https://codereview.appspot.com/565750043/diff/557610044/Documentation/music-glossary.tely#newcode415
Documentation/music-glossary.tely:415:
On 2020/03/11 02:30:04, Dan Eble wrote:
> How about calling it a gradual-vowel-change-event? Come
> to think of it, is this only for vowels, or would it be appropriate to
use it
> for, say, sh -> ss?
Gould talks specifically about vowels, but I don't see any reason why it
shouldn't apply to sh->s
El 11/3/20 a las 3:30, nine.fierce.ball...@gmail.com escribió:
I know some people hate talking about names, but can we talk about this
one? Think of the kinds of events that a "transition event" might
properly refer to: pretty much any. The essence of this transition is
that it is gradual rathe
> Gould talks specifically about vowels, but I don't see
> any reason why it shouldn't apply to sh->ss, or even
> from vowel to closed mouth. How about
> gradual-syllable-change-event?
Mhmm, what about simply `vowel-transition-event`? IMHO it's not
necessary to invent new names.
https://coderev
https://codereview.appspot.com/581770043/diff/563700043/scripts/build/GNUmakefile
File scripts/build/GNUmakefile (right):
https://codereview.appspot.com/581770043/diff/563700043/scripts/build/GNUmakefile#newcode19
scripts/build/GNUmakefile:19: $(PYTHON) output-distance.py --test
This is wrong in
On Wed, Mar 11, 2020 at 11:16 AM wrote:
>
>
> https://codereview.appspot.com/581770043/diff/563700043/scripts/build/GNUmakefile
> File scripts/build/GNUmakefile (right):
>
> https://codereview.appspot.com/581770043/diff/563700043/scripts/build/GNUmakefile#newcode19
> scripts/build/GNUmakefile:19:
Reviewers: lemzwerg, Be-3, dak, thomasmorley651,
Message:
I've added changes.tely entry in Issue 5833.
This Issue 5828 became "push", but I would like to push this and Issue
5833 together.
If only this issue is pushed without Issue 5833, LilyPond for Windows
cannot handle some filenames.
I wait
Looks mostly good to me, but I don't understand the change for .
I'd propose to push only the changes required to restore 'make check'
because it's blocking James from testing patches.
https://codereview.appspot.com/563730043/diff/577660046/scripts/build/output-distance.py
File scripts/build/outp
https://codereview.appspot.com/557580043/diff/577630043/configure.ac
File configure.ac (right):
https://codereview.appspot.com/557580043/diff/577630043/configure.ac#newcode195
configure.ac:195: save_CPPFLAGS="$CXXFLAGS"
Took me some time to find this two-character typo :-( fixed in staging
with
> configure.ac:195: save_CPPFLAGS="$CXXFLAGS"
> Took me some time to find this two-character typo :-(
> fixed in staging with commit 7fddbc0ff1
Thanks a lot!
https://codereview.appspot.com/557580043/
We got to this topic a few times now, so here's a proper thread about
it. As the title suggests, I've been working on a new way to build
redistributable LilyPond binaries. Right now we are using GUB for this
task (see CG and https://github.com/gperciva/gub).
This is _not_ (yet) a proposal to switch
Am Freitag, den 07.02.2020, 17:16 +0100 schrieb Han-Wen Nienhuys:
> On Fri, Feb 7, 2020 at 5:09 PM Jonas Hahnfeld wrote:
> > Am Freitag, den 07.02.2020, 12:09 +0100 schrieb Han-Wen Nienhuys:
> > > [RFC] Gerrit for LilyPond
> > >
> > > Right now, LilyPond's source code is hosted on Savannah [1], o
On Wed, Mar 11, 2020 at 10:56 AM Jonas Hahnfeld wrote:
> Please let me know if something doesn't work at all
That sounds like an interesting project. I tested the Windows version,
and it works. I got a PDF from compiling { c' } as a hello-world test.
Now, is this supposed to be a 64-bit applicat
Folks--
I've just published 64-bit Mac builds of 2.20 at
https://bintray.com/marnen/lilypond-darwin-64/lilypond-2.20.0 . Enjoy, and
please let me know if you run into any issues: it appears to work, but I
haven't tested it exhaustively.
Best,
--
Marnen Laibow-Koser
mar...@marnen.org
http://www.
On Wed, Mar 11, 2020 at 5:09 PM Jonas Hahnfeld wrote:
> > > > Right now, LilyPond's source code is hosted on Savannah [1], our issues
> > > > are tracked on SourceForge [2] and we review patches on Rietveld [3].
> > > > There is no synchronization between the systems and a contributor is
> > > > r
Am Mittwoch, den 11.03.2020, 11:38 -0500 schrieb Karlin High:
> On Wed, Mar 11, 2020 at 10:56 AM Jonas Hahnfeld <
> hah...@hahnjo.de
> > wrote:
> > Please let me know if something doesn't work at all
>
> That sounds like an interesting project. I tested the Windows version,
> and it works. I got a
Am Mittwoch, den 11.03.2020, 18:55 +0100 schrieb Han-Wen Nienhuys:
> On Wed, Mar 11, 2020 at 5:09 PM Jonas Hahnfeld <
> hah...@hahnjo.de
> > wrote:
> > > > > Right now, LilyPond's source code is hosted on Savannah [1], our
> > > > > issues
> > > > > are tracked on SourceForge [2] and we review pat
On Wed, Mar 11, 2020 at 1:19 PM Jonas Hahnfeld via Discussions on
LilyPond development wrote:
>
> Am Mittwoch, den 11.03.2020, 18:55 +0100 schrieb Han-Wen Nienhuys:
> > Gerrit itself does not have an authentication service. See
> > https://gerrit-review.googlesource.com/Documentation/config-gerrit
On 2020/03/11 12:15:54, hahnjo wrote:
> Looks mostly good to me, but I don't understand the change for .
I'd
> propose to push only the changes required to restore 'make check'
because it's
> blocking James from testing patches.
>
>
https://codereview.appspot.com/563730043/diff/577660046/scripts/b
Karlin High writes:
> On Wed, Mar 11, 2020 at 1:19 PM Jonas Hahnfeld via Discussions on
> LilyPond development wrote:
>>
>> Am Mittwoch, den 11.03.2020, 18:55 +0100 schrieb Han-Wen Nienhuys:
>> > Gerrit itself does not have an authentication service. See
>> > https://gerrit-review.googlesource.c
On 3/11/2020 3:04 PM, David Kastrup wrote:
Rietveld takes OAuth if I understand correctly. While I don't really
know whether that is "sufficiently neutral and uncontroversial", it is
something we have depended on for a long time.
So while it is always good to improve, it doesn't sound like it s
Karlin High writes:
> On 3/11/2020 3:04 PM, David Kastrup wrote:
>> Rietveld takes OAuth if I understand correctly. While I don't really
>> know whether that is "sufficiently neutral and uncontroversial", it is
>> something we have depended on for a long time.
>> So while it is always good to im
LGTM
(It might be a good idea to suppress the output of the test run - I was
seriously confused that output-distance was outputting differences
before even running the regression tests. But that's for a future
change.)
https://codereview.appspot.com/563730043/
going to fast-track this so the testing can continue.
https://codereview.appspot.com/563730043/
I am not particularly surprised, to be honest: it did seem like the
website would employ something other than the online-root/offline-root
targets in the normal Stepmake build procedure.
The sized were inaccurate anyway. I'll read up in the CG to see whether
I can figure out just what scripts a
hanw...@gmail.com writes:
> going to fast-track this so the testing can continue.
>
> https://codereview.appspot.com/563730043/
Patchy refuses. Staging is blocked. Since there is no point in
admitting a patch that will stop master from building, I am removing
from staging. I will retry to make
Easiest fix is probably to change disable the test for
output-distance, by backing out the change GNUmakefile.in
I'm curious about the exact procedure for building here. I've tested
this and previous patch in various configurations.
On Thu, Mar 12, 2020 at 12:49 AM David Kastrup wrote:
>
> han
27 matches
Mail list logo