Re: Running fixcc.py

On Mar 22, 2020, at 17:04, David Kastrup wrote: > > Dan Eble writes: > >> Did you use astyle 2.04 or another version? I built 2.04 from source ... > 3.1. I am afraid that I may have updated my system since the review, ... > So where should we go from here? As far as I'm concerned, we could j

Re: definitions in macros?

Han-Wen Nienhuys writes: > Hi there, > > in my quest to get lilypond working with GUILE 2+, I've hit another > stumbling block. > > In order to make compilation with GUILE 2+ working, we have to move > away from runtime symbol definition (ie. module-define! calls). > > In the code below, it looks

Re: Running fixcc.py

Dan Eble writes: > On Mar 21, 2020, at 11:26, David Kastrup wrote: >> it got a bit lost in other things, but I think I would want to run >> fixcc.py right now, reformatting the C++ stuff (it doesn't help with the >> conventions for template arguments but there are comparatively few of >> those).

Re: Running fixcc.py

On Mar 21, 2020, at 11:26, David Kastrup wrote: > it got a bit lost in other things, but I think I would want to run > fixcc.py right now, reformatting the C++ stuff (it doesn't help with the > conventions for template arguments but there are comparatively few of > those). Did you use astyle 2.04

definitions in macros?

Hi there, in my quest to get lilypond working with GUILE 2+, I've hit another stumbling block. In order to make compilation with GUILE 2+ working, we have to move away from runtime symbol definition (ie. module-define! calls). In the code below, it looks like only one of the two definitions in t

Re: \compressFullBarRests should be renamed (issue 553750044 by v.villen...@gmail.com)

Thanks for picking this up and taking it over the finishing line, Valentin. LGTM apart from a couple of nits. Trevor https://codereview.appspot.com/553750044/diff/561590043/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): https://codereview.appspot.com/5537500

Re: Remove trailing whitespace {python,scm,lily,scripts}. (issue 547810043 by hanw...@gmail.com)

On 2020/03/21 19:18:26, hanwenn wrote: > On Sat, Mar 21, 2020 at 8:10 PM wrote: > > > > On 2020/03/21 19:09:01, hanwenn wrote: > > > You suggested it yourself? I removed the lily/ and scm/ changes to > > > avoid conflicts. > > > > huh!? "maybe we can combine this w