Re: Define Scheme markups using define-public (issue 577720043 by hanw...@gmail.com)

2020-03-30 Thread dak
On 2020/03/29 14:35:43, hanwenn wrote: > On Sun, Mar 29, 2020 at 4:12 PM wrote: > > > > On 2020/03/29 13:55:41, hanwenn wrote: > > > On 2020/03/29 13:52:48, hanwenn wrote: > > > > retain existing > > > > > > how's this? This leaves things backward compatible. > > > > Ugly and

OT: maillist changes width, messes lines

2020-03-30 Thread Francisco Vila
At some point in the email path from sender to recipients, our list incorrectly word wraps some long lines. See attachment. It's in the actual email code, too. I was pretty much ignoring it until I couldn't help reading "Anything and rather sake uses from" which clearly tends to distort the

Re: Anything missing for 2.21.0?

2020-03-30 Thread Valentin Villenave
On 3/29/20, Dan Eble wrote: >str = re.sub (r"\\(compress|expand)FullBarRests)", r"\\\1EmptyMeasures", That’s on me; sorry about that. https://codereview.appspot.com/553750044/diff/561590043/python/convertrules.py I was convinced it had successfully gone through the docs and regtests, which is

Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-03-30 Thread lemzwerg--- via Discussions on LilyPond development
Nice idea, thanks. Some nits and questions. https://codereview.appspot.com/557640051/diff/571940043/Documentation/notation/text.itely File Documentation/notation/text.itely (right): https://codereview.appspot.com/557640051/diff/571940043/Documentation/notation/text.itely#newcode1552 Documentati

Re: OT: maillist changes width, messes lines

2020-03-30 Thread Jean-Charles Malahieude
Le 30/03/2020 à 17:31, Francisco Vila a écrit : At some point in the email path from sender to recipients, our list incorrectly word wraps some long lines. See attachment. It's in the actual email code, too. I was pretty much ignoring it until I couldn't help reading   "Anything and rather s

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-03-30 Thread v . villenave
Reviewers: lemzwerg, Message: On 2020/03/30 16:06:08, lemzwerg wrote: > Is it guaranteed that we can create this directory? What about srcdir != > builddir? Yes. It’s a (tmpnam) name, located in /tmp or $TMPDIR or whatever: https://www.gnu.org/software/guile/manual/html_node/File-System.html#in

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-03-30 Thread thomasmorley65
On 2020/03/30 18:29:37, Valentin Villenave wrote: > On 2020/03/30 16:06:08, lemzwerg wrote: > > Is it guaranteed that we can create this directory? What about srcdir != > > builddir? > > Yes. It’s a (tmpnam) name, located in /tmp or $TMPDIR or whatever: > https://www.gnu.org/software/guile/manua

Re: GSoC Proposal - SVG Export

2020-03-30 Thread Étienne Beaulé
To re-open this thread: Sorry if I wasn’t clear enough about LY’s export formats. I thought I was clear with the distinction I drew between my terminology of « application » and « program » from my first message. Sadly Ghostscript has deprecated its SVG capabilities. I was sadly unavailable la

Re: Issue #1204: Document, and add regtest for, external fonts. (issue 557640051 by v.villen...@gmail.com)

2020-03-30 Thread v . villenave
On 2020/03/30 18:56:27, thomasmorley651 wrote: > tmpnam is deprecated in guile-3.0.2 (sigh) Nice catch! > Why introducing it, we would need to move away from it later anyway? Well, I *would* have used mkstemp, but I need to create a directory (rather than a file), and there’s no mkdtemp in Guile

Remove all uses of markup macro from scm/*.scm (issue 575930043 by d...@gnu.org)

2020-03-30 Thread thomasmorley65
patch itself LGTM Ofcourse there are other folders than scm/*.scm, like snippets, snippets/new, ly-examples, Documentation... Follow up planned? https://codereview.appspot.com/575930043/

Re: Remove all uses of markup macro from scm/*.scm (issue 575930043 by d...@gnu.org)

2020-03-30 Thread hanwenn
thanks! Harm, the changes only need to be done in .scm, because it's only those files that we'd be precompiling https://codereview.appspot.com/575930043/diff/561620044/scm/time-signature.scm File scm/time-signature.scm (right): https://codereview.appspot.com/575930043/diff/561620044/scm/time-si

Re: Remove all uses of markup macro from scm/*.scm (issue 575930043 by d...@gnu.org)

2020-03-30 Thread hanwenn
LGTM https://codereview.appspot.com/575930043/

Re: Define Scheme markups using define-public (issue 577720043 by hanw...@gmail.com)

2020-03-30 Thread hanwenn
On 2020/03/30 12:20:17, dak wrote: > On 2020/03/29 14:35:43, hanwenn wrote: > > On Sun, Mar 29, 2020 at 4:12 PM wrote: > > > > > > On 2020/03/29 13:55:41, hanwenn wrote: > > > > On 2020/03/29 13:52:48, hanwenn wrote: > > > > > retain existing > > > > > > > > how's this? This l

Re: Remove all uses of markup macro from scm/*.scm (issue 575930043 by d...@gnu.org)

2020-03-30 Thread dak
https://codereview.appspot.com/575930043/diff/561620044/scm/time-signature.scm File scm/time-signature.scm (right): https://codereview.appspot.com/575930043/diff/561620044/scm/time-signature.scm#newcode23 scm/time-signature.scm:23: (mup (if (procedure? proc) On 2020/03/30 21:15:15, hanwenn wrote

Re: Remove references to test-output-distance.ly. (issue 549780044 by hanw...@gmail.com)

2020-03-30 Thread Han-Wen Nienhuys
On Sun, Mar 29, 2020 at 11:45 PM Dan Eble wrote: > > On Mar 29, 2020, at 17:39, Han-Wen Nienhuys wrote: > >> test-output-distance was removed on the grounds that the self-test > >> serves the same purpose, but I don't see how it does. > > > > Could you elaborate? What failure scenario are you wor

Re: Remove references to test-output-distance.ly. (issue 549780044 by hanw...@gmail.com)

2020-03-30 Thread Dan Eble
On Mar 30, 2020, at 17:34, Han-Wen Nienhuys wrote: > > On Sun, Mar 29, 2020 at 11:45 PM Dan Eble wrote: >> >> On Mar 29, 2020, at 17:39, Han-Wen Nienhuys wrote: test-output-distance was removed on the grounds that the self-test serves the same purpose, but I don't see how it does. >>

PATCHES - Countdown for March 31st

2020-03-30 Thread pkx166h
Hello, Here is the current patch countdown list. The next countdown will be on April 2nd A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ *** Push: 5867 Web: add 64-bit Mac download links - James Lowe https: