Re: Copy alist instead of deep copy on Grob clone (issue 561640045 by hanw...@gmail.com)

On 2020/04/13 21:01:11, hanwenn wrote: > it's hard to say if this makes a measurable difference: > > [...] So then ... why do it at all? From a code perspective, a deep copy looks saner in terms of "encapsulation" (one principle of object-oriented programming). If there is no provable gain, I'm f

Re: Copy alist instead of deep copy on Grob clone (issue 561640045 by hanw...@gmail.com)

On 2020/04/14 07:00:56, hahnjo wrote: > On 2020/04/13 21:01:11, hanwenn wrote: > > it's hard to say if this makes a measurable difference: > > > > [...] > > So then ... why do it at all? From a code perspective, a deep copy looks saner > in terms of "encapsulation" (one principle of object-orient

Re: Use vectors rather than lists for skylines. (issue 583750043 by hanw...@gmail.com)

Sure. On Tue, Apr 14, 2020 at 8:57 AM wrote: > > On 2020/04/13 18:51:22, hanwenn wrote: > > This is likely a timing fluke due to thermal throttling too. > > > > Hold off on reviewing. > > Shall we put the patch on Needs_work then? > > https://codereview.appspot.com/583750043/ -- Han-Wen Nienh

Re: Reimplement Scheme_hash_table using linear probing. (issue 559790043 by hanw...@gmail.com)

Sure. On Tue, Apr 14, 2020 at 8:57 AM wrote: > > On 2020/04/12 11:05:14, hanwenn wrote: > > this should probably not be merged, given the inability to demonstrate > speed > > savings. But I'm uploading the latest version to not leave bugs in > the public > > record. > > Shall we put the patch on

Re: Copy alist instead of deep copy on Grob clone (issue 561640045 by hanw...@gmail.com)

On 2020/04/14 07:24:10, hanwenn wrote: > On 2020/04/14 07:00:56, hahnjo wrote: > > On 2020/04/13 21:01:11, hanwenn wrote: > > > it's hard to say if this makes a measurable difference: > > > > > > [...] > > > > So then ... why do it at all? From a code perspective, a deep copy looks saner > > in t

Re: Resolving standoffs (was: Naming question for get_property, set_property)

On Tue, Apr 14, 2020 at 12:13 AM Carl Sorensen wrote: > 1) David has an excellent track record of making challenging things easier to > do by thinking carefully about the implications of potentially arbitrary > syntax. For example, the parser has been made more robust, and the scheme > interac

Re: Resolving standoffs (was: Naming question for get_property, set_property)

On Tue, Apr 14, 2020 at 11:32 AM Han-Wen Nienhuys wrote: > 2. all other pending changes become invalidated and need to be > reorganized, including historical changes. In particular, this precludes cherry-picking bugfixes from master into stable. -- Han-Wen Nienhuys - hanw...@gmail.com - http:/

Re: Copy alist instead of deep copy on Grob clone (issue 561640045 by hanw...@gmail.com)

On Tue, Apr 14, 2020 at 9:28 AM wrote: > > On 2020/04/14 07:24:10, hanwenn wrote: > > On 2020/04/14 07:00:56, hahnjo wrote: > > > On 2020/04/13 21:01:11, hanwenn wrote: > > > > it's hard to say if this makes a measurable difference: > > > > > > > > [...] > > > > > > So then ... why do it at all? F

Re: Resolving standoffs (was: Naming question for get_property, set_property)

On Tue, Apr 14, 2020 at 11:32 AM Han-Wen Nienhuys wrote: > I think your assessment of the patch and my comments misses the mark. > > Here is the situation as it stands: > > Currently, if you run a profile of processing any large file, > Grob:internal_get_property is one of the top functions. In th

Re: Copy alist instead of deep copy on Grob clone (issue 561640045 by hanw...@gmail.com)

On 2020/04/14 09:39:18, hanwenn wrote: > On Tue, Apr 14, 2020 at 9:28 AM wrote: > > > > On 2020/04/14 07:24:10, hanwenn wrote: > > > On 2020/04/14 07:00:56, hahnjo wrote: > > > > On 2020/04/13 21:01:11, hanwenn wrote: > > > > > it's hard to say if this makes a meas

Re: stale git branches

Am Samstag, den 11.04.2020, 15:33 +0200 schrieb David Kastrup: > Jonas Hahnfeld writes: > > > Hi all, > > > > following removal of dev/translation-* branches, I took a closer look > > at stale branches. I think it would make sense to keep unscoped > > branches (outside of dev/user/) to a minimum

Re: Resolving standoffs

Han-Wen Nienhuys writes: > In short, David is asking me to set aside my well-founded skepticism > on his plans, so get_property can decltype to get at the type of the > receiver, ie. > > #define get_property(receiver, name) \ > { something something (decltype)(*receiver_type) } > > I am co

Re: Resolving standoffs

Han-Wen Nienhuys writes: > On Tue, Apr 14, 2020 at 11:32 AM Han-Wen Nienhuys wrote: > >> 2. all other pending changes become invalidated and need to be >> reorganized, including historical changes. > > In particular, this precludes cherry-picking bugfixes from master into > stable. Without edit

Re: stale git branches

Jonas Hahnfeld writes: > Am Samstag, den 11.04.2020, 15:33 +0200 schrieb David Kastrup: >> Jonas Hahnfeld writes: >> >> > Hi all, >> > >> > following removal of dev/translation-* branches, I took a closer look >> > at stale branches. I think it would make sense to keep unscoped >> > branches (

Re: Rewrite Mutable_properties based on vector (issue 575990043 by hanw...@gmail.com)

On 2020/04/13 17:43:17, hanwenn wrote: > > Actually, it looks like I have been measuring noise. Thermal throttling? > > It looks like I can get reproducible timings if I downclock the CPU from 2.6 to > 2.0Ghz Put the following line in the config /etc/modprobe.d/acpi.conf:options thinkpad-acpi

Re: Copy alist instead of deep copy on Grob clone (issue 561640045 by hanw...@gmail.com)

On 2020/04/14 10:22:01, hahnjo wrote: > On 2020/04/14 09:39:18, hanwenn wrote: > > On Tue, Apr 14, 2020 at 9:28 AM wrote: > > > > > > On 2020/04/14 07:24:10, hanwenn wrote: > > > > On 2020/04/14 07:00:56, hahnjo wrote: > > > > > On 2020/04/13 21:01:11, hanwenn wrot

Re: Copy alist instead of deep copy on Grob clone (issue 561640045 by hanw...@gmail.com)

On 2020/04/14 19:14:29, hanwenn wrote: > On 2020/04/14 10:22:01, hahnjo wrote: > > On 2020/04/14 09:39:18, hanwenn wrote: > > > it reads from the immutable_list_ if there is no override in the > > > mutable property list. > > > > Ack, that's also what the two names suggested. The code in Grob's co

PATCHES - Countdown for April 15th

Hello, Here is the current patch countdown list. The next countdown will be on April 17th A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ *** Push: 5889 Remove ly:grob-properties - Han-Wen Nienhuys https://