PATCHES - Countdown to April 24th

2022-04-22 Thread Colin Campbell
Here is the current countdown list. The next countdown will be on April 24th. A list of all merge requests can be found here: https://gitlab.com/lilypond/lilypond/-/merge_requests?sort=label_priority Push: !1317 Fix and improve formatting of Scheme signatures in IR - Jean Abou Samra ht

Re: C++ question on wrapper API for setting Guile fluids

2022-04-22 Thread Dan Eble
On Apr 22, 2022, at 05:39, Jean Abou Samra wrote: > > You both made a good point. My conclusion is that I should stick to > > { > Local_assumption la (Lily::prebreak_estimate, SCM_BOOL_T); > ... > } > > where the constructor does everything, included scm_dynwind_begin () > and scm_d

Re: Missing dependencies in doc build after addition of PDF syntax highlighting?

2022-04-22 Thread Jean Abou Samra
Le 21/04/2022 à 09:31, Jonas Hahnfeld a écrit : This says "to rebuild only 'contributor.pdf'", which should still work fine in an incremental build, no? Granted. The first of the two occurrences on that page does not imply that the full documentation build should be done first, though. Jean

Re: C++ question on wrapper API for setting Guile fluids

2022-04-22 Thread David Kastrup
Jean Abou Samra writes: > Re call/cc: I would actually like to use > static_cast (0) > and not SCM_F_WIND_EXPLICITLY. I have no idea whether the stuff I write > is going to interact gracefully with rewinding the stack via continuations, > and I honestly don't want to wonder.We're using C++ (on co

Re: C++ question on wrapper API for setting Guile fluids

2022-04-22 Thread Jean Abou Samra
Le 22/04/2022 à 09:52, Luca Fascione a écrit : [snipped] Where the problem is that dwc.free(p) is actually effectively acting as if it was dwc2.free(p); because the API doesn't pass around the context like the C++ wrappers appear to do, rather it statefully "just goes for it". This is a design

Re: C++ question on wrapper API for setting Guile fluids

2022-04-22 Thread Luca Fascione
On Thu, Apr 21, 2022 at 11:46 PM Jean Abou Samra wrote: > Well, the C++ and Scheme interfaces can feel different and idiomatic > in their respective languages as long as they share the same > underlying implementation. > I think this is a super important goal. In fact, I'd upgrade 'can' to 'shou