Re: Replacing fixcc.py with clang-format?

2022-09-06 Thread Jean Abou Samra
Yay for grammar. Le 06/09/2022 à 22:07, Jean Abou Samra a écrit : (The main difference between clang-format 10 and 14 seems to be that clang-format 14 fixes places where the return type of a function is not on its own lines, line which is a good changes. change

Re: Replacing fixcc.py with clang-format?

2022-09-06 Thread Jean Abou Samra
Le 06/09/2022 à 23:07, Dan Eble a écrit : On Sep 6, 2022, at 12:46, Jean Abou Samra wrote: I would like to propose moving to clang-format as the canonical formatting tool and removing fixcc.py. I don't care as long as the version is specified. Yes, I agree it should be specified. I would

Re: Replacing fixcc.py with clang-format?

2022-09-06 Thread Dan Eble
On Sep 6, 2022, at 12:46, Jean Abou Samra wrote: > > I would like to propose moving to clang-format as the canonical > formatting tool and removing fixcc.py. I don't care as long as the version is specified. — Dan

Re: Replacing fixcc.py with clang-format?

2022-09-06 Thread Jean Abou Samra
Le 06/09/2022 à 20:56, Jonas Hahnfeld a écrit : On Tue, 2022-09-06 at 18:46 +0200, Jean Abou Samra wrote: There's one thing I'd like to discuss now, for the reformatting round before we do the branching. (Yes, I didn't manage yet to propose the reformatting. I'd like to do this after 2.23.13

Re: Replacing fixcc.py with clang-format?

2022-09-06 Thread Luca Fascione
Side thought: if your CPP code is complex, indenting it helps readability a lot, here's a goofy example #if CONDITION # define AMACRO 6 # include "some/file.h" #else # if WIN32 #include "something/else.h" # elif MACOSX #include "the/darwin/version.h" # endif #endif I haven't seen

Re: Replacing fixcc.py with clang-format?

2022-09-06 Thread Jonas Hahnfeld via Discussions on LilyPond development
On Tue, 2022-09-06 at 18:46 +0200, Jean Abou Samra wrote: > There's one thing I'd like to discuss now, for the reformatting round > before we do the branching. (Yes, I didn't manage yet to propose the reformatting. I'd like to do this after 2.23.13 is released. As a reminder, the idea is that we

Replacing fixcc.py with clang-format?

2022-09-06 Thread Jean Abou Samra
Hi, There's one thing I'd like to discuss now, for the reformatting round before we do the branching. With https://gitlab.com/lilypond/lilypond/-/merge_requests/1603, clang-format uses a style that is more consistent with our existing style. Although it still changes around 8500 lines, most of