Minor nit, but otherwise LGTM
https://codereview.appspot.com/261240043/diff/20001/Documentation/usage/lilypond-book.itely
File Documentation/usage/lilypond-book.itely (right):
https://codereview.appspot.com/261240043/diff/20001/Documentation/usage/lilypond-book.itely#newcode31
Logged on issue tracker as Issue 4094: Note_column programming errors
https://codereview.appspot.com/141190043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2014/07/27 08:22:47, uliska wrote:
Apart from my comment LGTM
Good feedback, Urs, and thanks. Changed patchset uploaded.
https://codereview.appspot.com/118350043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Reviewers: ,
Message:
This is a bit of housekeeping, coming from research for a recent
presentation of LilyPond to a group of church musicians.
Description:
DOC: minor revisions to Easier Editing
Moved tunefl per comment 1 issue 2660
Moved LilyPondTool to No longer developed per Bertalan Fodor
http://codereview.appspot.com/6478050/diff/1/THANKS
File THANKS (right):
http://codereview.appspot.com/6478050/diff/1/THANKS#newcode15
THANKS:15: Benkő Pál
I believe that Pál is his given name and Benkő his surname.
http://codereview.appspot.com/6478050/
On 2011/12/05 08:59:18, J_lowe wrote:
http://codereview.appspot.com/5450086/diff/3001/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):
http://codereview.appspot.com/5450086/diff/3001/scm/define-grob-properties.scm#newcode310
scm/define-grob-properties.scm:310:
http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi
File Documentation/contributor/regressions.itexi (right):
http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi#newcode143
Documentation/contributor/regressions.itexi:143:
Pushed as 5f81429c8f8263eef85b4f7881d243cb9722e971
Details of how to push will be in a seperate patch.
http://codereview.appspot.com/4898058/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Regarding the addition of instructions on how to push, I'd like to do
that in a separate patch, unless an experienced developer cares to send
me a rough sketch, point form perhaps, which I could then repackage in
documentation format.
http://codereview.appspot.com/4898058/
Reviewers: Graham Percival, phileholmes_googlemail.com, Reinhold,
reinhold_kainhofer.com, graham_percival-music.ca,
Message:
On 2011/08/19 03:11:15, graham_percival-music.ca wrote:
On Fri, Aug 19, 2011 at 03:21:03AM +0200, Reinhold Kainhofer wrote:
Am Friday 19 August 2011, 02:29:22 schrieb
Pushed by Graham as 2d30bf30c3af6e7c4f1d158ec095c67450adea79
http://codereview.appspot.com/4808051/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Revised as requested.
http://codereview.appspot.com/4808051/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: ,
Message:
Addresses Reinhold's comment re issue 1762
Description:
DOC: fix NR 1.6.3 Formatting Cue Notes
Moves comment about explicitly creating a Voice, to the proper example.
Please review this at http://codereview.appspot.com/4808051/
Affected files:
M
This has had its countdown; please push and close.
http://codereview.appspot.com/4675048/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
This has had its countdown; please push and close.
http://codereview.appspot.com/4636082/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
This has had a 48-hour countdown, and can be pushed and closed, please.
Colin
http://codereview.appspot.com/4667055/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
This has had a 48-hour countdown, and should be pushed and closed,
please.
Colin
http://codereview.appspot.com/4672041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Added issue 1727 for tracking
http://codereview.appspot.com/4661061/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Added issue 1728 to tracker
http://codereview.appspot.com/4527086/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Addewd as issue 1729
http://codereview.appspot.com/4641085/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Should this issue be closed, per the changes list announcing it in 2.14?
http://codereview.appspot.com/1428042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
I gather this is connected to issue 684, so it should probably be marked
closed, Jan.
Thanks,
Colin
http://codereview.appspot.com/1579041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
I believe, since issue 867 is marked verified, that this could be
closed, John.
cheers,
Colin Campbell
Bug Squad
http://codereview.appspot.com/183048/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Just tidying up a bit: has this been superceded by the fix to issue
1671? If so, the reitveld issue could be closed.
cheers,
Colin
http://codereview.appspot.com/224052/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
If this is still alive, Reinhold, I'd like to give it an entry on the
issue tracker. I believe James or I could work with you on the
documentation, as well.
cheers,
Colin
http://codereview.appspot.com/1659041/
___
lilypond-devel mailing list
On 2011/03/23 00:37:07, MikeSol wrote:
I'm using this is in a piece I'm working on and figured it may be
useful in
LilyPond. Let me know what you think!
Mike, is this related to issue 663? If not, 'll open an issue to track
it as an enhancement.
http://codereview.appspot.com/4273098/
Applied to 2.13.56 and shows a change in hara-kiri-tabstaff.ly
Added issue #1577 on bug-lilypond to track this.
http://codereview.appspot.com/4275068/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On 2011/03/18 11:22:11, Trevor Daniels wrote:
LGTM
I like this warning text. Much better.
Trevor
Applying the patch gave the following:
/home/colin/lilypond-git/lily/page-layout-problem.cc: In member function
'void Page_layout_problem::solve_rod_spring_problem(bool)':
On 2011/03/07 19:48:23, J_lowe wrote:
Layout wise - Looks fine.
Colin,
From: Colin Campbell [mailto:c...@shaw.ca]
Sent: 10 March 2011 13:57
To: James Lowe
Subject: Fwd: part combine doc patch
Good morning, James
Attached is a patch which needs pushing, if you would oblige
---
On 2011/03/09 19:13:20, mike_apollinemike.com wrote:
Thanks for the helpful comments! Responses inlined below.
Hi, Mike! Part-time patch helper Colin here.
Mike, this patch has somehow poisoned the doc build and also the make
test functionality, neither of which work since the patch was
On 2011/03/06 12:13:15, Reinhold wrote:
http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely#newcode871
Patch revised to remove the doc-section.sh bits which were pushed
separately. The remainder is just the partcombine explanation.
Ordinarily, I suppose this needn't go on reitveld, but wotthehell
archie, it started here so I'm putting the last bit up to close out the
process.
Actually thinking about it more would it make more sense to have the
auto
function listed first then add the words ... May need some manual
adjustment.'
and then list the rest?
James
I like that very much, James, thanks! A question for Reinhold, though:
do I gather correctly that
On 2011/02/22 12:15:31, Reinhold wrote:
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode852
revised patch uploaded.
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
http://codereview.appspot.com/4188056/diff/1003/Documentation/notation/simultaneous.itely#newcode846
On 2011/02/16 06:08:03, Keith wrote:
Looks good as it is,
better if you can add one markup that Reinhold missed in the example.
http://codereview.appspot.com/4188056/diff/1/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
Reviewers: ,
Message:
Add documentation of partcombine functions.
See issue 1518 on the bug tracker.
Description:
DOC: NR 1.5.2 Multiple voices - part combining
Adds explanations and examples of part combine functions to
NR 1.5.2 Multiple voices - Automatic part combining
Patch based on issue
Reviewers: ,
Message:
Revises and replaces Reinhold's patch in issue 4129053
Description:
DOC: add description of -dinclude-settings
Adds menu reverences and a description of using -dinclude-settings
on the comand line, to change among various global parameters
such as paper or font size.
Revised to incorporate suggestions from Graham and James, for which my
thanks, and some more commas,,,!
http://codereview.appspot.com/4169053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
My first attempt at this, and I hope it is what Reinhold is looking for.
http://codereview.appspot.com/4129053/diff/1/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/4129053/diff/1/Documentation/notation/input.itely#newcode1341
40 matches
Mail list logo
