Thanks Jonas, it works like a charm.
If it doesn't break out-tree build, I think you might push directly.
https://codereview.appspot.com/581910043/
Does this mean that, for example,
Documentation/fr/learning.*.log and
input/regression/collated-files.texilog.log would respectively land in
Documentation/fr/out/ and input/regression/out/ ?
https://codereview.appspot.com/557480043/
Have a look at Documentation/HOWTO.index
https://codereview.appspot.com/579280043/diff/563510048/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
https://codereview.appspot.com/579280043/diff/563510048/Documentation/notation/input.itely#newcode880
Are you a French forensics? (DNA is adn for us)
https://codereview.appspot.com/557380044/diff/563510046/input/regression/multi-measure-rest-reminder.ly
File input/regression/multi-measure-rest-reminder.ly (right):
LGTM
https://codereview.appspot.com/340140043/diff/1/Documentation/included/gsoc.itexi
File Documentation/included/gsoc.itexi (right):
https://codereview.appspot.com/340140043/diff/1/Documentation/included/gsoc.itexi#newcode172
Documentation/included/gsoc.itexi:172: (this would involve working
On 2017/11/11 10:36:16, thomasmorley651 wrote:
On 2017/11/11 10:11:39, Jean-Charles wrote:
> Didn't you forget to amend the English version of changes.tely?…
I changed every changes.tely containing addLyrics in _master_
The english version is empty apart from defaults, because it was moved
Didn't you forget to amend the English version of changes.tely?…
https://codereview.appspot.com/332110043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
https://codereview.appspot.com/333970043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
https://codereview.appspot.com/336030043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2017/09/24 14:20:08, pkx166h wrote:
Corrected the Note styles. Added more formatting changes.
Would you mind formatting the "Standard clefs" as well, which would then
"group" G, C and F-clefs and have a more pleasant layout?
https://codereview.appspot.com/324420043/
otherwise, LGTM
https://codereview.appspot.com/330040043/diff/40001/Documentation/notation/text.itely
File Documentation/notation/text.itely (right):
https://codereview.appspot.com/330040043/diff/40001/Documentation/notation/text.itely#newcode1624
Documentation/notation/text.itely:1624:
On 2017/03/04 18:02:28, pkx166h wrote:
Fails make doc.
Seems to be a problem in the Catalan translations.
Processing web site: [ca]
*** Can't find web/news.itexi, skipping (in
/home/james/lilypond-git/Documentati
on/ca/web/community.itexi l. 1208)
Max error number exceeded
This line
https://codereview.appspot.com/318630043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
That's where I put it yesterday for testing.
https://codereview.appspot.com/300390043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Normally, you should not modify lilypond.pot as it is updated by commit
PO: update template during the releasing phase.
For the *.po files, they are managed through the Free Translation
Project.
https://codereview.appspot.com/256470043/
___
On 2015/08/14 16:47:08, dak wrote:
On 2015/08/14 16:38:18, Jean-Charles wrote:
Normally, you should not modify lilypond.pot as it is updated by
commit PO:
update template during the releasing phase.
For the *.po files, they are managed through the Free Translation
Project.
What does
LGTM
https://codereview.appspot.com/256860044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Sorry to come so late
https://codereview.appspot.com/186640043/diff/40001/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
https://codereview.appspot.com/186640043/diff/40001/Documentation/notation/input.itely#newcode2543
LGTM for French
https://codereview.appspot.com/193890043/diff/1/Documentation/de/notation/ancient.itely
File Documentation/de/notation/ancient.itely (right):
https://codereview.appspot.com/193890043/diff/1/Documentation/de/notation/ancient.itely#newcode2670
just one nitpick, otherwise LGTM.
https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
https://codereview.appspot.com/186640043/diff/1/Documentation/notation/input.itely#newcode2559
https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode127
Documentation/changes.tely:127: the existing @code{\keepWithTag} and
@code{removeWithTag}
If I'm not mistaken, this patch *changes* every natural pitch in English
instead of just adding or including a variant for natural.
Since this will modify what is in place since more than 15 years, it is
essential to document it, both in changes and over the documentation.
Too bad, I prefer
On 2014/08/25 10:13:52, Trevor Daniels wrote:
I think you're mistaken. In the original file the unaltered English
notenames
were defined twice, and this patch alters just one of them, leaving
the other
unchanged. So it does just add a variant.
Sorry, I did not expand enough!
On 2014/06/29 13:51:33, PhilEHolmes wrote:
Please review.
Sorry to step in like that. I'm not able to comment on the code, but
have just one question, since I don't use incipits: does it happen that
the original score reproduced in an incipit happens to be on a four
lines staff? How would it
I just picked one file, but there might be some other occurrences of
such things.
https://codereview.appspot.com/116040043/diff/20001/Documentation/snippets/ancient-notation-templatemodern-transcription-of-mensural-music.ly
File
On 2014/07/20 15:45:14, email_philholmes.net wrote:
[...]
Documentation/snippets/ancient-notation-templatemodern-transcription-of-mensural-music.ly:88:
\once \once \hide NoteHead c'1 |
Why this doubled \once?
Copy and paste error. Unfortunately it's not trivial to correct
properly
Good job! Thanks!
https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/editorial-headword.ly
File Documentation/snippets/editorial-headword.ly (right):
https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/editorial-headword.ly#newcode22
On 2014/07/20 16:49:33, mail_philholmes.net wrote:
- Original Message -
From: mailto:d...@gnu.org
https://codereview.appspot.com/116040043/diff/30001/Documentation/snippets/adding-indicators-to-staves-which-get-split-after-a-break.ly
File
On 2014/02/08 21:55:15, dak wrote:
Is there any way in which one can actually delete this snippet file
without
getting it carried back in via LSR?
According to CG 7.4:
Snippets used in the documentation are in
'$LILYPOND_GIT/Documentation/snippets'.
This directory contains a complete set of
LGTM
https://codereview.appspot.com/60180043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM, except one typo.
https://codereview.appspot.com/41990043/diff/1/Documentation/learning/templates.itely
File Documentation/learning/templates.itely (right):
https://codereview.appspot.com/41990043/diff/1/Documentation/learning/templates.itely#newcode53
On 2013/10/01 11:52:35, dak wrote:
Use @rcontribnamed for translated link names
LGTM
https://codereview.appspot.com/14160044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Message du 13/09/13 00:55
De : Julien Rioux
On 12/09/2013 6:09 PM, Federico Bruni wrote:
2013/8/3 Federico Bruni
I'm getting this error if I run ./autogen.sh in git master:
ERROR: Please install required programs: International New Century
Schoolbook fonts International New
Except one nitpick, LGTM
https://codereview.appspot.com/11455046/diff/1/Documentation/learning/tweaks.itely
File Documentation/learning/tweaks.itely (right):
https://codereview.appspot.com/11455046/diff/1/Documentation/learning/tweaks.itely#newcode2387
Documentation/learning/tweaks.itely:2387:
fro the rest, LGTM
https://codereview.appspot.com/10543044/diff/1/Documentation/notation/chords.itely
File Documentation/notation/chords.itely (right):
https://codereview.appspot.com/10543044/diff/1/Documentation/notation/chords.itely#newcode442
Documentation/notation/chords.itely:442:
Reviewers: dak, Trevor Daniels, Graham Percival,
Message:
Follow up of issue 3392
Description:
Use @dots{} instead of ... in manuals
Web: intro and helpus
Doc: usage, extenting and learning
Please review this at https://codereview.appspot.com/10296043/
Affected files:
M
There is also
notation/rhythms.itely:2320:If a manual beam is specified with
@code{[..]} set the beam
For the rest, LGTM
https://codereview.appspot.com/9964043/diff/1/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
On 2013/06/04 18:33:41, dak wrote:
https://codereview.appspot.com/9964043/diff/1/Documentation/notation/simultaneous.itely#newcode49
Documentation/notation/simultaneous.itely:49: @funindex ...
On 2013/06/04 18:17:21, Jean-Charles wrote:
@funindex @dots{}
No, the index is something that one
LGTM
Jean-Charles
https://codereview.appspot.com/8859044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
Jean-Charles
https://codereview.appspot.com/8933043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2013/04/25 15:20:07, dak wrote:
On 2013/04/25 15:10:35, Graham Percival wrote:
I'm not wild about having ties without a space in front of them, but
I can't
think of any rational reason for my reaction, so I guess LGTM.
Oh, there is a perfectly rational reason: ties are placed
LGTM
Jean-Charles
https://codereview.appspot.com/8599045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
Jean-Charles
https://codereview.appspot.com/8866043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
Cheers,
Jean-Charles
https://codereview.appspot.com/8895044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM
https://codereview.appspot.com/8622047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely#newcode1422
Documentation/notation/rhythms.itely:1422: is usually positive and
LGTM
https://codereview.appspot.com/8540046/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
https://codereview.appspot.com/8538050/diff/1/Documentation/notation/rhythms.itely#newcode1422
Documentation/notation/rhythms.itely:1422: is usually positive and
LGTM,
amended with Ian's comment about _double_ angle brackets.
https://codereview.appspot.com/8581044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Typo
https://codereview.appspot.com/8384043/diff/1/Documentation/notation/vocal.itely
File Documentation/notation/vocal.itely (right):
https://codereview.appspot.com/8384043/diff/1/Documentation/notation/vocal.itely#newcode1637
Documentation/notation/vocal.itely:1637: contexts} which will
On 2013/02/10 16:51:30, PhilEHolmes wrote:
The Czech strings resemble what I deduced from reading what is in
Documentation/cs
LGTM
https://codereview.appspot.com/7307088/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On 2013/01/29 17:25:19, Keith wrote:
I tried to write simpler texts, below. If you are dissatisfied you
can use them as inspiration.
I like this evident wording.
https://codereview.appspot.com/7220052/
___
lilypond-devel mailing list
Reviewers: dak, phileholmes_googlemail.com, Graham Percival,
Message:
Please review
Description:
PO: remove duplicates entries for hh and cc from ALL_PO_SOURCES
Introduced with version 1.0.1 :
in stepmake/stepmake/C.make
ALL_C_SOURCES = h, c, y and l files
in
Message du 25/07/12 00:08
De : Trevor Daniels
A : Graham Percival , John Mandereau
Copie à : lilypond-devel
Objet : Re: Using MSH Paris Nord server
Graham Percival wrote Tuesday, July 24, 2012 10:55 PM
grenouille.lilynet.net.
I like it. Definitely better than crapaud which has
Just to be sure I understand correctly!
http://codereview.appspot.com/6432063/diff/1/Documentation/notation/keyboards.itely
File Documentation/notation/keyboards.itely (right):
http://codereview.appspot.com/6432063/diff/1/Documentation/notation/keyboards.itely#newcode426
On 2012/07/12 12:47:46, janek wrote:
Also, i didn't touch translations (btw, is there a complete list of
Translation Meisters somewhere? didn't find in CG...).
The change will appear with a check-translation when master will be
merged in translation, or a special view on Documentation/ in
Nitpicks, but I had to read twice and carefully the first paragraph and
I'm not sure to understand.
http://codereview.appspot.com/6137050/diff/14003/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
Uploading new version
http://codereview.appspot.com/6195060/diff/1/Documentation/contributor/release-work.itexi
File Documentation/contributor/release-work.itexi (right):
http://codereview.appspot.com/6195060/diff/1/Documentation/contributor/release-work.itexi#newcode87
Reviewers: Graham Percival,
Message:
Both when releasing a stable or unstable version.
Description:
CG: add updating of lilypond.pot in the release process
Please review this at http://codereview.appspot.com/6195060/
Affected files:
M Documentation/contributor/release-work.itexi
Index:
Reviewers: Graham Percival,
Message:
Before integrating po-replace in the release process,
let build a well-formed lilypond.pot in one run.
Description:
PO: modifying po-replace before integrating it to the release process
Until now, updating the translation template file is disconnected from
Message du 20/01/12 03:42
De : Stefan Weil
A : lilypond-devel@gnu.org
Copie à : Stefan Weil
Objet : [PATCH 1/2] Fix spelling definiton - definition
Signed-off-by: Stefan Weil ---
po/cs.po
po/de.po
po/el.po
po/es.po
po/fr.po
po/it.po
po/ja.po
po/lilypond.pot
po/nl.po
po/vi.po
Message du 20/01/12 09:15
De : James
A : Lilyfan
Copie à : StefanWeil , lilypond-devel@gnu.org
Objet : Re: [PATCH 1/2] Fix spelling definiton - definition
Jean-Charles,
On 20 January 2012 08:02, Lilyfan wrote:
Message du 20/01/12 03:42
De : Stefan Weil
A : lilypond-devel@gnu.org
Message du 09/11/11 21:00
De : Graham Percival
A : lilypond-devel@gnu.org
Copie à :
Objet : can't release 2.15.17 due to translators
can somebody fix this? and depending on dak, either push directly
to master (which means he has to play yet more games with
dev/staging), or push to
63 matches
Mail list logo
