Re: Issue 4182: avoid checking the offset of cross-staff stems too early (issue 554030043 by barr...@gmail.com)

On 2020/05/10 15:49:43, Dan Eble wrote: > This is an area of LilyPond that I don't understand very well, so feel free to > ignore this question if the answer should be obvious. This patch removes a call > to get_property (stem, "positioning-done") for cross-staff stems, but doesn't > add an altern

Re: Issue 4182: avoid checking the offset of cross-staff stems too early (issue 554030043 by barr...@gmail.com)

Thank you for looking at this! https://codereview.appspot.com/554030043/diff/583870043/lily/note-head.cc File lily/note-head.cc (right): https://codereview.appspot.com/554030043/diff/583870043/lily/note-head.cc#newcode114 lily/note-head.cc:114: if (stem and ! ly_scm2bool (get_property (stem, "cr

Re: Issue 4182: avoid checking the offset of cross-staff stems too early (issue 554030043 by barr...@gmail.com)

Thank you for looking at this! Issues should be fixed. https://codereview.appspot.com/554030043/diff/582040043/input/regression/cross-staff-stem-offset.ly File input/regression/cross-staff-stem-offset.ly (right): https://codereview.appspot.com/554030043/diff/582040043/input/regression/cross-staf

Doc: issue 1432 (issue 206770044 by barr...@gmail.com)

Reviewers: , Message: Replaced tabs with (8) spaces in all of the .ly files in /ly. Please review! I have never submitted a patch before. Description: Doc: issue 1432 Replaced tabs with spaces in .ly files in /ly Please review this at https://codereview.appspot.com/206770044/ Affected file