Re: Issue 3778: Use bounding box as skylines for markup in svg backend (issue 582010043 by barr...@gmail.com)

2020-05-02 Thread beauleetienne0
On 2020/05/02 07:38:58, hanwenn wrote: > I don't completely understand, though: if we put the "utf-8-string" directly > into the SVG output, the SVG browser might make other font choices, making the > outline potentially incorrect. Is this a problem in practice? There isn't really an "outline"

Issue #5246: Make empty scores abort engraving process (issue 332470043 by beauleetien...@gmail.com)

2017-12-21 Thread beauleetienne0
Reviewers: , Message: It's a bit odd to announce successful engraving of nothing. Description: Issue #5246: Make empty scores abort engraving process This change makes the "no music" warning fatal during the output process. Issue: 5246 Please review this at

Re: Add alpha transparency to SVG backend (issue 330300043 by beauleetien...@gmail.com)

2017-09-22 Thread beauleetienne0
On 2017/09/22 11:34:30, dak wrote: On 2017/09/22 11:19:08, Ebe123 wrote: > Add to regression tests I think it is a bad idea to change rgb-color here: this is a recipe for wide-reaching incompatibilities for the sake of limited applications. It would make more sense to meddle with the type

Re: Add alpha transparency to SVG backend (issue 330300043 by beauleetien...@gmail.com)

2017-09-21 Thread beauleetienne0
On 2017/09/21 10:04:53, Knut_Petersen_t-online.de wrote: > Message: > Adds more flexibility to the coloring of elements in SVG files. It is > disappointing how there is no support in PS, and thus our generation of > PNG. This is useful though in my view, and at least it's available >

Add alpha transparency to SVG backend (issue 330300043 by beauleetien...@gmail.com)

2017-09-20 Thread beauleetienne0
Reviewers: , Message: Adds more flexibility to the coloring of elements in SVG files. It is disappointing how there is no support in PS, and thus our generation of PNG. This is useful though in my view, and at least it's available somewhere. Description: Update documentation for alpha channel

Add version statement to hel-arabic.ly (issue 324460043 by beauleetien...@gmail.com)

2017-09-15 Thread beauleetienne0
Reviewers: , Message: Fixes a little oversight. Description: Add version statement to hel-arabic.ly Fixes warning due to missing version statement. Must have been forgotten in 2be5896dc7 ([#5172]). Please review this at https://codereview.appspot.com/324460043/ Affected files (+1, -0 lines):

Re: Standardize format of `in_color` (issue 329140043 by beauleetien...@gmail.com)

2017-09-13 Thread beauleetienne0
Done. Changed other occurrences too. https://codereview.appspot.com/329140043/diff/1/lily/axis-group-interface.cc File lily/axis-group-interface.cc (right): https://codereview.appspot.com/329140043/diff/1/lily/axis-group-interface.cc#newcode991 lily/axis-group-interface.cc:991: .in_color (1,

Standardize format of `in_color` (issue 329140043 by beauleetien...@gmail.com)

2017-09-09 Thread beauleetienne0
Reviewers: , Message: This is a minor nitpick, just making the format of color commands more consistent. Found it while trying to fix 3778, but fixing it is a big challenge I don't think I'm capable of, sadly. Description: Standardize format of `in_color` The skyline line-pair (as used in

Re: Doc: Add section on SVG to Contributor (issue 328450043 by beauleetien...@gmail.com)

2017-09-05 Thread beauleetienne0
https://codereview.appspot.com/328450043/diff/20001/Documentation/contributor/programming-work.itexi File Documentation/contributor/programming-work.itexi (right): https://codereview.appspot.com/328450043/diff/20001/Documentation/contributor/programming-work.itexi#newcode149

Re: Doc: Add section on SVG to Contributor (issue 328450043 by beauleetien...@gmail.com)

2017-09-04 Thread beauleetienne0
On 2017/09/04 19:24:05, dak wrote: On 2017/09/04 19:11:57, Ebe123 wrote: > While not technically a programming language, PostScript is also listed :) Uh, you are aware that PostScript _is_ a programming language? In contrast, PDF is a file format. That's why there are rather few programs

Doc: Add section on SVG to Contributor (issue 328450043 by beauleetien...@gmail.com)

2017-09-04 Thread beauleetienne0
Reviewers: , Message: While not technically a programming language, PostScript is also listed :) The information could also help when working with SVG output. More work is required on this backend, and I hope this will help. Description: Doc: Add section on SVG to Contributor This change adds

Limit use of `make-concat-markup` in tempo tag (issue 328440043 by beauleetien...@gmail.com)

2017-09-02 Thread beauleetienne0
Reviewers: , Message: This patch provides one part for the fix of bug 5174. Further patches will be needed to combine text of different styles/fonts or to fix text spacing in the SVG backend. This would have still been necessary. Description: Limit use of `make-concat-markup` in tempo tag

Add system-by-system output to SVG backend (issue 323440043 by beauleetien...@gmail.com)

2017-08-18 Thread beauleetienne0
Reviewers: , Message: This is the next step towards the use of the SVG backend for lilypond-book use. Description: Add system-by-system output to SVG backend This change enables the output of separate files for each system of music. In addition, snippet (-dclip-systems) functionality has been

Issue 1434: Fix text spacing in SVG (issue 321460043 by beauleetien...@gmail.com)

2017-08-17 Thread beauleetienne0
Reviewers: pkx, dak, Message: This patch provides a more thorough solution to the spacing problem than my other patch, specifically for metronome marks: https://codereview.appspot.com/323420043/ . Description: Issue 1434: Fix text spacing in SVG This change makes every SVG contain a style tag

Re: Issue 4678: Fix spaces in metronome mark (issue 323420043 by beauleetien...@gmail.com)

2017-08-17 Thread beauleetienne0
We are not losing spaces, the standard is to ignore trailing whitespace, such as line-breaks and (breaking) spaces at the beginning of tabs. We are still using normal spaces where appropriate (such as the second space on line 78). Our translation from markup to SVG does have issues (see issues

Re: Issue 4678: Fix spaces in metronome mark (issue 323420043 by beauleetien...@gmail.com)

2017-08-17 Thread beauleetienne0
On 2017/08/16 22:03:31, dak wrote: Uh, isn't that just skirting the issue? SVG text generation has a bug swallowing spaces and instead of fixing that, one instance of space use rather uses something else? That sounds like a bottomless barrel. Shouldn't we rather try to fix the actual

Add '-dcrop' option to ps and svg backends (issue 329990043 by beauleetien...@gmail.com)

2017-08-11 Thread beauleetienne0
Reviewers: , Message: This change supersedes Issue 326960043 with an entry to changes.tely. Description: Add '-dcrop' option to ps and svg backends This change allows the output of scores in the format provided by the '-dpreview' option but including all systems, not just the first. This

Re: Add '-dcrop' option to ps and svg backends (issue 329990043 by beauleetien...@gmail.com)

2017-08-11 Thread beauleetienne0
This change supersedes Issue 326960043 with an entry to changes.tely. https://codereview.appspot.com/329990043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 4678: Fix spaces in metronome mark (issue 323420043 by beauleetien...@gmail.com)

2017-08-10 Thread beauleetienne0
Reviewers: , Message: Even though this part is fixed, it would be important to combine all consecutive text parts of the tempo indication into one tag. This would make the output neater, as there can be a very wide gap between the text and metronome mark, and the excessive space before the last

Re: Enhance the -dpreview method for SVG output (issue 326960043 by pkx1...@gmail.com)

2017-08-04 Thread beauleetienne0
Add '-dcrop' option to ps and svg backends This change allows the output of scores in the format provided by the '-dpreview' option but including all systems, not just the first. This would allow for easier SVG use in HTML, without the need for cropping snippets. Further, SVG is an HTML

Re: Enhance the -dpreview method for SVG output (issue 326960043 by pkx1...@gmail.com)

2017-08-03 Thread beauleetienne0
In PS2, an implementation of the '-dcrop' argument was added to the 'ps' backend. My implementation has also been revamped to *work* and be more elegant. Letting James upload the patchset. https://codereview.appspot.com/326960043/diff/1/Documentation/usage/running.itely File