Re: ambitus: special handling of small ambits' lines (issue4609041)

2011-06-16 Thread karin . hoethker
Hi Janek, the description explains clearly how to use the parameters gap and woot. So, it is a good starting point to understanding the scheme code that follows. I added a parameter which controlls this, but no reasonable name for it (and for some intermediate stages in the code) comes to my

Re: Bugfix for issue 1630 (issue4490045)

2011-06-15 Thread karin . hoethker
All indentation should be done with spaces. This is why I changed some tabs to spaces - sorry if this caused confusion. I suggest that someone who knows the unwritten rules of indentation finalizes the format issues. http://codereview.appspot.com/4490045/

Re: Bugfix for issue 1630 (issue4490045)

2011-06-13 Thread karin . hoethker
I have send the patch set to Janek for upload. http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc File lily/tie-engraver.cc (right): http://codereview.appspot.com/4490045/diff/20001/lily/tie-engraver.cc#newcode163 lily/tie-engraver.cc:163: /* On 2011/06/01 21:21:25, Neil

Re: Bugfix for issue 1630 (issue4490045)

2011-05-29 Thread karin . hoethker
http://codereview.appspot.com/4490045/diff/12001/lily/completion-note-heads-engraver.cc File lily/completion-note-heads-engraver.cc (right): http://codereview.appspot.com/4490045/diff/12001/lily/completion-note-heads-engraver.cc#newcode207 lily/completion-note-heads-engraver.cc:207:

Re: Bugfix for issue 1630 (issue4490045)

2011-05-29 Thread karin . hoethker
On 2011/05/29 12:14:18, Carl wrote: On 2011/05/29 08:53:30, benko.pal wrote: I must miss something, to me it's still a boolean. and (still to me) it's not an inline conditional, but an assignment of a boolean expression to a boolean variable. I just used inline conditionals as an example

Re: Bugfix for issue 1630 (issue4490045)

2011-05-26 Thread karin . hoethker
You are right, in version 2.13 even shifted tuplets like c'8 \times 2/3 { c'4 c'4 c'4} c'4. are split into correct durations. It seems to me that people are rather in favour of the shorter solution using a boolean flag instead of the duration autosplit-remainder.

Re: Bugfix for issue 1630 (issue4490045)

2011-05-09 Thread karin . hoethker
http://codereview.appspot.com/4490045/diff/1/lily/completion-note-heads-engraver.cc File lily/completion-note-heads-engraver.cc (right): http://codereview.appspot.com/4490045/diff/1/lily/completion-note-heads-engraver.cc#newcode204 lily/completion-note-heads-engraver.cc:204: