Re: Fixing issue 37 with extra position callback (issue3928041)

2011-01-23 Thread mtsolo
I made a lot of changes to get things looking more lilypond-y. I also now have it better handling scenarios where the subdivisions are wacky. Check out: \relative c' { { b32 [ c,16 c'8 d,64 e'8. c,32 e'' ] } \\ { f8 [ c32 d'32 bes,,64 c'64 c64 c'128 ] } } The low D is snug as a bug in a

Re: Fixes issue 39 by raising stems (issue3934041)

2011-01-12 Thread mtsolo
Fixed (I think). Will run regtests in a bit. Meanwhile, it makes this cleanly: \relative c' { \time 2/4 { \autoBeamOff c16 s4.. c'16 s4.. c,16 s4.. c' e g c16 s4.. c4 } \\ { b,2 b'2 c,2 c'2 c4 } } http://codereview.appspot.com/3934041/diff/2001/lily/note-collision.cc File

Re: Fixes issue 39 by raising stems (issue3934041)

2011-01-10 Thread mtsolo
Reviewers: , Message: New patch uploaded to the issue tracker to address Keith's comments. http://codereview.appspot.com/3934041/diff/2001/lily/note-collision.cc File lily/note-collision.cc (right): http://codereview.appspot.com/3934041/diff/2001/lily/note-collision.cc#newcode177

Re: Adds ly:define-event-class (issue1867050)

2010-08-28 Thread mtsolo
Reviewers: Neil Puttock, http://codereview.appspot.com/1867050/diff/17001/18001 File input/regression/scheme-text-spanner.ly (right): http://codereview.appspot.com/1867050/diff/17001/18001#newcode5 input/regression/scheme-text-spanner.ly:5: texidoc = uses define-event-class to create a fully

Build: fix 1167. (issue1929041)

2010-08-09 Thread mtsolo
http://codereview.appspot.com/1929041/diff/1/2 File python/auxiliar/postprocess_html.py (right): http://codereview.appspot.com/1929041/diff/1/2#newcode353 python/auxiliar/postprocess_html.py:353: 'href=\../../../website/development.html\') s.replace does a greedy search for strings and replaces

Re: Create ly:grob-chain-callback from chain_callback (issue1890044)

2010-08-04 Thread mtsolo
Reviewers: Neil Puttock, http://codereview.appspot.com/1890044/diff/1/2 File lily/grob-scheme.cc (right): http://codereview.appspot.com/1890044/diff/1/2#newcode407 lily/grob-scheme.cc:407: 3, 0, 0, (SCM grob, SCM proc, SCM sym), On 2010/08/04 18:50:59, Neil Puttock wrote: 0, (SCM grob

Re: Adds announce-end-grob to engraver-scheme.cc (issue1914043)

2010-08-03 Thread mtsolo
http://codereview.appspot.com/1914043/diff/6001/7001 File lily/engraver-scheme.cc (right): http://codereview.appspot.com/1914043/diff/6001/7001#newcode26 lily/engraver-scheme.cc:26: with give @code{grob_name}, a symbol. @code{cause} On 2010/08/02 22:56:25, Neil Puttock wrote: with given

Re: Adds scheme binding for Side_position_interface::set_axis (issue1880050)

2010-08-03 Thread mtsolo
Reviewers: Neil Puttock, Message: I created a binding for chain_callback in grob-scheme.cc. Please see http://codereview.appspot.com/1890044 . I'm fine using this and then maybe making a scheme version of set_axis (i.e. side-position-interface::set-axis) in the appropriate .scm file. First,

Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)

2010-07-04 Thread mtsolo
Great work! http://codereview.appspot.com/1730044/diff/17001/12002 File scm/define-markup-commands.scm (right): http://codereview.appspot.com/1730044/diff/17001/12002#newcode743 scm/define-markup-commands.scm:743: I think this is EXCELLENT work and has enough shared features with the

<    1   2   3   4   5