Interestingly (or not) I did 3 patch runs on this patch and 2 out of 3
times I still got the reg test showing.
I have some time today so I'll see if I can spot anything and update
accordingly.
Jams
https://codereview.appspot.com/554960043/
~~~
NR: 2.10 Arabic Music - inlcude references to hel-arabic.ly staging
author Hassan Elfatihi
Sun, 30 Jun 2019 10:49:45 +0100 (10:49 +0100)
committer James Lowe
Sun, 14 Jul 2019 13:22:41 +0100 (13:22 +0100)
commit c24f83991b772a65c15b6290cf70d725def117bd
~~~
Hassan
This was stuck as 'please push' for weeks. I have retested the patch
today and
am pushing it on Ur's behalf - seems a shame to waste the work
otherwise.
~~~
Enhancement - New function css-color staging
author Urs Liska
Sun, 14 Jul 2019 13:16:17 +0100 (13:16 +0100)
committer
This was stuck as 'please push' for weeks. I have retested the patch
today and am pushing it on VV's behalf - seems a shame to waste the work
otherwise.
Doc: Use new syntax throughout all doc and examples staging
author Valentin Villenave
Sun, 14 Jul 2019 13:02:02 +0100 (13:02 +0100)
Lukas-Fabian, see the comments about reverting a previous commit within
this patch. I didn't see any reply so am leaving this patch on 'Review'
until the next countdown cycle on the 11th
https://codereview.appspot.com/570830043/
___
lilypond-devel
On 2019/04/25 21:27:39, Valentin Villenave wrote:
spaces not tabs…
Patch counted down - please push
https://codereview.appspot.com/572640043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
On 2019/06/05 14:57:11, git wrote:
This is a follow-up patch to
https://codereview.appspot.com/570690043/
For some reason it was uploaded as a new patch,
and Issue
https://sourceforge.net/p/testlilyissues/issues/5524/
wasn't updated.
This new patch attempts a cleaner separation of color
Reviewers: ,
Message:
Passes make, make check and a full make doc.
Description:
stem.cc - issue 5303 - misplaced notehead
In loop calculating the attachments
of chord node heads to stem,
calculate last used position by
_rounding_ to int rather than by
truncating to int.
This fixes issue 5303
Reviewers: lemzwerg, anthoneyhughes88,
Message:
Thanks Werner
https://codereview.appspot.com/560790043/diff/572830043/Documentation/notation/world.itely
File Documentation/notation/world.itely (right):
Patch counted down - please push
https://codereview.appspot.com/580780043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Patch counted down - please push
https://codereview.appspot.com/572640043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
https://codereview.appspot.com/568820043/diff/582790043/config.make.in
File config.make.in (right):
https://codereview.appspot.com/568820043/diff/582790043/config.make.in#newcode23
config.make.in:23: CONFIG_CFLAGS = @CFLAGS@ $(GLIB_CFLAGS)
$(GUILE_CFLAGS)
On 2019/06/17 07:59:41, knupero wrote:
Reviewers: lemzwerg,
https://codereview.appspot.com/568820043/diff/550830043/config.make.in
File config.make.in (right):
https://codereview.appspot.com/568820043/diff/550830043/config.make.in#newcode34
config.make.in:34: CONFIG_LIBS = @LIBS@ @EXTRA_LIBS@ $(GLIB_LIBS)
$(GUILE_LIBS)
This has moved to http://codereview.appspot.com/568820043
I am closing this one.
https://codereview.appspot.com/552770043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4
File aclocal.m4 (right):
https://codereview.appspot.com/552770043/diff/574800043/aclocal.m4#newcode77
aclocal.m4:77: STEPMAKE_ADD_ENTRY($3, $2)
On 2019/06/07 06:47:17, lemzwerg wrote:
This looks strange, at least here in
https://codereview.appspot.com/550780043/diff/570700043/Documentation/notation/world.itely
File Documentation/notation/world.itely (right):
https://codereview.appspot.com/550780043/diff/570700043/Documentation/notation/world.itely#newcode562
Documentation/notation/world.itely:562: The correct
Reviewers: lemzwerg,
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely
File Documentation/notation/world.itely (right):
https://codereview.appspot.com/550780043/diff/560710043/Documentation/notation/world.itely#newcode74
Reviewers: lemzwerg,
https://codereview.appspot.com/552770043/diff/574790043/aclocal.m4
File aclocal.m4 (right):
https://codereview.appspot.com/552770043/diff/574790043/aclocal.m4#newcode1291
aclocal.m4:1291: save_CPPFLAGS="$CPPFLAGS"
On 2019/06/04 05:40:35, lemzwerg wrote:
we probably should
Are we sure all the reg tests are OK (see tracker for download link)?
For example
regression/chord-name-major7.ly
This looks completely broken with this patch
https://codereview.appspot.com/568650043/
___
lilypond-devel mailing list
Reviewers: ,
Message:
Passes make, make check and a full make doc.
Description:
Axis_group_engraver + Scheme engraver for staff combining
It provides an intuitive user interface
to control whether shared or separate
staves are printed, and should work
for combinations of 4 or more parts.
On 2019/03/09 11:13:18, Malte Meyn wrote:
Could this be done for all other languages (de, es, fr, it, ja) too or
should
that be left to the translators?
Done.
https://codereview.appspot.com/550530043/
___
lilypond-devel mailing list
This has now been pushed
ly: Updates to predefined Ukulele fretboards master staging
author Davide Bonetti
Fri, 18 Jan 2019 11:34:37 + (11:34 +)
committer James Lowe
Fri, 18 Jan 2019 11:36:47 + (11:36 +)
commit
Patch on countdown for January 17th
https://codereview.appspot.com/367880043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Passes make, make check and a full make doc.
Please review
https://codereview.appspot.com/367880043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
author Hassan Elfathi
Wed, 12 Dec 2018 08:19:18 + (08:19 +)
committer James Lowe
Mon, 24 Dec 2018 10:40:01 + (10:40 +)
commit bb5af856e09b4008f3a6e5ff8c13c34b239ae6b9
https://codereview.appspot.com/349810043/
On 2018/12/18 03:44:19, goodadamgood_gmail.com wrote:
Hassan,
I'm having a little bit of difficulty following the thread because I
can't
seem to find the hel-arabic.ly file you're working on. Could you
please
point me to the file so I can play with it?
Thank you in advance
Adam Good
On 2017/05/30 17:50:02, Trevor Daniels wrote:
Looks OK as far as it goes, but the Docs have been missed.
Trevor
This has now been superceded by http://codereview.appspot.com/369930043
https://codereview.appspot.com/323040043/
___
lilypond-devel
On 2018/12/13 17:28:50, haberg-1_telia.com wrote:
> On 12 Dec 2018, at 09:55, mailto:lilyp...@maltemeyn.de wrote:
>
> I don’t know anything about arabic music but there are some changes
that
> look strange to me.
FYI, Adam Good expressed interest updating the Arabic and Persian
files for
Thanks for the review Malte
https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly
File ly/hel-arabic.ly (left):
https://codereview.appspot.com/349810043/diff/1/ly/hel-arabic.ly#oldcode73
ly/hel-arabic.ly:73: %% Sajakar: c' d' edb' f' g' ab' b' c'' c'' bb' a'
g' f' edb' d' c'
On
Reviewers: Malte Meyn,
Message:
On 2018/12/12 15:44:15, hassan.elfatihi_free.fr wrote:
Hello
I am hassan el fatihi author of hel-arabic.ly.
I corrected some minimal errors.
20 makams are working properly. I can give you examples if you wish.
I use the hel-arabic.ly file since 2009.
nits - hope this isn't 'bike-shedding' too much
https://codereview.appspot.com/348040043/diff/20001/Documentation/web/introduction.itexi
File Documentation/web/introduction.itexi (right):
https://codereview.appspot.com/348040043/diff/20001/Documentation/web/introduction.itexi#newcode741
https://codereview.appspot.com/357720044/diff/1/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
https://codereview.appspot.com/357720044/diff/1/Documentation/notation/input.itely#newcode2780
Documentation/notation/input.itely:2780: @node SVG Output
I think
On 2018/06/13 14:38:23, lilypond-pkx wrote:
On 2018/06/04 10:51:25, a.myltsev wrote:
> Removed the 'test' commits, leaving only changes to Python files.
Patch counted down - please push. Alex if you do not have commit
access can you
attach a git-formatted patch (re-based against current
On 2018/06/04 10:51:25, a.myltsev wrote:
Removed the 'test' commits, leaving only changes to Python files.
Patch counted down - please push. Alex if you do not have commit access
can you attach a git-formatted patch (re-based against current master)
and I can push it for you - attach it to the
On 2018/05/26 13:04:12, Dan Eble wrote:
On 2018/05/23 12:22:09, bmwiedemann wrote:
> sorting .o files instead of .cc
This is not quite what I meant. If it works for you, fine, but I
think it is
more likely to break eventually than if you found the commands that
are being
invoked and
On 2018/05/29 07:20:14, dulow kotic wrote:
On 2018/05/29 07:20:04, dulow kotic wrote:
Does this have a relevant 'Tracker issue'? I could not see one.
This is probably why it has been ignored so far, let me know and we can
create one for this Rietveld to get it in the Patch review process.
On 2018/06/01 20:12:25, a.myltsev wrote:
> What are the scripts these 'test' dirs?
Those are actual tests for the added functionality, runnable with
`pytest`.
> Was this a mistake?
No, I believe that these tests are individually useful, even though
not yet
integrated into the Lilypond
On 2018/06/01 11:50:31, a.myltsev wrote:
musicxml2ly: hidden timesigs and tempo marks with text.
What are the scripts these 'test' dirs?
Was this a mistake?
If so can you re-submit the patch please?
thanks
James
https://codereview.appspot.com/34443/
38 matches
Mail list logo
